[HOLD for payment 2024-08-14] [$125][Payment card / Subscription] - No spacing between "Add payment card" and "Request early cancellation" button

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found validating #44763
Version Number: 9.0.12-0
Reproducible in staging?: y
Reproducible in production?: no, not able to check the feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: applause internal team
Slack conversation:

Action Performed:

Precondition:

• Account has collect workspace with an annual subscription.

1. Go to staging.new.expensify.com
2. Go to Subscription.
3. Long click on "Request early cancellation" button.

Expected Result:

There will be spacing between "Add payment card" and "Request early cancellation" button.

Actual Result:

There is no spacing between "Add payment card" and "Request early cancellation" button.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6552300_1721888335021.20240725_141515.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0186c94058bc49c730
• Upwork Job ID: 1816471263631591362
• Last Price Increase: 2024-07-25
• Automatic offers:
• c3024 | Reviewer | 103355027
• nkdengineer | Contributor | 103355030

Issue Owner

Current Issue Owner: @twisterdotcom

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[etCoderDysto]

Proposal

Offending PR #44763

Please re-state the problem that we are trying to solve in this issue.

No spacing between "Add payment card" and "Request early cancellation" button

What is the root cause of that problem?

We are not adding niether margin top for Request early cancellation nor margin bottom for Add payment card button

App/src/pages/settings/Subscription/CardSection/RequestEarlyCancellationMenuItem/index.tsx

Lines 16 to 21 in 2a9134d

	<MenuItem
	title={translate('subscription.requestEarlyCancellation.title')}
	icon={Expensicons.CalendarSolid}
	iconFill={theme.success}
	shouldShowRightIcon
	wrapperStyle={styles.sectionMenuItemTopDescription}

What changes do you think we should make in order to solve the problem?

add margin top for Request early cancellation

wrapperStyle={[styles.sectionMenuItemTopDescription, styles.mt2]}

What alternative solutions did you explore? (Optional)

Add margin bottom to Add payment card button

style={[styles.w100, styles.mb2]}

App/src/pages/settings/Subscription/CardSection/CardSectionDataEmpty/index.tsx

Lines 17 to 20 in b0f810d

	<Button
	text={translate('subscription.cardSection.addCardButton')}
	onPress={openAddPaymentCardScreen}
	style={styles.w100}

[etCoderDysto]

Offending PR #44763

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no spacing between "Add payment card" and "Request early cancellation" button.

What is the root cause of that problem?

We have a margin-bottom style here to add a space between these menuItems and the card button. But this item is not always displayed and then when it's not displayed, there is no space between menuItem and the card button.

App/src/pages/settings/Subscription/CardSection/CardSection.tsx

Line 153 in e9ec3e9

style={styles.mt5}

What changes do you think we should make in order to solve the problem?

We should remove the margin-top style here and wrap CardSectionDataEmpty in a view with style mb5

App/src/pages/settings/Subscription/CardSection/CardSection.tsx

Line 132 in e9ec3e9

{isEmptyObject(defaultCard?.accountData) && <CardSectionDataEmpty />}

What alternative solutions did you explore? (Optional)

Or we can add mt5 style for the second menu item if the first item isn't displayed and add mt5 style for the third menu item if both the first and the second item are not displayed.

[cristipaval]

Demoting it

[cristipaval]

Making it a $125 issue as it is a super simple visual thing

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0186c94058bc49c730

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[c3024]

@nkdengineer 's proposal here looks good to me.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

Current assignee @cristipaval is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[etCoderDysto]

@c3024 can you please comment on my propsoal?

[c3024]

@etCoderDysto

Sorry for not giving clear feedback. Here is why I felt @nkdengineer 's proposal was better.

These three (including RequestEarlyCancellationMenuItem)

App/src/pages/settings/Subscription/CardSection/CardSection.tsx

Lines 144 to 169 in 5a0b7aa

	{!!account?.hasPurchases && (
	<MenuItem
	shouldShowRightIcon
	icon={Expensicons.History}
	wrapperStyle={styles.sectionMenuItemTopDescription}
	title={translate('subscription.cardSection.viewPaymentHistory')}
	titleStyle={styles.textStrong}
	onPress={() => Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: CONST.SEARCH.TAB.EXPENSE.ALL}))}
	hoverAndPressStyle={styles.hoveredComponentBG}
	style={styles.mt5}
	/>
	)}
	{!!(subscriptionPlan && account?.isEligibleForRefund) && (
	<MenuItem
	shouldShowRightIcon
	icon={Expensicons.Bill}
	wrapperStyle={styles.sectionMenuItemTopDescription}
	title={translate('subscription.cardSection.requestRefund')}
	titleStyle={styles.textStrong}
	disabled={isOffline}
	onPress={() => setIsRequestRefundModalVisible(true)}
	/>
	)}
	{privateSubscription?.type === CONST.SUBSCRIPTION.TYPE.ANNUAL && <RequestEarlyCancellationMenuItem />}

are menu items and menu items do not have gaps between themselves. A set of menu items is separated from other elements like a button etc.

This is the same pattern used everywhere in the repo.

That is why only the first item has a margin top but others do not. But these menu items render conditionally so the top most menu item may not render. In such cases, there will be no gap between the button and menu item (or set of menu items). This logic was missed in the code.

If we add mt2 to RequestEarlyCancellationMenuItem like you suggested then if either or both of these menu items

App/src/pages/settings/Subscription/CardSection/CardSection.tsx

Lines 144 to 167 in 5a0b7aa

	{!!account?.hasPurchases && (
	<MenuItem
	shouldShowRightIcon
	icon={Expensicons.History}
	wrapperStyle={styles.sectionMenuItemTopDescription}
	title={translate('subscription.cardSection.viewPaymentHistory')}
	titleStyle={styles.textStrong}
	onPress={() => Navigation.navigate(ROUTES.SEARCH_CENTRAL_PANE.getRoute({query: CONST.SEARCH.TAB.EXPENSE.ALL}))}
	hoverAndPressStyle={styles.hoveredComponentBG}
	style={styles.mt5}
	/>
	)}
	{!!(subscriptionPlan && account?.isEligibleForRefund) && (
	<MenuItem
	shouldShowRightIcon
	icon={Expensicons.Bill}
	wrapperStyle={styles.sectionMenuItemTopDescription}
	title={translate('subscription.cardSection.requestRefund')}
	titleStyle={styles.textStrong}
	disabled={isOffline}
	onPress={() => setIsRequestRefundModalVisible(true)}
	/>
	)}

appear, then there will be a undesired 8px gap between these menu item(s) and the RequestEarlyCancellationMenuItem.

[etCoderDysto]

No problem! That makes sense. Thanks for the explanation @c3024 🙌.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: add spacing between 2 buttons #46690

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment automatic offer (Reviewer)
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024] Determine if we should create a regression test for this bug.
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[c3024]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: feat: integrate retry billing with backend #44268
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/44268/files#r1717695800
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No discussion was started because this could not have been identified earlier.
• [@c3024] Determine if we should create a regression test for this bug. Yes
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Login with an account with a workspace
2. Click on Avatar (Account Settings) in the Bottom Bar > Subscriptions on the left pane
3. Long click on "Request early cancellation" button.
4. Verify that there is space between "Add payment card" button and "Request early cancellation" menu item.

[twisterdotcom]

Payment Summary:

• @c3024 paid $125 here (Reviewer)
• @nkdengineer paid $125 here (Contributor)