[Hold for payment: 2024-09-24] [$250] Task - Unable to remove task description

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.11-2
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4760280
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to DM
3. Create a task with description
4. Go to task report
5. Click Description
6. Remove the description and save it

Expected Result:

User will be able to remove the task description

Actual Result:

User is unable to remove the task description

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6551397_1721815786409.20240724_180756.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01059741d391e013aa
• Upwork Job ID: 1823259419206003933
• Last Price Increase: 2024-08-27
• Automatic offers:
• allgandalf | Reviewer | 103704842
• FitseTLT | Contributor | 103704845

Issue Owner

Current Issue Owner: @allgandalf

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@dylanexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #vip-vsp

[FitseTLT]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Task - Unable to remove task description

What is the root cause of that problem?

Empty string will be falsy here

App/src/libs/actions/Task.ts

Lines 502 to 503 in a79189f

	const newDescription = description ? ReportUtils.getParsedComment(description) : report.description;
	const reportDescription = (newDescription ?? '').trim();

so it will set it to the previous description

What changes do you think we should make in order to solve the problem?

change it to

    const newDescription = typeof description === 'string' ? ReportUtils.getParsedComment(description) : report.description;

What alternative solutions did you explore? (Optional)

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to remove task description

What is the root cause of that problem?

When description is empty string we are assigning the old description value (report.description) to newDescription. This will prevent new description from being assigned undefined when user edits task title that has an existing description, and remove existing description in the process. This is because description is undefined when user edits task title. But when the user removes existing description, the old description value (report.description) is assigned to newDescription since empty string is regarded as false when we use ? instead of ??.

App/src/libs/actions/Task.ts

Line 502 in a79189f

const newDescription = description ? ReportUtils.getParsedComment(description) : report.description;

What changes do you think we should make in order to solve the problem?

We should assign description to newDescription when description is an empty string and assign report.description when description is undefined

    const newDescription = description ? ReportUtils.getParsedComment(description) : description ?? report.description;

What alternative solutions did you explore? (Optional)

[dylanexpensify]

Will repro today!

…

On Wed, 24 Jul 2024 at 14:40, Night Coder ***@***.***> wrote: Proposal Please re-state the problem that we are trying to solve in this issue. Unable to remove task description What is the root cause of that problem? When description is empty string we are assigning the old description value (report.description) to newDescription. This will prevent new description from being assigned undefined when user edits task title that has an existing description, and remove existing description in the process. This is because description is undefined when user edits task title. But when the user removes existing description, the old description value (report.description) is assigned to newDescription since empty string is regarded as false when we use ? instead of ??. https://github.com/Expensify/App/blob/a79189f2294a07a737bebbf5423f7d19ebf9d467/src/libs/actions/Task.ts#L502 What changes do you think we should make in order to solve the problem? We should assign description to newDescription when description is an empty string and assign report.description when description is undefined const newDescription = description ? ReportUtils.getParsedComment(description) : description ?? report.description; What alternative solutions did you explore? (Optional) — Reply to this email directly, view it on GitHub <#46111 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOKVCAG26L6DBDLDUABTSS3ZN6VDFAVCNFSM6AAAAABLMP7PQ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBXHE3DKMJVGQ> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[melvin-bot]

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@dylanexpensify Still overdue 6 days?! Let's take care of this!

[melvin-bot]

@dylanexpensify 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[dylanexpensify]

reviewing today!

[dylanexpensify]

Confirming behavior

[melvin-bot]

@dylanexpensify this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[melvin-bot]

@dylanexpensify Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01059741d391e013aa

[dylanexpensify]

Forgot to hit external!

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allgandalf (External)

[eucool]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Unable to save empty description.

What is the root cause of that problem?



When we save empty string, we essentially havedescription as false and hence we fallback to the previous description:




App/src/libs/actions/Task.ts

Line 502 in a79189f

const newDescription = description ? ReportUtils.getParsedComment(description) : report.description;






That is why the description is not updated if we save a empty string

What changes do you think we should make in order to solve the problem?

We do not need the check in place, we can directly set the newDescription to ReportUtils.getParsedComment(description):

 const newDescription = ReportUtils.getParsedComment(description);

This is because we already validate if the prop passed is string when we call the util functions:

App/src/pages/tasks/TaskDescriptionPage.tsx

Lines 52 to 55 in b7f7f1b

	if (values.description !== Parser.htmlToMarkdown(report?.description ?? '') && !isEmptyObject(report)) {
	// Set the description of the report in the store and then call EditTask API
	// to update the description of the report on the server
	Task.editTask(report, {description: values.description});

What alternative solutions did you explore? (Optional)

[allgandalf]

Thanks for proposals everyone 🙏 , all you guys have the correct RCA!

Coming to solution:

@etCoderDysto I feel your solution is a little over-engineering and not a correct way to approach.

@FitseTLT , though your solution would solve this but the description would always be of string type and that check is not needed as we only call editTask for editing description when we have one (some value / empty string).

With that said, lets go with @eucool 's proposal here, their solution seems more appropriate for this bug

🎀👀🎀 C+ reviewed

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@deetergp, @dylanexpensify, @allgandalf Eep! 4 days overdue now. Issues have feelings too...

[deetergp]

Any updates @allgandalf?

[allgandalf]

sorry for the delay, We can go with @FitseTLT 's proposal here, I didn't consider the case where we edit title, honest mistake on my part, sorry @deetergp @FitseTLT @etCoderDysto 🙇

If we edit the description then the type of description will be a string and if we edit title then description will be undefined:

So @FitseTLT 's solution will be better suited for this bug

🎀👀🎀 C+ reviewed

[melvin-bot]

Current assignee @deetergp is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[etCoderDysto]

@allgandalf @FitseTLT's last edit and my proposal came at the same time (4:39). And my propsal has details of how description field becomes undefined when editing title. This is to ask if having a clear, and detailed RCA would make my proposal a better choice.

cc: @deetergp
Thanks!

[melvin-bot]

@deetergp @dylanexpensify @allgandalf this issue is now 4 weeks old, please consider:

• Finding a contributor to fix the bug
• Closing the issue if BZ has been unable to add the issue to a VIP or Wave project
• If you have any questions, don't hesitate to start a discussion in #expensify-open-source

Thanks!

[allgandalf]

bump on assignment @deetergp , summary here, thanks !

[etCoderDysto]

@allgandalf can you please comment on my question here.

Thanks!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 @allgandalf 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @FitseTLT 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[dylanexpensify]

@allgandalf @FitseTLT mind giving an update

[allgandalf]

Automation failed here, the PR was deployed to production yesterday with the checklist: #48664

[dylanexpensify]

TY!

[dylanexpensify]

Nice will pay today!

[allgandalf]

can you pay this one please @dylanexpensify

[FitseTLT]

@dylanexpensify payment Ooooverdue here

[dylanexpensify]

Payment summary:

Contributor: @FitseTLT $250 via Upwork
Contributor+: @allgandalf $250 via Upwork

Please apply/request!

[dylanexpensify]

Paid!