Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$250] [HOLD for payment 2024-08-14] [CRITICAL] [Advanced Approval Workflows] Implement <ApprovalWorkflowSection /> component that displays a single #45951

Closed
tgolen opened this issue Jul 22, 2024 · 17 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task

Comments

@tgolen
Copy link
Contributor

tgolen commented Jul 22, 2024

Coming from: #wave-control: advanced approval + workflows polish

Issue OwnerCurrent Issue Owner: @
Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01020b6decd916d6fa
  • Upwork Job ID: 1825664111821732105
  • Last Price Increase: 2024-08-19
@JmillsExpensify
Copy link

@Guccio163 can you comment on this issue so I can assign you?

@Guccio163
Copy link
Contributor

Guccio163 commented Jul 23, 2024

Yes, I'm a developer from Software Mansion and I just wanted to take it today, assign it to me and I'll probably finish it tomorrow!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Jul 25, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 31, 2024
tgolen added a commit that referenced this issue Aug 5, 2024
…implementApprovalWorkflowSection

#45951 & #45958: Implement <ApprovalWorkflowSection /> component and Enhance toLocaleOrdinal to support string ordinals
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Aug 7, 2024
@melvin-bot melvin-bot bot changed the title [CRITICAL] [Advanced Approval Workflows] Implement <ApprovalWorkflowSection /> component that displays a single [HOLD for payment 2024-08-14] [CRITICAL] [Advanced Approval Workflows] Implement <ApprovalWorkflowSection /> component that displays a single Aug 7, 2024
Copy link

melvin-bot bot commented Aug 7, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Aug 7, 2024
Copy link

melvin-bot bot commented Aug 7, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.17-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-08-14. 🎊

For reference, here are some details about the assignees on this issue:

  • @Guccio163 does not require payment (Contractor)

@shubham1206agra
Copy link
Contributor

@tgolen I reviewed the PR here. Please assign me this issue.

Copy link

melvin-bot bot commented Aug 8, 2024

Triggered auto assignment to @VictoriaExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added the Daily KSv2 label Aug 8, 2024
@melvin-bot melvin-bot bot removed the Weekly KSv2 label Aug 8, 2024
@tgolen
Copy link
Contributor Author

tgolen commented Aug 8, 2024

@VictoriaExpensify Can you please assist with paying @shubham1206agra for a C+ review of the PR?

Copy link

melvin-bot bot commented Aug 13, 2024

@tgolen, @VictoriaExpensify, @shubham1206agra, @Guccio163 Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added Overdue Daily KSv2 and removed Daily KSv2 Overdue labels Aug 13, 2024
Copy link

melvin-bot bot commented Aug 14, 2024

Payment Summary

Upwork Job

  • ROLE: @shubham1206agra paid $(AMOUNT) via Upwork (LINK)
  • Contributor: @Guccio163 is from an agency-contributor and not due payment

BugZero Checklist (@VictoriaExpensify)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@shubham1206agra
Copy link
Contributor

@VictoriaExpensify Bump here

Copy link

melvin-bot bot commented Aug 19, 2024

@tgolen, @VictoriaExpensify, @shubham1206agra, @Guccio163 Huh... This is 4 days overdue. Who can take care of this?

@melvin-bot melvin-bot bot added the Overdue label Aug 19, 2024
@VictoriaExpensify VictoriaExpensify added the External Added to denote the issue can be worked on by a contributor label Aug 19, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-08-14] [CRITICAL] [Advanced Approval Workflows] Implement <ApprovalWorkflowSection /> component that displays a single [$250] [HOLD for payment 2024-08-14] [CRITICAL] [Advanced Approval Workflows] Implement <ApprovalWorkflowSection /> component that displays a single Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

Job added to Upwork: https://www.upwork.com/jobs/~01020b6decd916d6fa

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Aug 19, 2024
Copy link

melvin-bot bot commented Aug 19, 2024

Current assignee @shubham1206agra is eligible for the External assigner, not assigning anyone new.

@VictoriaExpensify
Copy link
Contributor

Sorry, automation didn't work since the External label wasn't applied. Working on this now.

@melvin-bot melvin-bot bot removed the Overdue label Aug 19, 2024
@VictoriaExpensify
Copy link
Contributor

@shubham1206agra - I've sent you an offer in Upwork, can you please let me know when you've accepted it and I'll approve payment. Thanks!

@shubham1206agra
Copy link
Contributor

@VictoriaExpensify Offer accepted

@VictoriaExpensify
Copy link
Contributor

Payment Summary:
Contributor: @Guccio163 is from an agency-contributor and not due payment
Contributor+: @shubham1206agra paid $250 via Upwork

Thanks for your work on this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors Task
Projects
None yet
Development

No branches or pull requests

5 participants