[HOLD for payment 2024-08-02] Dupe detection - Green Confirm button is shorter in width

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.10-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat
3. Submit two same expenses (same amount and merchant)
4. Go to transactiont thread of any expense
5. Click Review duplicates
6. Click Keep this one
7. Proceed to confirmation page

Expected Result:

The green Confirm button will have the same size as other green buttons across the app

Actual Result:

The green Confirm button is shorter

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6547678_1721437920252.20240720_091138.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @JmillsExpensify

[melvin-bot]

Triggered auto assignment to @hayata-suenaga (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Green Confirm button is shorter in width

What is the root cause of that problem?

We don't handle the medium and large props on the confirm button like here

App/src/pages/TransactionDuplicate/Confirmation.tsx

Lines 83 to 88 in 298f63b

	<Button
	text={translate('common.confirm')}
	success
	style={[styles.ph5, styles.mt2]}
	onPress={mergeDuplicates}
	/>

What changes do you think we should make in order to solve the problem?

Pass medium and large based on the isExtraSmallScreenHeight value from useWindowDimensions()

Add the following code here

const {isExtraSmallScreenHeight} = useWindowDimensions();

And update this code to the following

<Button
    text={translate('common.confirm')}
    success
    style={[styles.ph5, styles.mt2]}
    onPress={mergeDuplicates}
    medium={isExtraSmallScreenHeight}
    large={!isExtraSmallScreenHeight}
/>

RESULT

What alternative solutions did you explore? (Optional)

[nyomanjyotisa]

Proposal updated

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Dupe detection - Green Confirm button is shorter in width

What is the root cause of that problem?

There are two issues here.:

1. Confirmation width/height is shorter.

• large prop isn't passed to Button.

• App/src/pages/TransactionDuplicate/Confirmation.tsx

  Lines 83 to 88 in fa738c6

  	<Button
  	text={translate('common.confirm')}
  	success
  	style={[styles.ph5, styles.mt2]}
  	onPress={mergeDuplicates}
  	/>

2. Confirmation button isn't at the bottom

• ScrollView content container doesn't take full available height.
• We have applied styles.mt2 instead of styles.auto to Button element.

What changes do you think we should make in order to solve the problem?

• We should add large prop to Button element.
• We need to pass contentContainerStyle={styles.flex1} to ScrollView.
• Replace styles.mt2 with styles.auto on Button element.

What alternative solutions did you explore? (Optional)

• We can remove style={styles.mb3} from ScrollView and add contentContainerStyle={styles.flex1}.
• Wrap Button with FixedFooter and apply style={[styles.mtAuto]} to `FixedFooter.
• Remove style prop from Button or only keep margin top if required.

Result

Before fix

After fix

[Krishna2323]

Proposal Updated

• Added alternative solution and screenshots

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[mountiny]

Dupe detection is behind beta so we can remove the blocker

cc @kubabutkiewicz @pecanoro @parasharrajat

[kubabutkiewicz]

Hi, I will create PR soon to fix that issue @mountiny @pecanoro @parasharrajat

[parasharrajat]

@kubabutkiewicz Assign me to the PR as reviewer.

[pecanoro]

@hayata-suenaga I am reassigning the issue to myself so I can review and track the fixes since this is for the duplicate detection project that I am handling.

[melvin-bot]

Current assignee @JmillsExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.12-0 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Polish: Dupe detection #45890

If no regressions arise, payment will be issued on 2024-08-02. 🎊

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@pecanoro] The PR that introduced the bug has been identified. Link to the PR:
• [@pecanoro] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@pecanoro] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@pecanoro] Determine if we should create a regression test for this bug.
• [@pecanoro] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@JmillsExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

@JmillsExpensify, @pecanoro Eep! 4 days overdue now. Issues have feelings too...

[JmillsExpensify]

Payment summary: $250 to @parasharrajat for PR review and testing. This is a new feature and we already have an issue to add tests centrally. @parasharrajat please submit a request on New Expensify when you have a chance.

[parasharrajat]

payment requested as per #45815 (comment)

[garrettmknight]

Payment summary:

• Reviewer: @parasharrajat $250 via NewDot

[JmillsExpensify]

Thanks, moving forward with the approval. $250 approved for @parasharrajat