Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment issue for E/App PR#45331 #45747

Closed
melvin-bot bot opened this issue Jul 19, 2024 · 12 comments
Closed

Payment issue for E/App PR#45331 #45747

melvin-bot bot opened this issue Jul 19, 2024 · 12 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task

Comments

@melvin-bot
Copy link

melvin-bot bot commented Jul 19, 2024

Issue created to compensate the Contributor+ member for their work on #45331
E/E issue linked to the PR - no internal issue.
Contributor+ member who reviewed the PR - @shubham1206agra.

Wait 7 days after the PR is deployed to production before issuing payment in case there are regressions.

@melvin-bot melvin-bot bot added Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Task Weekly KSv2 labels Jul 19, 2024
@melvin-bot melvin-bot bot added the Internal Requires API changes or must be handled by Expensify staff label Jul 19, 2024
Copy link
Author

melvin-bot bot commented Jul 19, 2024

Triggered auto assignment to @lschurr (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 19, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 19, 2024

PR is still open. Moving to Weekly and will check next week.

@lschurr lschurr added Weekly KSv2 and removed Daily KSv2 labels Jul 19, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 23, 2024

PR is merged but not deployed yet.

@shubham1206agra
Copy link
Contributor

@twisterdotcom I am not sure if I am eligible for payment here or not. Since this was a follow-up of #37824, but it also fixed an RN bug which was not in the scope of the issue.

@twisterdotcom
Copy link
Contributor

If it fixed another bug anyway, let's pay out for it as normal.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 25, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 25, 2024

PR is on staging

@melvin-bot melvin-bot bot added the Overdue label Jul 29, 2024
@lschurr
Copy link
Contributor

lschurr commented Jul 29, 2024

PR is still on staging

@melvin-bot melvin-bot bot removed the Overdue label Jul 29, 2024
@lschurr lschurr added Weekly KSv2 and removed Daily KSv2 labels Jul 30, 2024
Copy link
Author

melvin-bot bot commented Aug 2, 2024

@lschurr @shubham1206agra this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

@lschurr
Copy link
Contributor

lschurr commented Aug 6, 2024

Oops, I read this wrong since the staging comment came after prod on the PR for some reason. It actually hit prod on July 25th, so payment is due.

@lschurr
Copy link
Contributor

lschurr commented Aug 6, 2024

@shubham1206agra - Offer sent in Upwork: https://www.upwork.com/nx/wm/offer/103424895

@lschurr lschurr added Daily KSv2 and removed Weekly KSv2 labels Aug 6, 2024
@shubham1206agra
Copy link
Contributor

@lschurr Offer accepted

@lschurr
Copy link
Contributor

lschurr commented Aug 7, 2024

Payment summary:

@lschurr lschurr closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff Task
Projects
None yet
Development

No branches or pull requests

3 participants