Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-17] [$500] [CRITICAL] Create Trip Receipt for newDot #37824

Closed
stitesExpensify opened this issue Mar 6, 2024 · 25 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@stitesExpensify
Copy link
Contributor

stitesExpensify commented Mar 6, 2024

VIP-Travel Implementation Issue

Tracking Issue: https://github.com/Expensify/Expensify/issues/333471
Project: https://github.com/orgs/Expensify/projects/112/
Relevant Design Doc Section: https://docs.google.com/document/d/122DLLTuCsU4NC3c7rNiy4UF8bZxVlLEWSy3yncqCTcQ/edit#bookmark=id.lgcmthyxnpmx

This issue is for creating a special receipt preview for trips:
2024-03-06_07-50-59

We will update ReceiptUtils.getThumbnailAndImageURIs so that, if the transaction is for transport (and doesn’t have an attached receipt), the plane placeholder is displayed, and, if it is for lodging, the bed one is displayed.

Issue OwnerCurrent Issue Owner: @twisterdotcom
Copy link

melvin-bot bot commented Mar 6, 2024

Current assignee @twisterdotcom is eligible for the NewFeature assigner, not assigning anyone new.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Mar 6, 2024
@twisterdotcom twisterdotcom moved this to Critical - V1 in [#whatsnext] #travel Mar 6, 2024
@cdOut
Copy link
Contributor

cdOut commented Mar 8, 2024

Hello, I’m Tymoteusz from Software Mansion, the expert agency, and I’d like to work on this task.

@twisterdotcom
Copy link
Contributor

Adding a C+ here for Travel reviews: @shubham1206agra

@cdOut
Copy link
Contributor

cdOut commented Mar 18, 2024

As an update, I’m currently working on setting up a draft PR by tomorrow.

@melvin-bot melvin-bot bot removed the Overdue label Mar 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@twisterdotcom
Copy link
Contributor

How is this PR going @cdOut?

@twisterdotcom
Copy link
Contributor

Waiting on the backend.

@melvin-bot melvin-bot bot removed the Overdue label Apr 11, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@twisterdotcom
Copy link
Contributor

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@twisterdotcom
Copy link
Contributor

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 20, 2024
Copy link

melvin-bot bot commented Jul 3, 2024

Triggered auto assignment to @yuwenmemon, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@twisterdotcom twisterdotcom changed the title [MEDIUM] Create Trip Receipt for newDot [CRITICAL] Create Trip Receipt for newDot Jul 5, 2024
@twisterdotcom twisterdotcom moved this from Medium - V1.5 to Critical - V0 in [#whatsnext] #travel Jul 5, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [CRITICAL] Create Trip Receipt for newDot [HOLD for payment 2024-07-17] [CRITICAL] Create Trip Receipt for newDot Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [CRITICAL] Create Trip Receipt for newDot [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] Create Trip Receipt for newDot Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@shubham1206agra] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@twisterdotcom] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 16, 2024
@twisterdotcom twisterdotcom changed the title [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [CRITICAL] Create Trip Receipt for newDot [HOLD for payment 2024-07-17] [CRITICAL] Create Trip Receipt for newDot Jul 17, 2024
Copy link

melvin-bot bot commented Jul 17, 2024

Payment Summary

Upwork Job

BugZero Checklist (@twisterdotcom)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@twisterdotcom twisterdotcom changed the title [HOLD for payment 2024-07-17] [CRITICAL] Create Trip Receipt for newDot [HOLD for payment 2024-07-17] [$500] [CRITICAL] Create Trip Receipt for newDot Jul 18, 2024
Copy link

melvin-bot bot commented Jul 18, 2024

⚠️ Could not update price automatically because there is no linked Upwork Job ID. The BZ team member will need to update the price manually in Upwork.

@twisterdotcom
Copy link
Contributor

Payment Summary:

@github-project-automation github-project-automation bot moved this from Critical - GBTA July 22 to Done in [#whatsnext] #travel Jul 18, 2024
@shubham1206agra
Copy link
Contributor

@twisterdotcom Accepted offer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
Development

No branches or pull requests

6 participants