[Workspace Feeds] [$50] Change Cards & Domains tab to Domains in settings

[kevinksullivan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Reproducible in staging?: Y
Reproducible in production?: Y

Slack conversation: https://expensify.slack.com/archives/C06ML6X0W9L/p1720038761870689

Action Performed:

1. Sign up on NewDot
2. Create a workspace
3. Navigate to settings

Expected Result:

Cards & Domains tab should just say Domains, since cards will be supported in NewDot within the workspace.

Actual Result:

The tab says Cards & Domains.

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b56ebd1169d98c19
• Upwork Job ID: 1816676250720638908
• Last Price Increase: 2024-08-08

Issue Owner

Current Issue Owner: @DylanDylann

[melvin-bot]

Triggered auto assignment to @isabelastisser (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

[melvin-bot]

Triggered auto assignment to Design team member for new feature review - @dubielzyk-expensify (NewFeature)

[kevinksullivan]

also discussing here

[kevinksullivan]

No UI changes need so I will take @dubielzyk-expensify off of this.

[melvin-bot]

@anmurali @isabelastisser @mountiny this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[mountiny]

all good Melvin

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b56ebd1169d98c19

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @DylanDylann (External)

[JmillsExpensify]

Said differently, I think we should make this change now. Cards and Domains is inaccurate so we should fix this ASAP. The feature someone is accessing is domains/domain control. Let's make that clear and change this to Domains now, not later.

[trjExpensify]

We're confusing lots of users who are looking for personal card import.

Are they? I just know this convo came up on the topic of (coming soon) workspace feed card features in the workspace. At which point, it's confusing to point to card management elsewhere with "Cards & Domains". Until then, we don't have any visibility for card settings.

Not passionate, we're talking a week or so until we take it out of beta.

[JmillsExpensify]

Right, but I saying that we don't have card functionality on NewDot either way. Again, looking at Fullstory sessions, this is consistently a point of confusion. People click this button and immediately come back and start clicking somewhere else. They are looking for something that we don't have in my opinion, which is personal card import.

[mountiny]

Created a draft for this, just simple copy changes #47119

[JmillsExpensify]

As a result, I don't think this is a solution to anything in particular, so I think we should remove it. Whether or not we have workspace feeds doesn't change anything for me. You still need to create a workspace and then go to More Features to find company feeds regardless - whenever that exists.

[trjExpensify]

They are looking for something that we don't have in my opinion, which is personal card import.

Alright, or they're just early exploring the features and not ready to connect cards yet.

Created a draft for this, just simple copy changes #47119

Ship it 👍

[mountiny]

Shipped

@nkdengineer sorry this was just quick fix

[melvin-bot]

Triggered auto assignment to @shawnborton (Design), see these Stack Overflow questions for more details.

[mountiny]

@shawnborton wanted to ask if we should also update the icon for the Domains now that we only link to domains and no cards

[dubielzyk-expensify]

I like the idea of using the globe icon only here, but I'll let Mr Borton have the call.

[JmillsExpensify]

Agree with the global icon only, though I don't have approval power over Mr. Borton.

[mountiny]

I can use the Globe icon, I am not Borton though so I am worried to see what might happen

[mountiny]

[JmillsExpensify]

Maybe we push the button and if Mr Borton is mad tomorrow we can re-assess.

[trjExpensify]

See ya'll in detention!

[shawnborton]

Hi there, Mr. Borton here, and I like where you all landed. Class dismissed.

[mountiny]

All good to be closed here

[DylanDylann]

@anmurali @mountiny It seems we missed to process payment on this issue

[mountiny]

@DylanDylann, can you please remind for what the payment is? I only see internal PR with internal review

[DylanDylann]

@mountiny Ahh, I noticed these comments. Please help to review again 😄 Sorry If I misunderstand your means

• [Workspace Feeds] [$50] Change Cards & Domains tab to Domains in settings #45021 (comment)
• [Workspace Feeds] [$50] Change Cards & Domains tab to Domains in settings #45021 (comment)

[mountiny]

I think this was one line copy change and there was no pr either. sorry that there was miscommunication about if this should be external or not, but I think we should just move ahead for this one as it was not complex task