[HOLD for payment 2024-08-27] [$250] Clicking on new message doesn't navigate to the last message for 2nd comment link

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.5-2
Reproducible in staging?: y
Reproducible in production?: y
Issue found when executing PR: #41962
Issue reported by: Applause - Internal Team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Start a chat with account B as account A
3. Send 200 messages (Or use this expensifail account [email protected]
   )
4. Copy the link of the 70th comment and send it
5. Copy the link of the 150th comment and send it
6. Go to troubleshoot and clear cache and restart
7. Click on the first link sent on step 4
8. Click on the "New message" badge that appeared at the top of the chat
9. Confirm the page scrolls to the bottom of the comment history
10. Click on the second link sent on step 5.
11. Click on the "New message" badge once again

Expected Result:

The report page scrolls down to the bottom of the comment history

Actual Result:

The report page doesn't scroll down to the bottom of the comment history after clicking on the second link, and this time clicking on the first link and then clicking on the new message badge no longer scrolls to the bottom of the comment history as well.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6535893_1720445935785.bandicam_2024-07-08_16-28-48-145.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0188f7ddb71ba94170
• Upwork Job ID: 1810560415299355486
• Last Price Increase: 2024-07-23
• Automatic offers:
• tsa321 | Contributor | 103330551

Issue Owner

Current Issue Owner: @RachCHopkins

[melvin-bot]

Triggered auto assignment to @RachCHopkins (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[kbecciv]

@RachCHopkins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[RachCHopkins]

Replicated - To be fair my "new message" button didn't take me to the recent message at any point.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0188f7ddb71ba94170

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[nyomanjyotisa]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Clicking on a new message doesn't navigate to the last message for 2nd comment link

What is the root cause of that problem?

We navigate to the report route instead of scrolling to bottom if hasNewestReportAction is false

App/src/pages/home/report/ReportActionsList.tsx

Lines 407 to 412 in dd96852

	const scrollToBottomAndMarkReportAsRead = () => {
	if (!hasNewestReportAction) {
	Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(report.reportID));
	Report.openReport(report.reportID);
	return;
	}

What changes do you think we should make in order to solve the problem?

Scroll to the bottom instead if hasNewestReportAction is false

        if (!hasNewestReportAction) {
            reportScrollManager.scrollToBottom();
        }

RESULT

New-Expensify.7.mp4

What alternative solutions did you explore? (Optional)

Remove the If clause

    const scrollToBottomAndMarkReportAsRead = () => {
        reportScrollManager.scrollToBottom();
        readActionSkipped.current = false;
        Report.readNewestAction(report.reportID);
    };

[nyomanjyotisa]

Proposal updated

[s77rt]

@nyomanjyotisa Your RCA is not correct. Why is hasNewestReportAction false if we have the new message button?

[melvin-bot]

@s77rt, @RachCHopkins Huh... This is 4 days overdue. Who can take care of this?

[s77rt]

Still looking for proposals

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

@s77rt, @RachCHopkins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[s77rt]

Still looking for proposals

[melvin-bot]

@s77rt @RachCHopkins this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[s77rt]

Still looking for proposals

[melvin-bot]

Triggered auto assignment to @francoisl, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @tsa321 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[tsa321]

@s77rt PR is ready

[tsa321]

The PR has been deployed to production since last week.
cc @s77rt @RachCHopkins

[melvin-bot]

This issue has not been updated in over 15 days. @francoisl, @s77rt, @RachCHopkins, @tsa321 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[s77rt]

This is due payment

[RachCHopkins]

@s77rt I think you need to remove the reviewing label to deem it ready for payment.

[RachCHopkins]

Or maybe Melvin was supposed to. All the automation seems to have failed here.

[RachCHopkins]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR:
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@s77rt] Determine if we should create a regression test for this bug.
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@RachCHopkins] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[RachCHopkins]

• @s77rt requires payment via NewDot manual request(Reviewer)
• @tsa321 requires payment automatic offer (Contributor)

[s77rt]

• The PR that introduced the bug has been identified: Blinking on chat switching #39040
• The offending PR has been commented on: Blinking on chat switching #39040 (comment)
• A discussion in #expensify-bugs has been started: Not needed (unique bug)
• Determine if we should create a regression test for this bug: No, this feels low priority, this test should be enough for now https://expensify.testrail.io/index.php?/cases/view/2661784

[RachCHopkins]

Payment Summary:

Contributor: @tsa321 paid $250 via Upwork
Contributor+: @s77rt ready to be paid $250 via newdot manual request

Upwork job here

[RachCHopkins]

Contributor has been paid, the contract has been completed, and the Upwork post has been closed.

[JmillsExpensify]

$250 approved for @s77rt