[HOLD for payment 2024-07-25] Troubleshoot-"Mask fragile user data while exporting Onyx state" toggle is auto-enabled

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

issue found when validating #43552
Version Number: 9.0.4-0
Reproducible in staging?: y
Reproducible in production?: no (This feature is not in production) Not sure it is Blocker
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Login to new Expensify app
2. Navigate to account settings > Troubleshoot
3. Scroll to the "Mask fragile user data while exporting Onyx state" menu and disable the toggle
4. Navigate away from the account settings page
5. Navigate back to settings > Troubleshoot
6. Observe the "Mask fragile user data while exporting Onyx state" toggle

Expected Result:

"Mask fragile user data while exporting Onyx state" toggle remains disabled

Actual Result:

"Mask fragile user data while exporting Onyx state" toggle is auto-enabled after being manually disabled

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6533098_1720097887433.2024-07-04_15_54_05.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @dylanexpensify

[melvin-bot]

Triggered auto assignment to @dylanexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @blimpich (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kavimuru]

@blimpich FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Toggled "Mask fragile user data while exporting Onyx state" doesn't persist

What is the root cause of that problem?

We are saving the toggle state in useState rather than storing the state in Onyx

App/src/pages/settings/Troubleshoot/TroubleshootPage.tsx

Line 55 in 6ac95e4

const [shouldMaskOnyxState, setShouldMaskOnyxState] = useState(true);

What changes do you think we should make in order to solve the problem?

1. Add ONYX key and its type in ONYXKYES.ts here and its type here
   SHOULD_MASK_ONYX_STATE: 'shouldMaskOnyxState'
2. Initialize the added onyx key with true in Onyx.init()here
3. Fetch the onyx value in TroubleShootPage here
4. Pass the fetched data to isOn in Switch component of TroubleShootPage here
5. Create action that will update the onyx state when Switch is toggled
6. Pass the action to onToggle in Switch component of TroubleShootPage here

What alternative solutions did you explore? (Optional)

[etCoderDysto]

Updated my proposal with minor details

[blimpich]

I don't consider this a deploy blocker. Its minor and it relates to a feature that we really only use for debugging purposes, not user functionality. Demoting.

[blimpich]

I don't think we should mark this as external since this relates to #43097. It should just be follow up work for that issue/PR.

[blimpich]

Assigned to @ZhenjaHorbach and @hayata-suenaga as this is follow up for #43097

[ZhenjaHorbach]

@etCoderDysto
Thanks for the proposal !

If we don't mind contributors fixing this issue
Then this proposal makes sense
And I'm happy to go with it

🎀👀🎀 C+ reviewed

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.8-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Persist "Mask fragile user data while exporting Onyx state" switch state #45401

If no regressions arise, payment will be issued on 2024-07-25. 🎊

For reference, here are some details about the assignees on this issue:

• @ZhenjaHorbach requires payment (Needs manual offer from BZ)
• @etCoderDysto requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:
• [@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@dylanexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/415396

[dylanexpensify]

Payment coming up!

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[dylanexpensify]

@Christinadobrzyn I'm heading ooo now until the 5th of August! TY for finishing this off! 🙇‍♂️

[ZhenjaHorbach]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@ZhenjaHorbach] The PR that introduced the bug has been identified. Link to the PR:

This issue is follow up for this

• [@ZhenjaHorbach] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

NA

• [@ZhenjaHorbach] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

NA

• [@ZhenjaHorbach] Determine if we should create a regression test for this bug.
• [@ZhenjaHorbach] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

• Login to new Expensify app
• Navigate to account settings and then to Troubleshoot
• Disable 'Mask fragile user data while exporting Onyx state' switch
• Navigate away from Troubleshoot page
• Navigate back to settings and then to Troubleshoot
• Verify that the switch remains disabled

Do we agree 👍 or 👎

[Christinadobrzyn]

Regression test - https://github.com/Expensify/Expensify/issues/415396

Payouts due:

• Contributor: $250 @etCoderDysto (Upwork offer - https://www.upwork.com/nx/wm/offer/103267669)
• Contributor+: $250 @ZhenjaHorbach (will be paid here [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [Performance] [MEDIUM] Add "Export Onyx state" option to Troubleshoot menu and four finger tap #43097)

@etCoderDysto can you send me your Upwork profile so I can send you an offer?

[Christinadobrzyn]

Thanks @etCoderDysto! Please accept the offer here

[etCoderDysto]

I have accepted the offer. Thank you!

[melvin-bot]

Payment Summary

Upwork Job

• ROLE: @ZhenjaHorbach paid $250 via Upwork - paid through this issue [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [$250] [Performance] [MEDIUM] Add "Export Onyx state" option to Troubleshoot menu and four finger tap #43097
• ROLE: @etCoderDysto paid $250 via Upwork https://www.upwork.com/nx/wm/offer/103267669

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[ZhenjaHorbach]

@Christinadobrzyn
I am not sure if I should get paid for this issue
Since I was a reviewer of the original PR and this issue is follow up for this
So I don't know what to do better 😅

[Christinadobrzyn]

Oh! Thanks for bringing that up @ZhenjaHorbach - let me check with the team in the other GH!

Thanks!

#43097 (comment)

[muttmuure]

@ZhenjaHorbach is being paid here: #43097

[etCoderDysto]

To make things clear, I am not getting paid twice for the offending PR the and fixing PR😁. I was not the author of the offending PR. I only worked on the fixing PR. And I was paid here.

[Christinadobrzyn]

Awesome! I think this can be closed as @etCoderDysto was paid in this issue and @ZhenjaHorbach will be paid in this issue