[PAID] [$250] Profile - Account settings icon shows green dot with no other indication

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.4-0
Reproducible in staging?: y
Reproducible in production?: no
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Complete onboarding (if using public domain).
3. Go to Account settings.

Expected Result:

There should be a notice in the relevant section if the account settings icon has a green dot.

Actual Result:

There is no notice in the relevant section if the account settings icon has a green dot.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6532539_1720046601343.green_dot.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0190b5223d5153c89d
• Upwork Job ID: 1808782166169156269
• Last Price Increase: 2024-07-04
• Automatic offers:
• nkdengineer | Contributor | 102985244

Issue Owner

Current Issue Owner: @strepanier03

[melvin-bot]

Triggered auto assignment to @madmax330 (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@strepanier03 FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[madmax330]

I also see this on my account

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is no notice in the relevant section if the account settings icon has a green dot.

What is the root cause of that problem?

We're using SubscriptionUtils.hasSubscriptionGreenDotInfo to check the infoCheckingMethods

App/src/components/Indicator.tsx

Line 65 in 58be9ba

const infoCheckingMethods: CheckingMethod[] = [() => !!loginList && UserUtils.hasLoginListInfo(loginList), () => SubscriptionUtils.hasSubscriptionGreenDotInfo()];

But this function doesn't work as expected. We use !getSubscriptionStatus()?.isError so this function also returns true if isError is undefined.

App/src/libs/SubscriptionUtils.ts

Line 354 in 58be9ba

return !getSubscriptionStatus()?.isError ?? false;

What changes do you think we should make in order to solve the problem?

We should only return true if the isError is false

return getSubscriptionStatus()?.isError === false; 

App/src/libs/SubscriptionUtils.ts

Line 354 in 58be9ba

return !getSubscriptionStatus()?.isError ?? false;

What alternative solutions did you explore? (Optional)

NA

[madmax330]

Thanks @nkdengineer were you able to find the PR that caused the regression?

[nkdengineer]

@madmax330 This PR #44072 caused the regression.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190b5223d5153c89d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mkhutornyi (External)

[madmax330]

Going to assign @mananjadhav as c+ since they reviewed the offending PR

[mananjadhav]

Pending a CP validation in staging

What does this mean?

[mountiny]

The fix has been cherry-picked to staging, and QA still has to re-test that CPed PR in staging to verify this issue if it is gone. Removing the blocker label because on the deploy checklist, the CPed PR has an unchecked box until QA verifies it was fixed

[mananjadhav]

Okay thanks for clarifying!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix the check for subscription green dot info #44862

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] fix the check for subscription green dot info #44862

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

@nkdengineer - I've paid and closed the contract in Upwork.

@mananjadhav - I'll check tomorrow for the checklist items above and once that's complete I'll post the payment summary so you can request payment.

[mananjadhav]

@strepanier03 No payout for me here.

[strepanier03]

Okay, thanks for the heads up @mananjadhav 🙌.

Can you finish up the checklist items so I can make a reg test if needed and close this out?

[melvin-bot]

@mananjadhav, @madmax330, @strepanier03, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mananjadhav]

@strepanier03 I don't think we need a regression test for this one. The offending PR was already tagged and I posted a comment here

@madmax330 This PR #44072 caused the regression.

[melvin-bot]

@mananjadhav, @madmax330, @strepanier03, @nkdengineer Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Thanks for confirming @mananjadhav. Since I paid the other contract I'm closing this out. Thanks again everyone 🙌