Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Payment card / Subscription] Integrate failed billing scenarios banner with backend data #42431

Closed
amyevans opened this issue May 21, 2024 · 34 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.

Comments

@amyevans
Copy link
Contributor

amyevans commented May 21, 2024

Design doc

Issue OwnerCurrent Issue Owner: @miljakljajic
@amyevans amyevans moved this to Release 1.5: XeroCon 2024 (June 12th) in [#whatsnext] #wave-collect May 21, 2024
@pasyukevich
Copy link
Contributor

Hi, I'm Eugene from Callstack - expert agency - and I would like to work on this issue.

@amyevans
Copy link
Contributor Author

Not overdue

@pasyukevich
Copy link
Contributor

Today's updates - WIP, implementing utils file to handle all predefined error cases

@melvin-bot melvin-bot bot removed the Overdue label Jun 10, 2024
@pasyukevich
Copy link
Contributor

Today's updates - WIP, implementing utils file to handle all predefined error cases

@pasyukevich
Copy link
Contributor

Today's updates - WIP, still implementing utils file to handle all predefined error cases

@amyevans
Copy link
Contributor Author

Just cross-posting from here so that the message does not get lost: let's ensure to include the RBR implementation for when switching between plans is disallowed (failed UpdateSubscriptionType API command) in this PR

@pasyukevich
Copy link
Contributor

Today's updates - WIP, Utils file is mostly done, remained - to glue logic with buttons, add error cases from failed API commands

@pasyukevich
Copy link
Contributor

For the next two weeks I will be OOO, on Monday will be decided who will continue to work on this task

@amyevans amyevans assigned blimpich and unassigned amyevans Jun 14, 2024
@amyevans
Copy link
Contributor Author

Reassigning to @blimpich since I'm headed out on extended leave after today

@trjExpensify trjExpensify moved this from Release 1.5: XeroCon 2024 (June 12th) to Release 2: Summer 2024 (Aug) in [#whatsnext] #wave-collect Jun 18, 2024
@JKobrynski
Copy link
Contributor

Hi, I'm Julian from Callstack - expert agency - and I would like to work on this issue.

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production labels Jul 10, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Integrate failed billing scenarios banner with backend data [HOLD for payment 2024-07-17] [Payment card / Subscription] Integrate failed billing scenarios banner with backend data Jul 10, 2024
Copy link

melvin-bot bot commented Jul 10, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.5-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-17. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 10, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@miljakljajic
Copy link
Contributor

We pay you in ND right @mananjadhav ? So just a payment summary be due for this one on the 17th?

@mananjadhav
Copy link
Collaborator

Yes @miljakljajic that's right.

@miljakljajic
Copy link
Contributor

Thank you!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Jul 12, 2024
@miljakljajic
Copy link
Contributor

I'm going to submit the payment summary today as I'm OOO tomorrow - please don't request payment until tomorrow:

@mananjadhav is owed 250 USD for their work reviewing this issue

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jul 15, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-07-17] [Payment card / Subscription] Integrate failed billing scenarios banner with backend data [HOLD for payment 2024-07-22] [HOLD for payment 2024-07-17] [Payment card / Subscription] Integrate failed billing scenarios banner with backend data Jul 15, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jul 15, 2024
Copy link

melvin-bot bot commented Jul 15, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jul 15, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.6-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-07-22. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jul 15, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@mananjadhav] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@miljakljajic] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jul 16, 2024
@mananjadhav
Copy link
Collaborator

This is supposed to be paid out today, hence I am going to request based on this comment.

@melvin-bot melvin-bot bot added the Overdue label Jul 18, 2024
@JmillsExpensify
Copy link

$250 approved for @mananjadhav

Copy link

melvin-bot bot commented Jul 22, 2024

Payment Summary

Upwork Job

  • Reviewer: @mananjadhav owed $250 via NewDot
  • Contributor: @JKobrynski is from an agency-contributor and not due payment

BugZero Checklist (@miljakljajic)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@mananjadhav
Copy link
Collaborator

mananjadhav commented Jul 22, 2024

This is already paid out, should be closed and I am not sure why this has an Overdue tag.

@trjExpensify
Copy link
Contributor

I'll go ahead and close it. Regression tests should be handled centrally for the project.

@melvin-bot melvin-bot bot removed the Overdue label Jul 22, 2024
@github-project-automation github-project-automation bot moved this from Release 2: Summer 2024 (Aug) to Done in [#whatsnext] #wave-collect Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

10 participants