[HOLD for payment 2024-07-10] [$250] Subscription - "common.error.pleaseCompleteForm" is shown when submitting empty survey

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.86-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #43367
Issue reported by: Applause - Internal team

Action Performed:

1. Log in to ND with Gmail account.
2. Go to staging.new.expensify.com/settings/subscription
3. Disable auto-renew toggle.
4. Click Submit without selecting anything.

Expected Result:

Proper error message will be displayed.

Actual Result:

"common.error.pleaseCompleteForm" is shown.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6519286_1718879890831.20240620_123641.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c24a0e46790d2f26
• Upwork Job ID: 1803808097528280767
• Last Price Increase: 2024-06-20
• Automatic offers:
• alitoshmatov | Reviewer | 102813104
• neonbhai | Contributor | 102813106

Issue Owner

Current Issue Owner: @MitchExpensify

[melvin-bot]

Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #wave-collect - Release 2

[neonbhai]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Subscription - "common.error.pleaseCompleteForm" is shown when submitting empty survey

What is the root cause of that problem?

We don't use translate to pass the correct message here:

App/src/components/FeedbackSurvey.tsx

Line 95 in 57663ed

message="common.error.pleaseCompleteForm"

Hence just the string is rendered

What changes do you think we should make in order to solve the problem?

We will use the translate hook to refer to the correct message here:

App/src/components/FeedbackSurvey.tsx

Line 95 in 57663ed

message="common.error.pleaseCompleteForm"

[etCoderDysto]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"common.error.pleaseCompleteForm" is shown as an error message

What is the root cause of that problem?

In FeedBackSurvey component we are passing 'common.error.pleaseCompleteForm' key as a value to message prop instead of calling translate method with the key to fetch the error message from en.ts and es.ts.

App/src/components/FeedbackSurvey.tsx

Lines 92 to 95 in 6dc6f81

	<FormAlertWithSubmitButton
	isAlertVisible={shouldShowReasonError}
	onSubmit={handleSubmit}
	message="common.error.pleaseCompleteForm"

What changes do you think we should make in order to solve the problem?

Pass translate('common.error.pleaseCompleteForm') to message prop here

What alternative solutions did you explore? (Optional)

[carlosmiceli]

Can't reproduce in prod, but it seems to be a new feature to show subscription inside ND.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c24a0e46790d2f26

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[cretadn22]

Proposal

Please re-state the problem that we are trying to solve in this issue.

"common.error.pleaseCompleteForm" is shown when submitting empty survey

What is the root cause of that problem?

App/src/components/FeedbackSurvey.tsx

Line 95 in f618a94

message="common.error.pleaseCompleteForm"

We don't use translate function

What changes do you think we should make in order to solve the problem?

We need to update to

                    message={translate('common.error.pleaseCompleteForm')}

After applying the above change, I see that we have a minor error in Spanish message (there are two dot in the end of message)

We also need to remove one dot in the end of error message to display the correct error like in English translation

App/src/languages/es.ts

Line 237 in f618a94

pleaseCompleteForm: 'Por favor complete el formulario de arriba para continuar..',

What alternative solutions did you explore? (Optional)

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @neonbhai 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[cretadn22]

@carlosmiceli I believe there's also an issue with the Spanish message that needs to be corrected, as outlined in my proposal.

[melvin-bot]

Triggered auto assignment to @MitchExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[mallenexpensify]

No BZ on here so I added one. (then realized I should have just assigned myself before adding the label).

If there's a minor improvement that @cretadn22 suggests that @neonbhai can add to the PR, please do so and we can compensate @cretadn22 $50 for the help. (we don't have a documented process for this because it's an edge case).

[melvin-bot]

@carlosmiceli, @MitchExpensify, @alitoshmatov, @neonbhai Whoops! This issue is 2 days overdue. Let's get this updated quick!

[neonbhai]

PR deployed to staging 3 days ago, not overdue

[melvin-bot]

@carlosmiceli, @MitchExpensify, @alitoshmatov, @neonbhai Still overdue 6 days?! Let's take care of this!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 9.0.3-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: "common.error.pleaseCompleteForm" is shown when submitting empty survey  #44104

If no regressions arise, payment will be issued on 2024-07-10. 🎊

For reference, here are some details about the assignees on this issue:

• @alitoshmatov requires payment automatic offer (Reviewer)
• @neonbhai requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@alitoshmatov] The PR that introduced the bug has been identified. Link to the PR:
• [@alitoshmatov] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@alitoshmatov] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@alitoshmatov] Determine if we should create a regression test for this bug.
• [@alitoshmatov] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@MitchExpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[MitchExpensify]

Payment summary:

• $250 @alitoshmatov requires payment automatic offer (Reviewer)
• $250 @neonbhai requires payment automatic offer (Contributor)
• $50 @cretadn22 Assistance

[cretadn22]

@MitchExpensify Should I get 50$ as mentioned here

[MitchExpensify]

Updated, thanks @cretadn22 !

[alitoshmatov]

• The PR that introduced the bug has been identified. Link to the PR: feat: Subscription settings UI #42990
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/42990/files#r1667441580
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: No need
• Determine if we should create a regression test for this bug: No need since it is about hardcoded error message which is easily noticeable

[MitchExpensify]

Paid and contracts ended