-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD #21219][$250] Android - Group - Inconsistency in showing group name in header in mweb & Android #43068
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @deetergp ( |
We think that this bug might be related to #vip-vsb |
I agree that this should be consistent between mWeb & native in Android, but I also don't think it's serious enough to block the deploy. |
ProposalPlease re-state the problem that we are trying to solve in this issue.Inconsistency in showing group name in header in mweb and Android What is the root cause of that problem?We do not explicit the width for display name, so it's cut off What changes do you think we should make in order to solve the problem?We should add https://github.com/Expensify/App/blob/main/src/components/DisplayNames/index.native.tsx What alternative solutions did you explore? (Optional)
Result |
Job added to Upwork: https://www.upwork.com/jobs/~01d5db97bd918f3107 |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt ( |
@tienifr Thanks for the proposal. We don't need to set an explicit width to the container but making it flexible (grow to fit) makes sense. However your solution causes a regression where the caret is also moved |
@s77rt ah i see, we can fix it with justify-content. |
@tienifr Can you elaborate on where this style should be applied? After making the text flexible (grow) the justify content styling on the container won't have any effect |
@s77rt I can't find the better solution. Can we approve the movement of the caret? |
@tienifr I believe that's an unwanted change. |
@s77rt I updated my proposal #43068 (comment), pls help check again. Thanks. |
@tienifr That solution didn't fix the problem for me. It seems that it helps in some cases but not all, e.g. try with |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
I'm not sure about this because there is already issues for this opened in react native from a long time and there is no solution yet. Similar issue that we should handle here |
@Krishna2323 Do you have some links to those issues and/or a reproducible example? We should push to fix this upstream |
@s77rt facebook/react-native#15114, there is no ideal solution for this, there are only workarounds like setting |
@Krishna2323 This PR facebook/react-native#41770 seems promising and it could fix this bug too |
@s77rt, yes, seems like it could fix this issue but I'm not sure if that will be merged anytime soon. What should we do here then? There is one more issue opened here. |
I think this kind of issue is being tracked here #21219 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
Issue not reproducible during KI retests. (Second week) |
To be held on #21219 |
📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸 |
@deetergp Let's put this on hold #43068 (comment) |
Still on hold so making this weekly for now. |
Issue not reproducible during KI retests. (Third week) |
If it hasn't been reproducible for the last three weeks, I think we can close it. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.79
Reproducible in staging?: y
Reproducible in production?: new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4593905
Issue reported by: Applause - Internal Team
Action Performed:
Expected Result:
There should be no Inconsistency in showing group name in header in mweb and Android
Actual Result:
Inconsistency in showing group name in header in mweb and Android
Workaround:
n/a
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6502054_1717532864635.group.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @s77rtThe text was updated successfully, but these errors were encountered: