[$250] Android-Room-After creating room, entering @ not showing contact suggestions

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.77-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4585586
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Launch app
2. Tap fab -- start chat
3. Create a new room
4. Enter @ and wait few seconds
5. Navigate to LHN
6. Navigate to room again
7. Keep cursor after @

Expected Result:

After creating room, entering @ must show contact suggestions

Actual Result:

After creating room, entering @ not showing contact suggestions but shown on revisit.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6495138_1716990722444.Screenrecorder-2024-05-29-19-16-06-795_compress_1.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016d65d15eadf82bb4
• Upwork Job ID: 1795831001903484928
• Last Price Increase: 2024-05-29
• Automatic offers:
• alitoshmatov | Reviewer | 102529959
• ishpaul777 | Contributor | 102529960

Issue Owner

Current Issue Owner: @jliexpensify

[melvin-bot]

Triggered auto assignment to @bondydaa (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @jliexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@bondydaa FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #vip-vsb

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016d65d15eadf82bb4

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[bondydaa]

hmm the site has been pretty slow most of the day, if this relies on a network request that could explain it. or is it pretty consistent that first time @ is type nothing is triggered?

[bondydaa]

hmm okay was able to reproduce on android only. it doesn't look like you have to create a new room. i'm able to consistently reproduce by just going into any existing room and trying typing @. if i leave and go back into the same room then @ triggers the list of members to show up.

[bondydaa]

i think the code for this is roughly these components

App/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx

Line 433 in 1490cec

<ComposerWithSuggestions

https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionCompose/SuggestionMention.tsx
https://github.com/Expensify/App/blob/main/src/pages/home/report/ReportActionCompose/Suggestions.tsx

I don't really see any recent changes in those files though.

There are these 2 PRs that had changes to the ReportActionCompose.tsx component but neither stand out to me as the root cause

#42180
#42615

[ishpaul777]

👋

[melvin-bot]

@bondydaa, @jliexpensify, @ishpaul777 Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[jliexpensify]

Hmm not overdue, right? Waiting for it to be deployed?

[tomekzaw]

There were no Android-specific changes between [email protected] and 0.1.76 so I have no idea what could have caused this regression.

edit: I've bumped Live Markdown to 0.1.76 and I cannot reproduce the original problem with suggestion box, it works for me.

[fabOnReact]

I quote Skalakid comment.

After a quick investigation I found out that the live markdown parser is using a different commit of expensify-common than E/App. Live Markdown parser uses a newer version of ExpeniMark that contains changes that block blockquote creation without space after

I will create PR that bumps the version in the Expensify App
I pulled the latest main and E/App has a newer version of expensify-common than live markdown. I can't reproduce this issue now

57d8b2b

Maybe with the latest version of expensify-common and react-native-live-markdown the issue will not reproduce anymore. I will verify this on Monday (unluckily now I have other commitments). Thanks

[melvin-bot]

@bondydaa, @jliexpensify, @ishpaul777 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[bondydaa]

Thanks @tomekzaw and @fabOnReact let me know if you need anything from me.

[fabOnReact]

I tested and I can not reproduce this issue anymore.

CLICK TO OPEN TESTS RESULTS

Screen.Recording.2024-06-11.at.11.59.08.AM.mov

CLICK TO OPEN TESTS RESULTS

[ishpaul777]

@jliexpensify Can we release bounty for the issue please

[melvin-bot]

@bondydaa, @jliexpensify, @ishpaul777 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[jliexpensify]

There wasn't an actual regression here right? Also, what's the original PR? Melvin hasn't updated the date so just want to check everything has been deployed.

[melvin-bot]

@bondydaa @jliexpensify @ishpaul777 this issue was created 2 weeks ago. Are we close to approving a proposal? If not, what's blocking us from getting this issue assigned? Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[jliexpensify]

PR - #42843

Will pay out today, confirmed with Bondy no checklist needed. Payment summary.

[jliexpensify]

Paid and job closed.