[PAID] [$250] Tags - The text content for the tag settings didn't update to "expenses"

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.74-0
Reproducible in staging?: Y
Reproducible in production?: Y
Found when executing PR : #40950
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-internal team

Action Performed:

1. Navigate to staging.new.expensify.com
2. Create a workspace
3. Enable tags in more features settings of that workspace
4. Navigate to tags > open settings RHP

Expected Result:

The text content for "spend" should be updated to "expenses"

Actual Result:

The text content for "spend" didn't update to "expenses"

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0119b30dfee00c07e8
• Upwork Job ID: 1793038382904958976
• Last Price Increase: 2024-05-21

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[izarutskaya]

We think this issue might be related to the #collect project.

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tags - The text content for the tag settings didn't update to "expenses"

What is the root cause of that problem?

The translation is wrong.

App/src/languages/en.ts

Line 2193 in 1faad15

requiresTag: 'Members must tag all spend',

App/src/languages/en.ts

Lines 716 to 717 in e8ae3c5

	tagSelection: 'Select a tag to better organize your spend.',
	categorySelection: 'Select a category to better organize your spend.',

App/src/languages/en.ts

Line 2134 in e8ae3c5

subtitle: 'Add a category to organize your spend.',

What changes do you think we should make in order to solve the problem?

We should change it to expenses in en.ts and es.ts file.

What alternative solutions did you explore? (Optional)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We are using wrong word

App/src/languages/en.ts

Line 2193 in 1faad15

requiresTag: 'Members must tag all spend',

What changes do you think we should make in order to solve the problem?

This bug only happen with English translation, we don't need to fix in Spanish translation

App/src/languages/en.ts

Line 2193 in 1faad15

requiresTag: 'Members must tag all spend',

requiresTag: 'Members must tag all expenses', 

We also should to fix the same bug in here

App/docs/articles/new-expensify/workspaces/Require-tags-and-categories-for-expenses.md

Line 17 in e8ae3c5

6. Enable the “Members must tag/categorize all spend” toggle.

App/docs/articles/new-expensify/workspaces/Require-tags-and-categories-for-expenses.md

Line 27 in e8ae3c5

6. Enable the “Members must tag/categorize all spend” toggle.

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[melvin-bot]

@strepanier03 Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0119b30dfee00c07e8

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[strepanier03]

Able to repro so I tied it to a project and set external.

[aimane-chnaif]

As the solution is straightforward, I'd like to go with @nkdengineer's proposal since it covers all instances.
🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @nkuoch, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[Krishna2323]

@aimane-chnaif, there are few more translations that should also be changed to expenses. There are more in the translation files that we might want to update but these are on categories/tags page.

App/src/languages/en.ts

Lines 716 to 717 in e8ae3c5

	tagSelection: 'Select a tag to better organize your spend.',
	categorySelection: 'Select a category to better organize your spend.',

App/src/languages/en.ts

Line 2134 in e8ae3c5

subtitle: 'Add a category to organize your spend.',

[aimane-chnaif]

I don't think we should replace all occurrences of "spend" with "expenses".
@hayata-suenaga can you please confirm ^

[hayata-suenaga]

I don't think we should replace all occurrences of "spend" with "expenses".

I feel like we made a move to change all wording of spend to expenses throughout New Expensify, @trjExpensify?
Should we update the remaining texts, too?

[hayata-suenaga]

I'll handle this PR as this is the regression from my App PR 🙇

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.77-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update UI text #42495

If no regressions arise, payment will be issued on 2024-06-06. 🎊

For reference, here are some details about the assignees on this issue:

• @aimane-chnaif requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@aimane-chnaif] The PR that introduced the bug has been identified. Link to the PR:
• [@aimane-chnaif] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@aimane-chnaif] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@aimane-chnaif] Determine if we should create a regression test for this bug.
• [@aimane-chnaif] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @aimane-chnaif owed $250 via NewDot

BugZero Checklist (@strepanier03)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1793038382904958976/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[aimane-chnaif]

This was not regression but minor copy update. I don't think this requires regression test.

[melvin-bot]

@strepanier03, @aimane-chnaif, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

[strepanier03]

Payment Summary

• $250 @aimane-chnaif via Manual Request

@JmillsExpensify - Request incoming.

[melvin-bot]

@JmillsExpensify, @strepanier03, @aimane-chnaif, @hayata-suenaga Huh... This is 4 days overdue. Who can take care of this?

[hayata-suenaga]

just waiting for payment

[strepanier03]

Can close once payment is requested.

[strepanier03]

@aimane-chnaif - Just checking in, did you request payment for this? Can I close this out yet?

[melvin-bot]

@JmillsExpensify, @strepanier03, @aimane-chnaif, @hayata-suenaga Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[aimane-chnaif]

yet using upwork

[strepanier03]

@aimane-chnaif - You requested via Upwork? My records show you're using Manual Requests, which is maybe what I think you meant right?

Reopen this if that's incorrect and you want me to make you an Upwork job.

[aimane-chnaif]

@strepanier03 I am still using upwork. Can you please reopen and sort payment? Thanks

[strepanier03]

offer - https://www.upwork.com/nx/wm/offer/104669319

[strepanier03]

PAID!