[HOLD for payment 2024-06-28] [$250] [Search v1] Live search updates

[luacmartins]

Section from design doc - https://docs.google.com/document/d/1ldZ85fyQO4662hLZRNFfm0_IxaP7-PWvaqc8Z33jsLQ/edit#bookmark=kix.79jwwhj0fjyz

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d2ae989d15bcd2d3
• Upwork Job ID: 1790718970882084864
• Last Price Increase: 2024-05-15
• Automatic offers:
• rayane-djouah | Reviewer | 0

Issue Owner

Current Issue Owner: @allroundexperts

[melvin-bot]

@luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@luacmartins Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[luacmartins]

Taking off hold, we'll start implementation shortly.

[Kicu]

@luacmartins
I looked at this issue and it feels like we need some working api in order to start working on it? Any ETA on when backend changes will be done, or can we perhaps work on this already?

[luacmartins]

No API needed for this one. We only need to update Onyx so that any incoming update is processed in a way that it also updates the data in the snapshot_ key.

[luacmartins]

@Kicu I assigned you to this issue. Let me know if you can't work on it.

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[Kicu]

Will work on it 👍

[Kicu]

@luacmartins do you mind checking my comment here? https://docs.google.com/document/d/1ldZ85fyQO4662hLZRNFfm0_IxaP7-PWvaqc8Z33jsLQ/edit?disco=AAABJtWc-70

[melvin-bot]

@Kicu, @luacmartins, @Christinadobrzyn Whoops! This issue is 2 days overdue. Let's get this updated quick!

[Christinadobrzyn]

looks like @luacmartins and @Kicu are working through the comments in the design doc

[jnowakow]

@luacmartins PR is ready.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.85-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update Onyx to 2.0.49 #43764

If no regressions arise, payment will be issued on 2024-06-28. 🎊

For reference, here are some details about the assignees on this issue:

• @allroundexperts requires payment through NewDot Manual Requests
• @jnowakow does not require payment (Contractor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Payment Summary

Upwork Job

• Reviewer: @allroundexperts owed $250 via NewDot
• Contributor: @jnowakow is from an agency-contributor and not due payment

BugZero Checklist (@Christinadobrzyn)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1790718970882084864/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[Christinadobrzyn]

Hum... the upwork contract has an offer sent to @rayane-djouah

Are we paying out anyone other than @allroundexperts and @jnowakow for this?

[jnowakow]

@Christinadobrzyn I'm from SoftwareMansion, an expert agency, so I'm not receiving direct payments 😅

[Christinadobrzyn]

Thanks @jnowakow!

This explains why we sent an offer to @rayane-djouah so I'm going to withdraw that offer.

Payment summary here - #41626 (comment)

@allroundexperts can you let me know about a regression test?

[Christinadobrzyn]

moving this to weekly since all we're waiting on is a regression test, if applicable.

[luacmartins]

No regression tests needed. We'll add them as part of the project wrap up. We can close this then. Thanks everyone!

[JmillsExpensify]

$250 approved for @allroundexperts