[HOLD for payment 2024-05-09] [HOLD for payment 2024-05-08] [$250] Troubleshoot - App crashes when clicking Reset and refresh after inviting user to the room

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.68-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Create a room
3. Invite a member to the room
4. Go to Account settings > Troubleshoot
5. Click Clear cache and restart
6. Click Reset and refresh

Expected Result:

App does not crash

Actual Result:

App crashes

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6466066_1714436350800.crash_invite.mp4

logs.txt

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01a66317be07c94f84
• Upwork Job ID: 1785195026765955072
• Last Price Increase: 2024-04-30
• Automatic offers:
• alitoshmatov | Reviewer | 0
• suneox | Contributor | 0

[melvin-bot]

Triggered auto assignment to @robertjchen (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[lanitochka17]

@robertjchen FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[suneox]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Troubleshoot - App crashes when clicking Reset and refresh after inviting user to the room due to we have missing condition check

What is the root cause of that problem?

After clear cache the personalDetails also clear, but we don't check personalDetails at this line before using it

What changes do you think we should make in order to solve the problem?

We will add condition check personalDetails before using it the same solution with this line

    useEffect(() => {
        // there is no need to update the options if the options are not initialized
+       if (!areOptionsInitialized.current || !personalDetails) {
            return;
        }

        const newReportOptions: Array<{
            replaceIndex: number;
            newReportOption: OptionsListUtils.SearchOption<Report>;
        }> = [];

        Object.keys(personalDetails).forEach((accoutID) => {
        ....

Option 2: we can make the default value is empty object for usePersonalDetails same with this line or set default value is empty object for PERSONAL_DETAILS_LIST after clear cache same solution with this

What alternative solutions did you explore? (Optional)

We can add ONYXKEYS.PERSONAL_DETAILS_LIST into KEYS_TO_PRESERVE

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01a66317be07c94f84

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @alitoshmatov (External)

[ghost]

I think this is the regression caused by this PR - #39230

[francoisl]

@robertjchen @alitoshmatov did you get a chance to look into this one?

cc @tienifr as well in case it's coming from #39230

[suneox]

I think this is the regression caused by this PR - #39230

This isn't a regression from #39230 the logic migration still keeps the same before migrate page

      Onyx.clear(App.KEYS_TO_PRESERVE).then(() => {
          App.openApp();
      });

The new logic uses personalDetails raise crash comes from this PR

[francoisl]

Ah ok, makes more sense. Let's go with your proposal then @suneox. Can you double-check if we also need to make the same change in this other effect, it also uses personalDetails.

[melvin-bot]

📣 @alitoshmatov 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[suneox]

Ah ok, makes more sense. Let's go with your proposal then @suneox. Can you double-check if we also need to make the same change in this other effect, it also uses personalDetails.

Sure I'll check another places and update in PR

[suneox]

The PR is ready for review

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.68-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Use default value for personalDetails in OptionListContextProvider #41363

If no regressions arise, payment will be issued on 2024-05-08. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Contributor)
• @alitoshmatov requires payment automatic offer (Reviewer)

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Use default value for personalDetails in OptionListContextProvider #41363

If no regressions arise, payment will be issued on 2024-05-09. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Contributor)
• @alitoshmatov requires payment automatic offer (Reviewer)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @sonialiap you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[sonialiap]

Payment summary

• @suneox requires contributor $250 - paid ✔️
• @alitoshmatov reviewer $250 - offer pending ⏳ offer withdrawn due to Ali saying that he didn't participate in the review

[alitoshmatov]

@sonialiap I was not involved in reviewing. So no payment needed for me

[sonialiap]

Thanks for letting me know