[HOLD for payment 2024-05-09] CRITICAL [Invoice Rooms]: Update invoice rooms to use correct avatars

[danielrvidal]

As highlighted on this issue, we need to update the invoice rooms to use the correct Avatars.

@shawnborton highlighted the intent well in the above and I've included the direction below. But pretty much they should mirror how workspace chats work. For the large avatar, we should use the senders workspace avatar. Then, if the invoice room is shared with another workspace, we'd use that workspace avatar for the smaller avatar. If the invoice room is shared with an individual, it would show the individuals avatar. Examples below.

Workspace to Workspace:

Workspace to Individual:

cc @cristipaval can you work with the team to make sure this gets picked up?

Issue Owner

Current Issue Owner: @isabelastisser

[VickyStash]

Hi, I'm Viktoryia from Callstack - expert contributor group - and I would like to work on this issue.
cc @cristipaval

[VickyStash]

The PR has been opened - #41316

[VickyStash]

NOTE: I'll be OOO 1-8th of May 🌴

[cristipaval]

PR has been merged

[danielrvidal]

Yup, I tested this one and it looks good!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.69-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update invoice rooms to use correct avatars and show correct threads subtitles #41316

If no regressions arise, payment will be issued on 2024-05-09. 🎊

For reference, here are some details about the assignees on this issue:

• @VickyStash does not require payment (Contractor)
• @rushatgabhane requires payment through NewDot Manual Requests

[rushatgabhane]

@cristipaval could you please attach payment summary for this issue

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[cristipaval]

@isabelastisser Please help with the payment when gets due. It is due as of today

Payment summary:

@rushatgabhane for the C+ review

Note: This is not a regression. I merged the offending PR even if the design's approval was not final. We wanted to move fast and we agreed on follow-up PRs if the design requested changes

[isabelastisser]

@rushatgabhane, can you confirm that your payment needs to be processed via NewDot?

[isabelastisser]

Missed this:

@rushatgabhane requires payment through NewDot Manual Requests

Payment summary:

@rushatgabhane for the C+ review $500.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @VickyStash is from an agency-contributor and not due payment
• Reviewer: @rushatgabhane owed $250 via NewDot

BugZero Checklist (@isabelastisser)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[JmillsExpensify]

$250 approved for @rushatgabhane

[JmillsExpensify]

Ah actually, @rushatgabhane is requesting $500 and that seems correct given that this is a CRITICAL issue. @isabelastisser can you please update the payment summary with that in mind?

[isabelastisser]

@JmillsExpensify, yes. I have already highlighted it above: #41261 (comment)

Payment summary:

Contributor: @VickyStash is from an agency-contributor and not due payment
Reviewer: @rushatgabhane owed $500 via NewDot

[isabelastisser]

Bump @JmillsExpensify

[JmillsExpensify]

$500 approved for @rushatgabhane