[HOLD for payment 2024-06-13] [$500] Workspace - Not here page is briefly displayed when selecting a workspace

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.66-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause - Internal Team

Action Performed:

1. Sing up with a GMAIL new account
2. Create manual expense in Self DM
3. Create workspace
4. Navigate to the self DM
5. Click on 'Catgorize it' under the new expense
6. Select the new workspace

Expected Result:

Hmm its not here page shouldn't be displayed momentarily

Actual Result:

Hmmm it is not here page is displayed momentarily

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6461762_1714060426499.Screen_Recording_2024-04-25_at_6.51.36_in_the_evening.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b67f88414b7c0b94
• Upwork Job ID: 1783871746486759424
• Last Price Increase: 2024-06-18
• Automatic offers:
• ZhenjaHorbach | Contributor | 0

Issue Owner

Current Issue Owner: @mananjadhav

[melvin-bot]

Triggered auto assignment to @sonialiap (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[lanitochka17]

@sonialiap FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[ZhenjaHorbach]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Not here page is briefly displayed when selecting a workspace

What is the root cause of that problem?

The main problem with issue is that when we create workspace and then navigate to IOURequestStepCategory we need to wait when we get response from BE and only then we will get current categories using another request

App/src/libs/actions/Policy.ts

Lines 2566 to 2570 in 34434a5

	function openDraftWorkspaceRequest(policyID: string) {
	const params: OpenDraftWorkspaceRequestParams = {policyID};
	API.read(READ_COMMANDS.OPEN_DRAFT_WORKSPACE_REQUEST, params);
	}

What changes do you think we should make in order to solve the problem?

To fix this issue we can update IOURequestStepCategory and add Loader

App/src/pages/iou/request/step/IOURequestStepCategory.tsx

Lines 131 to 148 in 34434a5

	return (
	<StepScreenWrapper
	headerTitle={translate('common.category')}
	onBackButtonPress={navigateBack}
	shouldShowWrapper
	shouldShowNotFoundPage={shouldShowNotFoundPage}
	testID={IOURequestStepCategory.displayName}
	includeSafeAreaPaddingBottom={false}
	>
	<Text style={[styles.ph5, styles.pv3]}>{translate('iou.categorySelection')}</Text>
	<CategoryPicker
	selectedCategory={transactionCategory}
	policyID={report?.policyID ?? ''}
	onSubmit={updateCategory}
	/>
	</StepScreenWrapper>
	);
	}

For condition we can use similar logic from WorkspaceCategoriesPage (actually we have bug here and we need use null instead undefined because for this screen we are using useOnyx which return null instead undefined in case if we don't have value in Onyx ) (Alternatively we can add isLoading to Onyx as in my alternative proposition to make the behavior on these two screens the same )

const isLoading = !isOffline && policyCategories === undefined;

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 247 in 34434a5

const isLoading = !isOffline && policyCategories === undefined;

Also we can add similar component from 'WorkspaceCategoriesPage' for empty list of elements

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 305 to 311 in 34434a5

	{shouldShowEmptyState && (
	<WorkspaceEmptyStateSection
	title={translate('workspace.categories.emptyCategories.title')}
	icon={Illustrations.EmptyStateExpenses}
	subtitle={translate('workspace.categories.emptyCategories.subtitle')}
	/>
	)}

Using similar condition

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 249 in 34434a5

const shouldShowEmptyState = !categoryList.some((category) => category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) && !isLoading;

OR just update text for not found component (But it depends on the design team)

What alternative solutions did you explore? (Optional)

As alternative we can add isLoader inside Onyx
And when we make a request we will use this value until we receive a response from the backend

App/src/libs/actions/Policy.ts

Lines 2566 to 2570 in 34434a5

	function openDraftWorkspaceRequest(policyID: string) {
	const params: OpenDraftWorkspaceRequestParams = {policyID};
	API.read(READ_COMMANDS.OPEN_DRAFT_WORKSPACE_REQUEST, params);
	}

We do something similar for openPolicyWorkflowsPage

App/src/libs/actions/Policy.ts

Line 2425 in 10fc359

function openPolicyWorkflowsPage(policyID: string) {

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b67f88414b7c0b94

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[sonialiap]

A polish issue that imo isn't super high value but since we already have a proposal, passing to external

[mananjadhav]

I think @ZhenjaHorbach's proposal looks good.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[melvin-bot]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ZhenjaHorbach]

📣 @ZhenjaHorbach 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

PR will be ready within a few days

[melvin-bot]

This issue has not been updated in over 15 days. @mananjadhav, @Beamanator, @sonialiap, @ZhenjaHorbach eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[mananjadhav]

PR is ready but being blocked by merge freeze. @Beamanator do you know where we can get this merged?

[Beamanator]

Yes we should be able to get this merged soon! probably in the next few days 🙏

[mananjadhav]

I've done the latest retest. Hopefully we should get this merged on Monday.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.79-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Update RequestStepCategory to add Empty and Loading states for category list #41344

If no regressions arise, payment will be issued on 2024-06-13. 🎊

For reference, here are some details about the assignees on this issue:

• @mananjadhav requires payment through NewDot Manual Requests
• @ZhenjaHorbach requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@sonialiap] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[mananjadhav]

@Beamanator @sonialiap I would want to request to raise the payout for this one. It wasn't a simple bug fix. We ended up adding a new route, and did fix two issues in one PR. The scope of the implementation was a bit bigger than I anticipated.

@ZhenjaHorbach can chime in too if they agree/disagree.

[ZhenjaHorbach]

@Beamanator @sonialiap I would want to request to raise the payout for this one. It wasn't a simple bug fix. We ended up adding a new route, and did fix two issues in one PR. The scope of the implementation was a bit bigger than I anticipated.

@ZhenjaHorbach can chime in too if they agree/disagree.

Actually good point

Technically, we made 2 completely different tasks (Added loading state and added empty list state (As part of this task, we added new routes and made many changes that I didn't expect either 😅) for RequestStepCategory)

So I agree with @mananjadhav 👍

[sonialiap]

@Beamanator I think you probably have a better grasp on the engineering work that went into this. Do you agree with a price increase?

[Beamanator]

I agree that a bump to $500 sounds fair 👍 Personally, I wouldn't think it needs more than that though - the PR isn't really huge and not overly complicated. Thoughts?

[ZhenjaHorbach]

I agree that a bump to $500 sounds fair 👍 Personally, I wouldn't think it needs more than that though - the PR isn't really huge and not overly complicated. Thoughts?

I agree with that !

[sonialiap]

Cool, updating payments

Payment summary:

• @mananjadhav $500 - please request in ND and complete the checklist
• @ZhenjaHorbach $500 - paid in upwork ✔️

[melvin-bot]

Upwork job price has been updated to $500

[JmillsExpensify]

$500 approved for @mananjadhav

[sonialiap]

@mananjadhav please complete the checklist

[mananjadhav]

@sonialiap This was more like a new feature and hence it doesn't have an offending PR.

I think it makes sense to add a regression test for this one. @Beamanator @sonialiap let me know what you think of the following.

1. Sign up with a new account
2. Create manual expense in Self DM
3. Create workspace
4. Navigate to the self DM
5. Click on 'Categorize it' under the new expense
6. Select the new workspace
7. Verify that the loader or list of elements are shown instead of Not here
8. Open workspace setting and open categories
9. Remove all items
10. Navigate to the self DM
11. Click on 'Categorize it'
12. Select the workspace with removed categories
13. Verify that the component is displayed indicating an empty list.
14. The screen should have an Edit Categories button, and clicking on the button should navigate you to add categories page.

[sonialiap]

Thanks, Manan! That looks good to me