-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$250] [HOLD for payment 2024-05-06] Group split scan - Error appears for Merchant when clicking Split expense for the second time #40749
Comments
Triggered auto assignment to @robertjchen ( |
Triggered auto assignment to @johncschuster ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
@johncschuster FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
We think this bug might be related to #vip-split |
ProposalPlease re-state the problem that we are trying to solve in this issue.Error appears for merchant even when it is not required for non workspace expenses What is the root cause of that problem?This is a regression from #38543, Here we have added a new condition to display merchant error: App/src/components/MoneyRequestConfirmationList.tsx Lines 580 to 582 in 64695c8
The second part of this condition would return true when we the merchant is empty and What changes do you think we should make in order to solve the problem?We need to add a extra diff --git a/src/components/MoneyRequestConfirmationList.tsx b/src/components/MoneyRequestConfirmationList.tsx
index 99901dd261..87d605a7a5 100755
@@ -577,7 +577,7 @@ function MoneyRequestConfirmationList({
if (selectedParticipants.length === 0) {
return;
}
- if ((isMerchantRequired && isMerchantEmpty) || (shouldDisplayFieldError && TransactionUtils.isMerchantMissing(transaction ?? null))) {
+ if ((isMerchantRequired && isMerchantEmpty) || (isMerchantRequired && shouldDisplayFieldError && TransactionUtils.isMerchantMissing(transaction ?? null))) {
setMerchantError(true);
return;
}
What alternative solutions did you explore? (Optional) |
@GandalfGwaihir `diff --git a/src/components/MoneyRequestConfirmationList.tsx b/src/components/MoneyRequestConfirmationList.tsx
` |
This is minor UX issue, demoting @koko57 seems like its coming from your PR |
@mountiny As the follow-up PR wasn't merged yet I can fix it there |
LEts just go through upwork until ND is ready for you as it would create a backlog |
Job added to Upwork: https://www.upwork.com/jobs/~013158f9aa7567f244 |
Current assignee @Ollyws is eligible for the External assigner, not assigning anyone new. |
Applying the |
@Ollyws, I see you've just been added to the list of contributors who can accept payment via NewDot. I'll go ahead and post a payment summary instead so you can be paid via that method. |
Payment SummaryContributor+: @Ollyws - $250 via Manual Request |
@robertjchen can you complete the BZ checklist above? |
Requested in ND, thanks! |
$250 approved for @Ollyws |
Working through checklist |
Bumping this for Melvin. How's the checklist going, Robert? |
@johncschuster Made my assessment, and left the last item for you 👍 |
Thanks @robertjchen! Looks like we can close this up! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: 1.4.64-0
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail: n/a
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Expected Result:
There will be no error under Merchant field because Merchant is not a requirement for non-workspace expense.
Actual Result:
Error shows up under Merchant field when clicking Split expense for the second time.
Workaround:
unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Add any screenshot/video evidence
Bug6458020_1713821712347.20240423_053140.mp4
View all open jobs on GitHub
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @The text was updated successfully, but these errors were encountered: