[HOLD for payment 2024-05-06] [$250] Join workspace - Unapproved workspace appears in workspace switcher

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.63-13
Reproducible in staging?: Y
Reproducible in production?: N
Found when validating PR : #37959
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• "Pre-approve join requests" for the workpace is disabled on Old Dot.

1. Go to staging.new.expensify.com
2. [User A] Go to Collect workspace settings > Profile.
3. {User A] Click Share > Copy URL.
4. [User B] Navigate to the Copy URL to accept the workspace invitation.
5. [User B] After the workspace appears in workspace list, go to Chat.
6. [User B] Open workspace switcher.

Expected Result:

The unapproved workspace will not appear for User B because the join request is not approved by the admin.

Actual Result:

The unapproved workspace appears in the workspace switcher for User B with empty name and it is selected by default.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6456045_1713639831829.bandicam_2024-04-21_02-51-38-640.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013d9e03cd45fd3b64
• Upwork Job ID: 1782377855677820928
• Last Price Increase: 2024-04-22
• Automatic offers:
• nkdengineer | Contributor | 0

[melvin-bot]

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @danieldoglas (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@puneetlath I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #vip-vsb.

[izarutskaya]

Production

Recording.2384.mp4

[dragnoir]

I don't see the option "Pre-approve join requests" in my Old Dot!!!!

[mountiny]

I think this is still a new feature for new dot and we should not hold deploy on this one, its clumsy behaviour for the user, but its not blocking their use of the App, hence removing the label

I believe we have to update the the logix which creates the options the switcher to exclude the requested policies.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013d9e03cd45fd3b64

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The unapproved workspace appears in the workspace switcher for User B with empty name and it is selected by default.

What is the root cause of that problem?

In here, we don't have logic to filter out the workspace that's still pending/not approved. So it will still show up.

What changes do you think we should make in order to solve the problem?

In here, add logic to filter out the workspace that's still pending/not approved

&& !policy?.isJoinRequestPending

What alternative solutions did you explore? (Optional)

We can optionally add it into PolicyUtils.shouldShowPolicy, but I don't think we should because the workspace should still be used in the Workspace List, and we also uses shouldShowPolicy in workspace list.

[parasharrajat]

@nkdengineer's proposal makes sense as per the expected section.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Current assignees @puneetlath and @danieldoglas are eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[danieldoglas]

Proposal looks good to me, assigning.

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

I'll raise PR soon

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.67-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Unapproved workspace appears in workspace switcher #40959

If no regressions arise, payment will be issued on 2024-05-06. 🎊

For reference, here are some details about the assignees on this issue:

• @parasharrajat requires payment through NewDot Manual Requests
• @nkdengineer requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR:
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@parasharrajat] Determine if we should create a regression test for this bug.
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@puneetlath] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[puneetlath]

@parasharrajat bump on the checklist.

@nkdengineer has been paid.

[parasharrajat]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@parasharrajat] The PR that introduced the bug has been identified. Link to the PR: [Wave 8] Ideal nav  #33280
• [@parasharrajat] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/33280/files#r1591823753
• [@parasharrajat] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: NA
• [@parasharrajat] Determine if we should create a regression test for this bug. Yes
• [@parasharrajat] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Steps

1. [User A] Go to Collect workspace settings > Profile.
2. [User A] Click Share > Copy URL.
3. [User B] Navigate to the Copied URL to accept the workspace invitation.
4. [User B] After the workspace appears in workspace list, go to Chat.
5. [User B] Open workspace switcher.
6. Verify that the unapproved workspace will not appear for User B because the join request is not approved by the admin.

Do you agree 👍 or 👎 ?

[puneetlath]

Thanks!

Payment summary:

• C - $250 - @nkdengineer - paid via Upwork
• C+ - $250 - @parasharrajat - to be paid via NewDot

[parasharrajat]

Payment requested as per #40679 (comment)

[JmillsExpensify]

$250 approved for @parasharrajat