[HOLD for payment 2024-05-02] CRITICAL: [Actionable Whispers] [$500] Unable to return to invite page after returning to confirmation page

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: y
Reproducible in production?: n
Issue found when executing PR: #38709
Issue reported by: Applause - Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go to FAB > Track expense.
3. Create a track scan expense.
4. From the whisper, select Share it with my accountant.
5. Select a workspace > Click Submit.
6. Click back button on the Invite member RHP.
7. Click Submit.
8. Click back button twice.

Expected Result:

In Step 7, user should be able to submit the expense, or user should be at least allowed to proceed to invite member page.
In Step 8. the RHP will close after clicking on the back button twice.

Actual Result:

In Step 7, user is unable to proceed to invite member page after clicking on the Submit button.
In Step 8. not here RHP shows up.

Workaround:

n/a

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6453802_1713455097071.bandicam_2024-04-18_23-38-24-015.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019390c3acf2a50745
• Upwork Job ID: 1781106052824424448
• Last Price Increase: 2024-04-19
• Automatic offers:
• jjcoffee | Reviewer | 0
• bernhardoj | Contributor | 0

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[kbecciv]

We think that this bug might be related to #vip-vsb

[thienlnam]

Will take this over since it's related to track - feel free to re-assign if you are interested

[thienlnam]

Doesn't look like it needs to be a blocker - and we can probably make this external

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019390c3acf2a50745

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[melvin-bot]

Upwork job price has been updated to $500

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

In Step 7, user is unable to proceed to invite member page after clicking on the Submit button.
In Step 8. not here RHP shows up.

What is the root cause of that problem?

In the confirmation page, when clicking submit we send the ShareTrackedExpense API before navigating to the invite page.
When going back to the confirmation page, the request is submitted so we do nothing

What changes do you think we should make in order to solve the problem?

I think we should close the RHP if user click on back button on this invite page in this case

App/src/libs/actions/IOU.ts

Lines 3072 to 3076 in 9b2c518

	if (action === CONST.IOU.ACTION.SHARE) {
	Navigation.navigate(ROUTES.ROOM_INVITE.getRoute(activeReportID ?? '', CONST.IOU.SHARE.ROLE.ACCOUNTANT));
	} else {
	Navigation.dismissModal(activeReportID);
	}

    Navigation.dismissModal(activeReportID);
    if (action === CONST.IOU.ACTION.SHARE) {
        Navigation.navigate(ROUTES.ROOM_INVITE.getRoute(activeReportID ?? '', CONST.IOU.SHARE.ROLE.ACCOUNTANT));
    } 

What alternative solutions did you explore? (Optional)

NA

[DylanDylann]

RCA: In the confirmation page, when clicking submit we send the ShareTrackedExpense API before navigating to the invite page. When going back to the confirmation page, the request is submitted so we do nothing

@thienlnam From the RCA, could you help to confirm the expected on the OP?

In Step 7, user should be able to submit the expense, or user should be at least allowed to proceed to invite member page.
In Step 8. the RHP will close after clicking on the back button twice.

[shubham1206agra]

I believe the @DylanDylann solution is right. We should close the RHP and not go to the Confirmation Page again.

[shubham1206agra]

@DylanDylann's proposal looks good to me.

🎀👀🎀 C+ reviewed

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[bernhardoj]

PR is ready

cc: @jjcoffee

[jjcoffee]

PR approved by me, @thienlnam's turn! 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.65-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix confirmation page isn't closed after completing share expense #40740

If no regressions arise, payment will be issued on 2024-05-02. 🎊

For reference, here are some details about the assignees on this issue:

• @jjcoffee requires payment automatic offer (Reviewer)
• @bernhardoj requires payment automatic offer (Contributor)

[melvin-bot]

Issue is ready for payment but no BZ is assigned. @garrettmknight you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

[garrettmknight]

Paid out - @jjcoffee can you complete the checklist when you get a chance?

[jjcoffee]

• The PR that introduced the bug has been identified. Link to the PR: Feat/track whispers #38709
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/38709/files#r1590707995
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A - just a missed test case
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Open your self DM chat
2. Track a new expense. Wait until the concierge actionable whisper shows up
3. Choose Share it with my accountant
4. Select any workspace and Submit
5. Verify you are navigated to the invite page
6. Press the back button
7. Verify that the invite page is closed

Do we agree 👍 or 👎

[thienlnam]

Pending payment and addition of new QA steps cc @garrettmknight

[garrettmknight]

All set