[$250] Tag - Tag list scrolls up when selecting a tag from the list

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.63-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Collect workspace has a long list of categories or tags.

1. Go to staging.new.expensify.com
2. Go to workspace chat.
3. Start manual request flow.
4. Click Tag.
5. Select a tag from the list.
6. Click Tag again.
7. Quickly scroll down after opening tha Tag list.
8. Click on any tag.

Expected Result:

The tag will be selected and app will redirect to confirmation page.

Actual Result:

Tag list scrolls up instead.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6453294_1713425280086.tag_selection_bug.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0190130b274ac53836
• Upwork Job ID: 1781306795380563968
• Last Price Increase: 2024-04-19
• Automatic offers:
• jjcoffee | Reviewer | 0
• fedirjh | Contributor | 0

[melvin-bot]

Triggered auto assignment to @miljakljajic (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @cristipaval (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[izarutskaya]

@miljakljajic I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[izarutskaya]

We think this issue might be related to the #collect project.

[izarutskaya]

Production

bandicam.2024-04-18.12-09-06-775.mp4

[miljakljajic]

@cristipaval do you agree this is a deploy blocker?

[roryabraham]

this looks like a legit blocker to me

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0190130b274ac53836

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jjcoffee (External)

[cristipaval]

I'm not sure what is the offending PR, I am investigating to see if this one

[cristipaval]

I'm suspecting this PR as being the offending one. Still investigating.

[fedirjh]

This is the offending PR: #40234 , cc @WojtekBoman

[mountiny]

I could not repro really, not sure if there has to be some specific minimum number of tags

[josh-prof]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Tag - Tag list scrolls up when selecting a tag from the list

What is the root cause of that problem?

The root cause of this problem is that the onPress event of the BaseListItem component is not triggered, while the onMouseDown event is. This occurs due to the possibility of parent components intercepting touch events or disrupting the propagation of the onPress event.

What changes do you think we should make in order to solve the problem?

To mitigate this issue, I propose setting the e.preventDefault() for onMouseDown event handling. This action will effectively prevent ancestors from intercepting the touchable events of the component, thereby resolving the problem at hand. And that works well as you can see from attached file.

Attachment.mp4

[cristipaval]

I figured out that you don't have to scroll down quickly. You just need to scroll enough to make the selection from the top go out of the visible part of the component.

[WojtekBoman]

I'm working on that

[melvin-bot]

📣 @jjcoffee 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[cristipaval]

Thanks a lot @WojtekBoman! 🙏

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[fedirjh]

I think this can be closed.