Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS migration] Migrate IOURequestStepTag, IOURequestStepParticipants and IOURequestStepMerchant pages to TypeScript #38916

Closed
fabioh8010 opened this issue Mar 25, 2024 · 9 comments
Assignees
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration Weekly KSv2

Comments

@fabioh8010
Copy link
Contributor

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

  • src/pages/iou/request/step/IOURequestStepTag.js
  • src/pages/iou/request/step/IOURequestStepParticipants.js
  • src/pages/iou/request/step/IOURequestStepMerchant.js
@fabioh8010 fabioh8010 added Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 labels Mar 25, 2024
@fabioh8010
Copy link
Contributor Author

This issue is internal and will be handled by the TS team.

Copy link

melvin-bot bot commented Mar 25, 2024

Triggered auto assignment to @puneetlath (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@ruben-rebelo
Copy link
Contributor

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

@puneetlath puneetlath added NewFeature Something to build that is a new item. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Mar 25, 2024
Copy link

melvin-bot bot commented Mar 25, 2024

Current assignee @puneetlath is eligible for the NewFeature assigner, not assigning anyone new.

Copy link

melvin-bot bot commented Apr 19, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@puneetlath
Copy link
Contributor

It seems like this is done and we just need to pay @mananjadhav out. Is that right?

@mananjadhav
Copy link
Collaborator

Yes @puneetlath Can you please post the payment summary?

@puneetlath
Copy link
Contributor

Payment summary:

Thanks everyone!

@JmillsExpensify
Copy link

$250 approved for @mananjadhav

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NewFeature Something to build that is a new item. Reviewing Has a PR in review Typescript Migration Weekly KSv2
Projects
No open projects
Development

No branches or pull requests

6 participants