[$250] Taxes - RBR is present in expense preview but no error or violation when tax rate is invalid

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.60-13
Reproducible in staging?: Y
Reproducible in production?: Y
Found when validating PR : #39707
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Precondition:

• Admin and employee are in the same Collect workspace.
• The Collect workspace has several tax rates.

1. Go to staging.new.expensify.com
2. [Employee] Go to workspace chat.
3. [Employee] Create manual request with a tax rate in workspace chat.
4. [Admin] On Old Dot, delete the tax rate selected in Step 3.
5. [Employee] Go to Settings > About > Troubleshoot > Clear cache and restart > Reset and refresh (relogin can also be done).
6. [Employee] Navigate to the workspace chat and transaction thread with invalid tax rate.

Expected Result:

There will be an error or violation under tax rate to indicate that the tax rate is no longer valid.

Actual Result:

There is RBR in the expense preview in the workspace chat, but there is no error message or violation for the invalid tax rate in the transaction thread

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6439975_1712384377676.bandicam_2024-04-06_14-10-20-712.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018e4229ab6da1ceae
• Upwork Job ID: 1779881866618400768
• Last Price Increase: 2024-04-15
• Automatic offers:
• s77rt | Reviewer | 0
• nkdengineer | Contributor | 0

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[izarutskaya]

We think this issue might be related to the #collect project.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

There is RBR in the expense preview in the workspace chat, but there is no error message or violation for the invalid tax rate in the transaction thread

What is the root cause of that problem?

In report preview, we show the RBR if any transaction has error or has violation

App/src/components/ReportActionItem/ReportPreview.tsx

Line 140 in f150229

const hasErrors = hasMissingSmartscanFields || (canUseViolations && ReportUtils.hasViolations(iouReportID, transactionViolations)) || ReportUtils.hasActionsWithErrors(iouReportID);

But in MoneyRequestView, we don't get the error for tax field and pass it to MenuItemWithTopDescription as we do for other fields like tag, ...

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 442 in f150229

<OfflineWithFeedback pendingAction={getPendingFieldAction('taxCode')}>

App/src/components/ReportActionItem/MoneyRequestView.tsx

Lines 427 to 428 in f150229

	brickRoadIndicator={getErrorForField('tag', {tagListIndex: index, tagListName: name}) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
	error={getErrorForField('tag', {tagListIndex: index, tagListName: name})}

What changes do you think we should make in order to solve the problem?

We should get the error for tax field via getErrorField function and pass brickRoadIndicator and error prop into
MenuItemWithTopDescription for tax field here

brickRoadIndicator={getErrorForField('tax') ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : undefined}
error={getErrorForField('tax')}

App/src/components/ReportActionItem/MoneyRequestView.tsx

Line 442 in f150229

<OfflineWithFeedback pendingAction={getPendingFieldAction('taxCode')}>

OPTIONAL: We can show the error the both tax code and tax amount.

What alternative solutions did you explore? (Optional)

NA

Result

[melvin-bot]

@muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@muttmuure Huh... This is 4 days overdue. Who can take care of this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018e4229ab6da1ceae

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[s77rt]

@nkdengineer Thanks for the proposal. Your RCA is correct and the solution looks good to me, let's fix the bug for all affected fields.

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Triggered auto assignment to @stitesExpensify, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[stitesExpensify]

LGTM!

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @nkdengineer 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[nkdengineer]

@s77rt The PR is here.

[muttmuure]

Looks like this needs to be paid out?

[s77rt]

Yes but let's give this another test since QA team reported this as still reproducible in the PR #40334 (comment)

cc @nkdengineer

[nkdengineer]

@s77rt Replied in the PR. It's fixed for me on the latest main. For staging, my account doesn't have violation permission so I can't test.

[muttmuure]

Going to close this as fixed

[muttmuure]

Everyone is paid out