Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mentions v2] Replace/remove room mentions name based when creating new reportActions #39506

Closed
rlinoz opened this issue Apr 3, 2024 · 5 comments
Assignees
Labels
Daily KSv2 Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@rlinoz
Copy link
Contributor

rlinoz commented Apr 3, 2024

When creating a new reportAction we need to identify room mentions that are name based and replace them with reportID based ones if the report exists, if the report doesn't exists and the user is not a member of the policy we will remove the mention and make it plain text, the details can be found here.

Copy link

melvin-bot bot commented Apr 5, 2024

Copy link

melvin-bot bot commented Apr 5, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@rlinoz rlinoz assigned rlinoz and unassigned JmillsExpensify and rlinoz Apr 5, 2024
@rlinoz rlinoz added Daily KSv2 and removed Weekly KSv2 labels Apr 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 8, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented Apr 8, 2024

Started working on a PR, asked for query timings here: https://github.com/Expensify/Expensify/issues/385737

@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@rlinoz rlinoz added the Reviewing Has a PR in review label Apr 9, 2024
Copy link

melvin-bot bot commented Apr 16, 2024

@rlinoz Whoops! This issue is 2 days overdue. Let's get this updated quick!

@rlinoz
Copy link
Contributor Author

rlinoz commented Apr 16, 2024

@rlinoz rlinoz closed this as completed Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

2 participants