Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Mentions v2] Replace room mentions with reportName when sending emails #39515

Closed
rlinoz opened this issue Apr 3, 2024 · 5 comments
Closed

[Mentions v2] Replace room mentions with reportName when sending emails #39515

rlinoz opened this issue Apr 3, 2024 · 5 comments
Assignees
@rlinoz
Labels
Daily KSv2 Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review

Comments

@rlinoz
Copy link
Contributor

rlinoz commented Apr 3, 2024 •
edited
Loading

HOLD #39514

When sending emails we need to start replacing the room mentions with the room name as plain text, as described here in the Mentions v2 design doc.
@melvin-bot melvin-bot bot added the Monthly KSv2 label Apr 8, 2024
@rlinoz rlinoz changed the title [HOLD Mentions v2] Replace room mentions with reportName when sending emails [Mentions v2] Replace room mentions with reportName when sending emails Apr 18, 2024
@rlinoz rlinoz self-assigned this Apr 18, 2024
@rlinoz rlinoz added Daily KSv2 Monthly KSv2 NewFeature Something to build that is a new item. and removed Monthly KSv2 Daily KSv2 labels Apr 18, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to @bfitzexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@rlinoz rlinoz added Daily KSv2 and removed Monthly KSv2 labels Apr 18, 2024
@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Apr 18, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 18, 2024

⚠️ It looks like this issue is labelled as a New Feature but not tied to any GitHub Project. Keep in mind that all new features should be tied to GitHub Projects in order to properly track external CAP software time ⚠️

@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Apr 18, 2024

Triggered auto assignment to Design team member for new feature review - @dannymcclain (NewFeature)

@rlinoz rlinoz added Daily KSv2 and removed Weekly KSv2 labels Apr 18, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented Apr 22, 2024

Auth PR is up, still have a Web-E PR to put for review.

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@rlinoz rlinoz added the Reviewing Has a PR in review label Apr 24, 2024
@rlinoz
Copy link
Contributor Author

rlinoz commented Apr 30, 2024

Deployed

@rlinoz rlinoz closed this as completed Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlinoz rlinoz

Labels
Daily KSv2 Engineering NewFeature Something to build that is a new item. Reviewing Has a PR in review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rlinoz @dannymcclain @bfitzexpensify