[$500] Bank account - Error "You must accept the terms" shows up when the terms are accepted

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.56-0
Reproducible in staging?: Y
Reproducible in production?: N
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to Profile > Workspaces > any workspace.
3. Go to Bank account.
4. Click Click Connect online with Plaid.
5. Proceed with the setup.
6. In the final step (terms and agreements), click Save & continue.
7. Click Save & continue again.
8. Close the RHP.
9. Click Bank account.

Expected Result:

At the final step, after checking all terms and agreement, user will be able to set up bank account successfully.

Actual Result:

At the final step, after checking all terms and agreement, clicking on Save & continue button shows the error "You must accept the terms".
In Step 11, after closing bank account setup and reopening bank account RHP, the bank account is added successfully.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6423753_1711142400869.20240323_051525.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0171463c8654b8a151
• Upwork Job ID: 1772699947694186497
• Last Price Increase: 2024-04-02
• Automatic offers:
• fedirjh | Contributor | 0

[melvin-bot]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @flodnv (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[izarutskaya]

@muttmuure I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

We think this issue might be related to the #wave-control.

[izarutskaya]

Production

bandicam.2024-03-23.20-05-24-015.mp4

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error "You must accept the terms" shows up when the terms are accepted

What is the root cause of that problem?

We use nullish operator ?? here, this introduces a bug when the reimbursementAccount?.achData?.acceptTermsAndConditions value is null:

App/src/pages/ReimbursementAccount/CompleteVerification/substeps/ConfirmAgreements.tsx

Lines 74 to 78 in 2003844

	const defaultValues = {
	isAuthorizedToUseBankAccount: reimbursementAccount?.achData?.isAuthorizedToUseBankAccount ?? false,
	certifyTrueInformation: reimbursementAccount?.achData?.certifyTrueInformation ?? false,
	acceptTermsAndConditions: reimbursementAccount?.achData?.acceptTermsAndConditions ?? false,
	};

What changes do you think we should make in order to solve the problem?

Use || operator instead

What alternative solutions did you explore? (Optional)

N/A

[ghost]

This is the regression from this PR - #34413

[allgandalf]

you sure about that @godofoutcasts94 ? That was merged to production in january 🤔

[ghost]

yes I am pretty sure of it @GandalfGwaihir . This is the main cause because after that there has been no change in that file after January.

[flodnv]

So @godofoutcasts94 you are able to reproduce in production?

[ghost]

Yes but in the final step, I am getting that error but when I check all the terms and conditions checkboxes and click on Save & Continue, the error is displaying but when I close the RHP and click on Bank Account, then the bank account is added and getting displayed with name and selected bank
cc - @flodnv

[ghost]

If you need a working video of I can share with you as well @flodnv

[flodnv]

Yes please

[ghost]

@flodnv I used connect with plaid and this video is of the final steps of it.

Screen.Recording.2024-03-26.at.12.45.10.AM.mp4

[flodnv]

@godofoutcasts94 I'm confused because your video is on dev (not prod) and is not showing the same exact flow as the original video.

[allgandalf]

Hey @flodnv let me help you here, if you see the production video attached by @izarutskaya , they never reach to the accept terms page

This is not a deploy blocker but rather a normal bug :)

[flodnv]

Thanks for pointing that out, I agree that was not the same test. Asking for a retest here: https://expensify.slack.com/archives/C01GTK53T8Q/p1711401274700469?thread_ts=1711394653.352709&cid=C01GTK53T8Q

[flodnv]

Ok but @godofoutcasts94 is showing the bug exists on dev, no? What makes us think it does not exist on production?

[amyevans]

Testing locally on the production branch, I am still unable to successfully complete the form (albeit the exact error message is a bit different - not sure if that is meaningful and/or if I followed the exact same test steps?):

Screen.Recording.2024-03-25.at.6.20.44.PM.mov

But based on what I see at least I don't think this needs to be a deploy blocker

[muttmuure]

Making Daily

[melvin-bot]

@flodnv, @fedirjh, @muttmuure Huh... This is 4 days overdue. Who can take care of this?

[muttmuure]

@fedirjh are you able to take a look at the repro steps here?

[fedirjh]

I'm currently reviewing this.

[fedirjh]

Now I have got another error :

CleanShot.2024-06-24.at.14.45.10.mp4

[fedirjh]

This is with a brand new account:

CleanShot.2024-06-24.at.15.04.37.mp4

[melvin-bot]

@flodnv, @fedirjh, @muttmuure Whoops! This issue is 2 days overdue. Let's get this updated quick!

[fedirjh]

@kbecciv can you please re-test this bug ?

[muttmuure]

Not overdue

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[muttmuure]

Closing as not reproducible