[HOLD for BE work] Workspace chats does not show as bold for the new expense report requests

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.55-1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @puneetlath
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1710776229802789

Action Performed:

1. Send a money request to a workspace chat
2. Login as approver

Expected Result:

Message should appear bold in LHN

Actual Result:

Messages does not show in bold

Workaround:

unknonw

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Recording.2863.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ed3b85901af1a5cf
• Upwork Job ID: 1772295775561621504
• Last Price Increase: 2024-04-01

[melvin-bot]

Triggered auto assignment to @sakluger (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[nkdengineer]

Proposal

Please re-state the problem that we are trying to solve in this issue.

• Workspace chats does not show as bold for the new expense report requests

What is the root cause of that problem?

• We use this logic to check if the report is unread or not. In case the last message is ReportPreview, the !!report.lastActorAccountID is falsewhich leads to it does not show as bold.

What changes do you think we should make in order to solve the problem?

• We can update this to:

    result.isUnread = ReportUtils.isUnread(report) && (ReportActionsUtils.isReportPreviewAction(visibleReportActionItems[report.reportID]) ? true : !!report.lastActorAccountID)

What alternative solutions did you explore? (Optional)

• NA

[bernhardoj]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The chat item in LHN doesn't show as bold for the workspace admin/approver when there is an expense preview

What is the root cause of that problem?

#36950 changes the unread logic a bit by checking whether the report has a lastActorAccountID or not.

App/src/libs/SidebarUtils.ts

Line 272 in 4e6c52c

result.isUnread = ReportUtils.isUnread(report) && !!report.lastActorAccountID;

But in case the last action is a report preview, the last actor account ID is 0.

What changes do you think we should make in order to solve the problem?

First of all, we should revert #36950 as it doesn't fix the root cause of the issue. The issue that the PR is trying to fix is that when we delete the last message in a room from device A, the lastVisibleActionCreated property of the report isn't updated in device B, so the logic of unread, that is

App/src/libs/ReportUtils.ts

Line 4182 in 4e6c52c

return lastReadTime < lastVisibleActionCreated || lastReadTime < lastMentionedTime;

stays true. It will be updated once the device B opens the room. So, the problem is in the pusher that doesn't send the update to device B. Instead of patching up the issue, we should fix the pusher.

fyi, when we delete the last message, we set the lastVisibleActionCreated to empty optimistically, that's why the device A doesn't experience the issue. I think it should be set to the CREATED action created value, but I guess that's another topic to discuss

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ed3b85901af1a5cf

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @jayeshmangwani (External)

[jayeshmangwani]

Reviewing Proposals , Will update tomorrow

[jayeshmangwani]

Thanks for the proposals @nkdengineer @bernhardoj ,
@nkdengineer Your proposal will fix the issue but I also feel same what @bernhardoj mentioned here that we're patching up the issue not fixing the root cause, instead we should fix the pusher data where lastVisibleActionCreated is updated that is less then or equal to lastReadTime

@sakluger Here we have to do 2 things:

1. Assign an internal engineer to the issue so that they can investigate the Pusher issue in backend and fix that first
2. Once Pusher issue will be fixed from the backend then we can assign @bernhardoj, so that they can revert the code of this PR

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[jayeshmangwani]

@bernhardoj's Proposal looks good to me. First, we have to revert the #36950, And then we need to fix from the backend of lastVisibleActionCreated data for the #announce room and Workspace Chat

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @Julesssss, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[jayeshmangwani]

@Julesssss , this is a summary of the selected proposal; we have added this code in this PR to fix this issue, #36013 was causing because of lastVisibleActionCreated data does not update correctly from the backend; That PR caused this issue; we should fix the lastVisibleActionCreated from the backend(Pusher) when we delete the message from the #announce room and workspace chat and should remove !!report.lastActorAccountID condition from setting the isUnread

[Julesssss]

Thanks. The plan sounds good.

@sakluger FYI we'll need to get this attached to collect/control to keep this moving internally. It feels pretty minor and likely won't be in my list of priorities for a while

[sakluger]

@Julesssss I added to wave-collect as polish. It seems appropriate for that wave because requesting money is a common collect action.

[melvin-bot]

@sakluger, @jayeshmangwani Eep! 4 days overdue now. Issues have feelings too...

[sakluger]

@Julesssss are you able to review the proposal that @jayeshmangwani selected and give it a 👍 or 👎? Even if it's minor, I'd like to keep it moving forward since we have a contributor ready to fix it.

[Julesssss]

Hey @sakluger, @jayeshmangwani's plan is good, but I don't want to approve it yet. It could be a while before the backend fix is applied and by then the front-end solution might not be relevant.

I will get to this eventually, but it could be a month. I'm also happy to unassign and we can find someone else with more time. but the backend work needs to be completed before we approve the proposal.

[melvin-bot]

@sakluger, @Julesssss, @jayeshmangwani Huh... This is 4 days overdue. Who can take care of this?

[sakluger]

Ah, thanks for clarifying @Julesssss, I didn't understand that the proposal was held on BE work. I'll move this to Monthly priority for now.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[sakluger]

I asked in the original bug report thread if the bug is still occurring. If not, we can close.

[sakluger]

@puneetlath (who reported the issue originally) says that this is still reproduceable. He said:

It seems that if there is a chat message and you mark it as unread, then it does show up as bold, but if it's just a money request, and you mark that as unread, it doesn't show up as bold.

[sakluger]

No update

[Julesssss]

This is unlikely to get fixed for a while TBH. Too many internal high-priority projects

[mallenexpensify]

Trying to find a volunteer in  #wave-collect
https://expensify.slack.com/archives/C036QM0SLJK/p1720482169207219

[mallenexpensify]

Closing per internal discussion, Puneet will reopen if the bugs reoccur