[HOLD for payment 2024-05-22] [$250] [Simplified Collect][Taxes] - Save button does not move above the keyboard when keyboard is up

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.54-0
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail: N/A
Issue reported by: Applause - Internal Team

Action Performed:

Precondition:

• User is an admin of Collect workspace

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces > Collect workspace
3. Go to More features
4. Toggle on Taxes
5. Tap Add rate
6. Tap Name
7. Tap on the input field

Expected Result:

Save button will move above the keyboard when keyboard is up

Actual Result:

Save button does not move above the keyboard when keyboard is up

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6418110_1710781609993.Screen_Recording_20240319_010220_New_Expensify.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f4cc0ef178fa4831
• Upwork Job ID: 1782821416156258304
• Last Price Increase: 2024-05-27
• Automatic offers:
• dukenv0307 | Reviewer | 0
• tienifr | Contributor | 0

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @luacmartins (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[lanitochka17]

We think that this bug might be related to #wave-control

[luacmartins]

Demoting to NAB since this is for control policies.

[luacmartins]

cc @kosmydel @filip-solecki

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[filip-solecki]

Hi! I am Filip from SWM and I'd like to work on it!

[luacmartins]

I got a draft PR up, will finish the videos soon

[luacmartins]

Hmm it seems like the PR above did not fix the issue on native. @filip-solecki are you available to look into this issue?

[luacmartins]

Hmm I put up this PR . @filip-solecki could you please review?

[alexpensify]

@strepanier03 is going to step in here to help with the payment process since both Sonia and I will be OOO on May 6. Thank you, Sheena!

[strepanier03]

@tienifr - I'll check tomorrow to see if you've accepted the offer.

@dukenv0307 - I'll check tomorrow for the checklist answers and pay if possible.

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. N/A
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. N/A

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[iwiznia]

It seems that this PR was not implemented correctly, please check this comment out: #41755 (comment)

Going to close that issue and keep this one for resolving that.

[luacmartins]

@tienifr could you please take a look at this issue?

[sonialiap]

@strepanier03 thank you for your help on this one! Feel free to unassign yourself, or keep on, I'll keep an eye on payments once the issues with implementation are resolved

[strepanier03]

Thanks @sonialiap - I'll leave you to it so this isn't distraction me later on. 🙌 thank you SOOO much for taking it back over.

[sonialiap]

@tienifr looks like this PR caused this issue. Could you take a look, please?

[tienifr]

Thanks for pointing that out, I'm checking

[sonialiap]

Deployed to staging on the 15th

[sonialiap]

Payment summary

• @tienifr Contributor $125 - updated offer sent
• @dukenv0307 Reviewer $125 - updated offer sent

50% deduction due to regression
$250 / 2 = $125

[dukenv0307]

@sonialiap Thanks for your summary. As I mentioned before

I think this issue is not really easy, so the reasonable price should be 250 as usual

The price should be 250 as usual. What do you think @luacmartins ?

[sonialiap]

@luacmartins what do you think of the complexity of this issue? Do you think it's reasonable to increase the base price to 250?

[luacmartins]

Sure, we can bump it to $250 given the complexity.

[melvin-bot]

Upwork job price has been updated to $250

[sonialiap]

@tienifr Contributor $125 - updated offer sent - paid ✔️
@dukenv0307 Reviewer $125 - updated offer sent - paid ✔️

[sonialiap]

@tienifr please accept the offer so that I can complete the payment :)

[tienifr]

@sonialiap I accepted it!

[sonialiap]

@dukenv0307 please complete the checklist

[dukenv0307]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: N/A
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: N/A
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. Yes
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test

• User is an admin of Collect workspace

1. Go to staging.new.expensify.com
2. Go to Profile > Workspaces > Collect workspace
3. Go to More features
4. Toggle on Taxes
5. Tap Add rate
6. Tap Name
7. Tap on the input field
8. Verify that: Save button will move above the keyboard when keyboard is up
9. Click save button
10. Verify that: Save button is clicked