[HOLD for payment 2024-04-15] [$500] Start chat - Chat RHP switches to Room tab when dragging input from right to left

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.51-0
Reproducible in staging?: y
Reproducible in production?: yes
If this was caught during regression testing, add the test name, ID and link from TestRail:. N/A
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com.
2. Go to FAB > Start chat > # Room.
3. Type anything in the Room description field.
4. Drag the input from left to right.

Expected Result:

RHP will not switch to Room tab.

Actual Result:

RHP switches to Room tab when dragging input from right to left.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

description_swipe.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0180bfc4bd0da32526
• Upwork Job ID: 1767678074407985152
• Last Price Increase: 2024-03-27
• Automatic offers:
• Krishna2323 | Contributor | 0

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @francoisl (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[m-natarajan]

@Christinadobrzyn FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

[m-natarajan]

We think that this bug might be related to #vip-vsb
cc @quinthar

[Krishna2323]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Start chat - Chat RHP switches to Room tab when dragging input from right to left

What is the root cause of that problem?

We haven't passed shouldInterceptSwipe prop to textInput.

App/src/components/SelectionList/BaseSelectionList.tsx

Line 429 in 9ad7ca0

<TextInput

What changes do you think we should make in order to solve the problem?

Pass shouldInterceptSwipe as true. We need to also do it for room description input. We should also check if this occurs somewhere else.

App/src/pages/workspace/WorkspaceNewRoomPage.tsx

Line 274 in 92bbd8b

<InputWrapper

Optionals:

1. We can do it specifically for NewChatPage, for that we should accept shouldInterceptSwipe prop in BaseSelectionList and pass it to the input.
2. Add shouldInterceptSwipe to Input as default.

Result

[Krishna2323]

Offending PR: #34356

[francoisl]

Yep, tested a revert of that PR locally and it fixes the regression. There's already a revert PR here.

[Krishna2323]

@francoisl, what are your thoughts on addressing the similar bug affecting the description input, which is also reproducible in production.

description_swipe.mp4

[francoisl]

Ah ok, in this case I agree it would make sense to treat this as a regular bug and fix it. I'll update the issue description and open this as External so we can formally review your proposal.

[Krishna2323]

@Santhosh-Sellavel, my apologies for the delay. I haven't initiated a Slack thread yet because I already messaged @akinwale on Slack, and he assured me he would look into the matter. I'll begin a thread if he hasn't checked it within a day, he might be occupied elsewhere.

[Krishna2323]

@Santhosh-Sellavel, we can set shouldInterceptSwipe default value to true. We just need make sure that text selection works fine on native devices after doing that. #28240 (comment)

[Santhosh-Sellavel]

@francoisl

@Krishna2323's proposal looks good. It's simple enough just add on shouldInterceptSwipe the affected pages rather than making the shouldInterceptSwipe default. What are your thoughts?

[francoisl]

Ok yes, I just double-checked the issue is still reproducible on staging. The proposal makes sense, let's go ahead with it.

[melvin-bot]

📣 @Krishna2323 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[Krishna2323]

@Santhosh-Sellavel, PR ready for review.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: Start chat - Chat RHP switches to Room tab when dragging input from right to left #39329

If no regressions arise, payment will be issued on 2024-04-15. 🎊

For reference, here are some details about the assignees on this issue:

• @Santhosh-Sellavel requires payment through NewDot Manual Requests
• @Krishna2323 requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug.
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

Payouts due:

• Contributor: $500 @Krishna2323 (Paid in Upwork - https://www.upwork.com/nx/wm/workroom/36827535/overview)
• Contributor+: $500 @Santhosh-Sellavel (payment through NewDot)

Upwork job is here.

@Santhosh-Sellavel Do we need a regression test for this?

[Santhosh-Sellavel]

No, we would not need a regression test here. This is not something important & its a minor UX polish

[Santhosh-Sellavel]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@Santhosh-Sellavel] The PR that introduced the bug has been identified. Link to the PR:
• [@Santhosh-Sellavel] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@Santhosh-Sellavel] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@Santhosh-Sellavel] Determine if we should create a regression test for this bug. N/A
• [@Santhosh-Sellavel] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@Christinadobrzyn] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[Christinadobrzyn]

This is good to close - payment summary here - #38177 (comment)

[Santhosh-Sellavel]

Requested on ND

[JmillsExpensify]

$500 approved for @Santhosh-Sellavel