[HOLD for payment 2024-04-05] [$125] Workspace - Categories load without loading spinner #37904

izarutskaya · 2024-03-07T16:32:40Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Found when validating PR : #37457

Version Number: v1.4.48-0
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Issue reported by: Applause-Internal team

Action Performed:

Pre-requisite: an admin account with a policyExpenseChat enabled Collect policy and another workspace.

Open the app
Login with admin account with Collect policy
Navigate to Workspace > Settings and select the collect policy.
Select the Categories page
Verify that you see the loading spinner

Expected Result:

Categories load with loading spinner

Actual Result:

Categories load without loading spinner

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

2024-03-07.16.27.56.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01197fc8d66a9362f0
Upwork Job ID: 1770919042911531008
Last Price Increase: 2024-03-21
Automatic offers:

DylanDylann | Reviewer | 0
GandalfGwaihir | Contributor | 0

melvin-bot · 2024-03-07T16:32:52Z

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

izarutskaya · 2024-03-07T16:34:46Z

@alexpensify I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors.

izarutskaya · 2024-03-07T16:35:37Z

We think that this bug might be related to #wave8-collect-admins
CC @zanyrenney

neonbhai · 2024-03-07T17:16:52Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories load without loading spinner

What is the root cause of that problem?

We have loading spinner logic on the page, but we only check if the policyCategories are undefined, but these can be null, before fetching. Since isLoading isn't true when it is null. No loading spinner is shown

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 172 to 178 in c270b5e

    
           {isLoading && ( 
        
               <ActivityIndicator 
        
                   size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE} 
        
                   style={[styles.flex1]} 
        
                   color={theme.spinner} 
        
               /> 
        
           )}

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 128 in c270b5e

const isLoading = !isOffline && policyCategories === undefined;

What changes do you think we should make in order to solve the problem?

We should add a check for if policyCategories are null here

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 128 in c270b5e

const isLoading = !isOffline && policyCategories === undefined;

allgandalf · 2024-03-08T08:52:41Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Categories load without loading spinner

What is the root cause of that problem?

We have !isLoading set for the state where the categories are empty:

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 179 to 180 in c270b5e

    
           {categoryList.length === 0 && !isLoading && ( 
        
               <WorkspaceEmptyStateSection

But we don't have a !isLoading state for when we list of categories:

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 186 to 187 in c270b5e

    
           {categoryList.length > 0 && ( 
        
               <SelectionList

What changes do you think we should make in order to solve the problem?

We need to add a !isLoading parameter to the list:

{categoryList.length > 0 && !isLoading && (
                        <SelectionList

What alternative solutions did you explore? (Optional)

N/A

alexpensify · 2024-03-08T18:43:16Z

I'll test early next week and we can figure out the next steps. Thanks!

melvin-bot · 2024-03-11T19:39:23Z

@alexpensify Whoops! This issue is 2 days overdue. Let's get this updated quick!

alexpensify · 2024-03-11T23:20:23Z

No update yet, I need to test.

allgandalf · 2024-03-12T23:25:51Z

bump @alexpensify for review

alexpensify · 2024-03-13T19:20:47Z

I've started a discussion in the wave room related to Collect - https://expensify.slack.com/archives/C036QM0SLJK/p1710357619580229. I should have an update by tomorrow.

luacmartins · 2024-03-13T19:42:25Z

This is not a bug. We only want to show the loading spinner if we have no local data.

luacmartins · 2024-03-13T19:42:32Z

Closing this issue.

alexpensify · 2024-03-13T19:45:50Z

Thanks @luacmartins for the update!

allgandalf · 2024-03-20T14:06:38Z

Actually we do need to show a spinner cause when we make a collect workspace for the first there is no local data and we tend to see only the header like name and status at bottom of page without any present data, so i guess we should enable a loading spinner mentioned in my proposal in the category list as well:

simplescreenrecorder-2024-03-20_19.35.25.mp4

Can we reopen this issue ? @alexpensify @luacmartins

luacmartins · 2024-03-20T21:10:27Z

@GandalfGwaihir AFAIK we already do that here. Am I missing something?

allgandalf · 2024-03-20T21:17:51Z

Actually we need to add extra check over here for category list, currently:

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Lines 312 to 315 in e2bff56

    
           {!shouldShowEmptyState && ( 
        
               <SelectionList 
        
                   canSelectMultiple 
        
                   sections={[{data: categoryList, indexOffset: 0, isDisabled: false}]}

!shouldShowEmptyState is :

App/src/pages/workspace/categories/WorkspaceCategoriesPage.tsx

Line 262 in e2bff56

    
           const shouldShowEmptyState = !categoryList.some((category) => category.pendingAction !== CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE) && !isLoading;

here !isLoading is used.
So here when isLoading is true, essentially shouldShowEmptyState is set to false, but in category display, we have used !shouldShowEmptyState which will be true and we see the header preview as seen in the attached video,

We need to add an extra check:

{!shouldShowEmptyState && !isLoading &&  ( 
     <SelectionList 
         canSelectMultiple 
         sections={[{data: categoryList, indexOffset: 0, isDisabled: false}]}

allgandalf · 2024-03-20T21:28:38Z

we already do that here. Am I missing something?

Over there the isLoading check is only for the spinner icon and not the SelectionList

allgandalf · 2024-03-21T17:06:31Z

friendly bump @luacmartins :)

luacmartins · 2024-03-21T20:34:41Z

I think we should just mirror the conditions we have for the tags page. This was also what we initially had for categories, but we changed it somewhere along the way.

allgandalf · 2024-03-21T20:37:17Z

Makes sense :) Are we reopening this issue then ?

DylanDylann · 2024-03-22T14:14:47Z

This is so straightforward. @GandalfGwaihir's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

melvin-bot · 2024-03-22T14:14:58Z

Current assignee @luacmartins is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

allgandalf · 2024-03-22T14:16:12Z

also @luacmartins as this is for tags pages as well, i guess the bounty can be $250 right :)

DylanDylann · 2024-03-22T14:17:59Z

@GandalfGwaihir Please also check all other pages like tax page, member page, distance rate page,...

allgandalf · 2024-03-22T14:18:49Z

@GandalfGwaihir Please also check all other pages like tax page, member page, distance rate page,...

noted :)

c.c. @luacmartins

luacmartins · 2024-03-22T14:28:20Z

also @luacmartins as this is for tags pages as well, i guess the bounty can be $250 right :)

Sorry, the changes are really simple so we'll keep it at $125

melvin-bot · 2024-03-22T14:28:39Z

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

melvin-bot · 2024-03-22T14:28:47Z

📣 @GandalfGwaihir 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

allgandalf · 2024-03-22T14:31:37Z

Sorry, the changes are really simple so we'll keep it at $250

$125 right?

luacmartins · 2024-03-22T14:38:06Z

Yes, sorry haven't fully woken up yet. $125 I edited my message above.

allgandalf · 2024-03-22T23:14:31Z

PR ready for review @luacmartins @DylanDylann

melvin-bot · 2024-03-29T02:07:25Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2024-03-29T02:07:27Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.57-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[FIX]: Workspace - Categories load without loading spinner #38849

If no regressions arise, payment will be issued on 2024-04-05. 🎊

For reference, here are some details about the assignees on this issue:

@GandalfGwaihir requires payment automatic offer (Contributor)
@DylanDylann requires payment automatic offer (Reviewer)

melvin-bot · 2024-03-29T02:07:28Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
[@DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@DylanDylann] Determine if we should create a regression test for this bug.
[@DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

alexpensify · 2024-04-04T22:51:20Z

I confirmed the job link works here. I'll complete the payment process tomorrow.

https://www.upwork.com/jobs/~01197fc8d66a9362f0

alexpensify · 2024-04-05T21:20:52Z

Payouts due: 2024-04-05

Contributor: $125 @GandalfGwaihir
Contributor+: $125 @DylanDylann

Upwork job is here.

Closing - Everyone has been paid here

izarutskaya added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Mar 7, 2024

melvin-bot bot assigned alexpensify Mar 7, 2024

melvin-bot bot added the Overdue label Mar 11, 2024

melvin-bot bot removed the Overdue label Mar 11, 2024

luacmartins closed this as completed Mar 13, 2024

luacmartins reopened this Mar 21, 2024

luacmartins added this to [#whatsnext] #wave-collect Mar 21, 2024

luacmartins moved this to Polish in [#whatsnext] #wave-collect Mar 21, 2024

luacmartins self-assigned this Mar 21, 2024

luacmartins assigned allgandalf Mar 22, 2024

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Mar 22, 2024

allgandalf mentioned this issue Mar 22, 2024

[FIX]: Workspace - Categories load without loading spinner #38849

Merged

50 tasks

melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 22, 2024

kavimuru mentioned this issue Mar 28, 2024

Deploy Checklist: New Expensify 2024-03-27 #39033

Closed

melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Mar 29, 2024

melvin-bot bot changed the title ~~[$125] Workspace - Categories load without loading spinner~~ [HOLD for payment 2024-04-05] [$125] Workspace - Categories load without loading spinner Mar 29, 2024

melvin-bot bot removed the Reviewing Has a PR in review label Mar 29, 2024

alexpensify closed this as completed Apr 5, 2024

github-project-automation bot moved this from Polish to Done in [#whatsnext] #wave-collect Apr 5, 2024

[HOLD for payment 2024-04-05] [$125] Workspace - Categories load without loading spinner #37904

[HOLD for payment 2024-04-05] [$125] Workspace - Categories load without loading spinner #37904

Comments

izarutskaya commented Mar 7, 2024 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Mar 7, 2024

izarutskaya commented Mar 7, 2024

izarutskaya commented Mar 7, 2024

neonbhai commented Mar 7, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

allgandalf commented Mar 8, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

alexpensify commented Mar 8, 2024

melvin-bot bot commented Mar 11, 2024

alexpensify commented Mar 11, 2024

allgandalf commented Mar 12, 2024

alexpensify commented Mar 13, 2024

luacmartins commented Mar 13, 2024

luacmartins commented Mar 13, 2024

alexpensify commented Mar 13, 2024

allgandalf commented Mar 20, 2024

luacmartins commented Mar 20, 2024

allgandalf commented Mar 20, 2024 • edited Loading

allgandalf commented Mar 20, 2024

allgandalf commented Mar 21, 2024

luacmartins commented Mar 21, 2024

allgandalf commented Mar 21, 2024 • edited Loading

DylanDylann commented Mar 22, 2024 • edited Loading

melvin-bot bot commented Mar 22, 2024

allgandalf commented Mar 22, 2024

DylanDylann commented Mar 22, 2024 • edited Loading

allgandalf commented Mar 22, 2024 • edited Loading

luacmartins commented Mar 22, 2024 • edited Loading

melvin-bot bot commented Mar 22, 2024

melvin-bot bot commented Mar 22, 2024

allgandalf commented Mar 22, 2024

luacmartins commented Mar 22, 2024

allgandalf commented Mar 22, 2024

melvin-bot bot commented Mar 29, 2024

melvin-bot bot commented Mar 29, 2024

melvin-bot bot commented Mar 29, 2024

alexpensify commented Apr 4, 2024

alexpensify commented Apr 5, 2024 • edited Loading

izarutskaya commented Mar 7, 2024 •

edited by melvin-bot bot

Loading

allgandalf commented Mar 20, 2024 •

edited

Loading

allgandalf commented Mar 21, 2024 •

edited

Loading

DylanDylann commented Mar 22, 2024 •

edited

Loading

DylanDylann commented Mar 22, 2024 •

edited

Loading

allgandalf commented Mar 22, 2024 •

edited

Loading

luacmartins commented Mar 22, 2024 •

edited

Loading

alexpensify commented Apr 5, 2024 •

edited

Loading