-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2024-04-15] [$500] [Simplified Collect][Categories] - "Categorize all expense" switch is not disabled when all categories are disabled #37508
Comments
Triggered auto assignment to @abekkala ( |
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
|
Triggered auto assignment to @luacmartins ( |
We think that this bug might be related to #wave8-collect-admins |
@luacmartins FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors. |
ProposalPlease re-state the problem that we are trying to solve in this issue."Categorize all expense" switch is not disabled when all categories are disabled What is the root cause of that problem?We don't have a conditional rendering check to see if it is disabled:
What changes do you think we should make in order to solve the problem?We need to check the boolean <Switch
isOn={!policy?.areCategoriesEnabled}
disabled={OptionsListUtils.getEnabledCategoriesCount( ) === 0}
accessibilityLabel={translate('workspace.categories.requiresCategory')}
onToggle={updateWorkspaceRequiresCategory}
/> What alternative solutions did you explore? (Optional)N/A |
I don't think this is a blocker. We're still developing this feature. I'll tag @ArekChr so we can fix this as part of a follow up issue. |
@luacmartins, is this open for proposals? |
ProposalPlease re-state the problem that we are trying to solve in this issue.Category - "Categorize all expense" switch is not disabled when all categories are disabled What is the root cause of that problem?We don't check if the
What changes do you think we should make in order to solve the problem?To solve this issue for we need to get We also need to disable Also, update For turning the switch off we can use
Resultswitch_not_disabled_policy_categories.mp4AlternativeCheck for |
I'm gonna put this on hold for now, since we're introducing a new |
@abekkala, @luacmartins Whoops! This issue is 2 days overdue. Let's get this updated quick! |
this is on hold |
Not overdue, on Hold |
Will be ready in 1 hour. |
Nice! Please ping me once it's ready! |
PR is under active review! |
PR is undergoing QA |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.60-13 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2024-04-15. 🎊 For reference, here are some details about the assignees on this issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@getusha can you complete the checklist above, please? |
@tienifr payment sent and contract ended - thank you! 🎉 |
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed: [@getusha] The PR that introduced the bug has been identified. Link to the PR: I don't think this was a regression, it's something that was not considered when implementing the page. Regression Test Proposal
Do we agree 👍 or 👎 |
No need to add tests. We already did so as part of the project. |
@getusha once you accept the offer I can send payment |
@abekkala accepted, thanks. |
@getusha payment sent and contract ended - thank you! 🎉 |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Version Number: v1.4.45-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:
Action Performed:
Precondition:
Expected Result:
"Categorize all expense" switch should be disabled.
Actual Result:
"Categorize all expense" switch can be toggled on and off. On Old Dot, the switch is disabled when all categories are disabled.
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Screenshots/Videos
Bug6397092_1709215690576.20240229_113907.mp4
Add any screenshot/video evidence
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: