Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$500] Web - Workflows - After the page refreshes, the switch returns to the default value #37363

Closed
6 tasks done
lanitochka17 opened this issue Feb 27, 2024 · 24 comments
Closed
6 tasks done
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 27, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.44-7
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers): [email protected]
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Issue found when executing PR #36345

Action Performed:

  1. Go to URL https://staging.new.expensify.com/
  2. Log in to account with the Collect policy (Admin or employee)
  3. Navigate to Settings > Workspaces. You should see your Collect workspace, click on it
  4. On the LHP, you should only see the menu items below, specific to paid policies
  5. Click on Workflows
  6. Click on Delay Submissions toggle
  7. Refresh the page

Expected Result:

The switch for Delay Submissions should be on

Actual Result:

The switch for Delay Submissions returns to the default value

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6394786_1709072939488.bandicam_2024-02-27_22-55-38-911.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0113a3783dd1a2d250
  • Upwork Job ID: 1762607856414375936
  • Last Price Increase: 2024-02-27
@lanitochka17 lanitochka17 added DeployBlockerCash This issue or pull request should block deployment External Added to denote the issue can be worked on by a contributor labels Feb 27, 2024
@melvin-bot melvin-bot bot changed the title Web - Workflows - After the page refreshes, the switch returns to the default value [$500] Web - Workflows - After the page refreshes, the switch returns to the default value Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Job added to Upwork: https://www.upwork.com/jobs/~0113a3783dd1a2d250

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 27, 2024
Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

@melvin-bot melvin-bot bot added the Daily KSv2 label Feb 27, 2024
@github-actions github-actions bot added Engineering Hourly KSv2 and removed Daily KSv2 labels Feb 27, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 27, 2024

Triggered auto assignment to @stitesExpensify (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@damadoko
Copy link

Can not reproduce in MacOS: Chrome / Safari, dev environment (enabled staging server)

@dukenv0307
Copy link
Contributor

dukenv0307 commented Feb 28, 2024

Proposal

Please re-state the problem that we are trying to solve in this issue.

  • Web - Workflows - After the page refreshes, the switch returns to the default value

What is the root cause of that problem?

  • Regression from PR
  • We do not add the harvesting to optimistic data when calling SetWorkspaceAutoReporting API in here so we can reproduce this bug in offline mode

What changes do you think we should make in order to solve the problem?

  • Need to add the below to the optimistic data:
{harvesting: {enabled}}
  • Also consider adding the above to failureData

What alternative solutions did you explore? (Optional)

  • Or we can change the condition to display toggle button state from harvesting.enabled to autoReporting in here

@dragnoir
Copy link
Contributor

Can't reproduce 🤔

@puneetlath puneetlath removed the DeployBlockerCash This issue or pull request should block deployment label Feb 28, 2024
@puneetlath
Copy link
Contributor

I'm able to repro, but I don't think it needs to be a blocker. @lakchote FYI this is likely coming from your PR.

@puneetlath puneetlath added Daily KSv2 and removed Hourly KSv2 labels Feb 28, 2024
@trjExpensify trjExpensify moved this to Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals) in [#whatsnext] Wave 08 - Collect Plan Admins Feb 28, 2024
@lakchote lakchote removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Feb 28, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review and removed Daily KSv2 labels Feb 28, 2024
@dukenv0307
Copy link
Contributor

@puneetlath Can you help check this comment?

@mollfpr
Copy link
Contributor

mollfpr commented Mar 4, 2024

@mollfpr requires payment (Needs manual offer from BZ)

Not eligible for payment, since I'm not reviewing the PR.

@trjExpensify trjExpensify moved this to Release 1: Spring 2024 (May) in [#whatsnext] #wave-collect Mar 5, 2024
@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Mar 7, 2024
Copy link

melvin-bot bot commented Mar 7, 2024

Issue is ready for payment but no BZ is assigned. @kevinksullivan you are the lucky winner! Please verify the payment summary looks correct and complete the checklist. Thanks!

Copy link

melvin-bot bot commented Mar 7, 2024

Payment Summary

Upwork Job

  • ROLE: @mollfpr paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@kevinksullivan)

  • I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
  • I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1762607856414375936/hired)
  • I have paid out the Upwork contracts or cancelled the ones that are incorrect
  • I have verified the payment summary above is correct

@mollfpr mollfpr removed their assignment Mar 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 11, 2024
@dukenv0307
Copy link
Contributor

@kevinksullivan Can you help check the comment here once you have a chance. Thanks

Copy link

melvin-bot bot commented Mar 12, 2024

@lakchote, @kevinksullivan Huh... This is 4 days overdue. Who can take care of this?

Copy link

melvin-bot bot commented Mar 14, 2024

@lakchote, @kevinksullivan 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

@kevinksullivan
Copy link
Contributor

@dukenv0307 sending partial offer. Lmk when you accept

@melvin-bot melvin-bot bot removed the Overdue label Mar 15, 2024
@dukenv0307
Copy link
Contributor

@dukenv0307 sending partial offer. Lmk when you accept

@kevinksullivan I've accepted, thank you!

@melvin-bot melvin-bot bot added the Overdue label Mar 18, 2024
Copy link

melvin-bot bot commented Mar 19, 2024

@lakchote, @kevinksullivan Whoops! This issue is 2 days overdue. Let's get this updated quick!

@lakchote
Copy link
Contributor

@kevinksullivan should we close this?

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 20, 2024
@lakchote
Copy link
Contributor

@kevinksullivan should we close this?

friendly bump :)

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 25, 2024
@lakchote
Copy link
Contributor

lakchote commented Apr 1, 2024

The contributor has been paid (see here). Closing the issue.

@melvin-bot melvin-bot bot removed the Overdue label Apr 1, 2024
@lakchote lakchote changed the title [HOLD for payment 2024-03-07] [$500] Web - Workflows - After the page refreshes, the switch returns to the default value [$500] Web - Workflows - After the page refreshes, the switch returns to the default value Apr 1, 2024
@lakchote lakchote closed this as completed Apr 1, 2024
@github-project-automation github-project-automation bot moved this from Release 1: Spring 2024 (May) to Done in [#whatsnext] #wave-collect Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Engineering
Projects
No open projects
Archived in project
Status: Release 1: Ideal Nav & Collect Simplfied Profile, Members, Categories, Workflows (approvals)
Development

No branches or pull requests

9 participants