[$500] [Held requests] System message for hold/unhold request is not gray like other system messages

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.43-2
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Navigate to staging.new.expensify.com
2. Request money from any user
3. Navigate to request details page
4. Edit amount/date/description
5. Click 3-dot menu > Hold request
6. Enter a reason and save it
7. Click 3-dot menu > Unhold request

Expected Result:

The system message for hold and unhold request should be in gray like other system messages

Actual Result:

The system message for hold and unhold request is black instead of gray

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6385614_1708429169585.bandicam_2024-02-20_19-29-18-400.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d47ff630bf2f2350
• Upwork Job ID: 1759954343597240320
• Last Price Increase: 2024-02-20

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d47ff630bf2f2350

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @parasharrajat (External)

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[lanitochka17]

We think that this bug might be related to #vip-bills
CC @davidcardoza

[shubham1206agra]

I don't think this is a deploy blocker. We have approve submit flow having non-gray messages.

[johnmlee101]

I think this should definitely be fixed, although I don't know if its deploy-blocker worthy.

[johnmlee101]

@BartoszGrajdek can you take a look at this?
as part of your PR here #33897

[BartoszGrajdek]

Yeah, I'll create a fix for that 😄

[johnmlee101]

Thanks! 🙇

[parasharrajat]

Let me know if you need me to review this, I am available.

[trushpatel1]

Project Overview:
I understand that Expensify is transitioning its platform to React Native. The specific issue (#36894) is part of this larger migration effort.

Proposal Details:

Issue Analysis: My initial step will involve a thorough review of the issue as detailed in GitHub issue #36894. This includes understanding the existing challenges and the desired outcomes post-migration.

Technical Solution:

Code Refactoring: The existing code will be refactored for compatibility with React Native, ensuring a smooth transition across platforms.
Testing and Debugging: A comprehensive testing strategy will be employed to identify and resolve any bugs or issues. This includes unit testing for individual components and integration testing to ensure overall app stability.
Performance and Security: Special attention will be paid to maintaining high performance and robust security, especially given the financial nature of the Expensify app.
Documentation and Reporting:

Detailed documentation will be provided, outlining the changes made, reasons for these changes, and any new practices implemented.
Regular updates will be communicated throughout the project duration.
Final Submission:

The completed solution will be submitted via a pull request on the Expensify/App GitHub repository, in accordance with the contributing guidelines. This submission will include screenshots and evidence of testing on all platforms.
Budget and Timeline:

Proposed Fixed Price: $500

[melvin-bot]

📣 @trushpatel1! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[johnmlee101]

@BartoszGrajdek what's the latest?

[BartoszGrajdek]

Sorry - too many fixes / other issues to handle at once 😅

It looks like the change in draft PR above fixes the problem, I need to test it first though

[melvin-bot]

@youssef-lr, @parasharrajat, @BartoszGrajdek Eep! 4 days overdue now. Issues have feelings too...

[robertjchen]

Awaiting tests by @youssef-lr (and we also switched focus to partial pay/approve, but will revisit after that is out)

[youssef-lr]

Sorry haven't got to get back to that PR, but it's really just a clean up of the code now. The issue was fixed in Monil's PR.

[melvin-bot]

@youssef-lr, @parasharrajat, @BartoszGrajdek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[robertjchen]

@youssef-lr let me know how I can help finish this one out? 🙏

[trjExpensify]

What's the next step on this issue?

[youssef-lr]

@trjExpensify this is fixed, but we wanted to cleanup the code in the PR instead, so it's not really affecting the product. I'll get back to the PR review tomorrow.

[trjExpensify]

Great! How's that going?

[melvin-bot]

@youssef-lr, @parasharrajat, @BartoszGrajdek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@youssef-lr, @parasharrajat, @BartoszGrajdek 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[melvin-bot]

@youssef-lr, @parasharrajat, @BartoszGrajdek 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@youssef-lr, @parasharrajat, @BartoszGrajdek 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

This issue has not been updated in over 14 days. @youssef-lr, @parasharrajat, @BartoszGrajdek eroding to Weekly issue.

[trjExpensify]

Bump on this one. Can we get it done? Thanks!

[parasharrajat]

Looks like it was solved already in #36851. Can we please get this retested?

[trjExpensify]

The clean-up @youssef-lr mentions here?

@trjExpensify this is fixed, but we wanted to cleanup the code in the PR instead, so it's not really affecting the product. I'll get back to the PR review tomorrow.

[youssef-lr]

I think we can close this for now. The issue is fixed, I'm not sure it's wroth spending time right now on the clean up as it's pretty minor and is not causing any issues. What do you think @trjExpensify?

[trjExpensify]

I think it's fine to create another issue for it, but we shouldn't forget about drying up the code and avoiding duplicating the logic. Perhaps it can come in-line with the enhanced system message project? CC: @deetergp @dylanexpensify

[deetergp]

What is it that needs to be cleaned up here?

[parasharrajat]

Let's close this issue.

[trjExpensify]

I'll let @youssef-lr make a call on that.

[parasharrajat]

Accidentally unassigned. Please assign me back if needed.

Any update on this issue? @youssef-lr @trjExpensify

[youssef-lr]

From checking the latest code on main, I can see this has already been cleaned up. Thanks everyone!