Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tracking issue] Implement sound feature tasks and bugs #36846

Closed
Julesssss opened this issue Feb 20, 2024 · 24 comments
Closed

[Tracking issue] Implement sound feature tasks and bugs #36846

Julesssss opened this issue Feb 20, 2024 · 24 comments
Assignees
Labels
Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Task

Comments

@Julesssss
Copy link
Contributor

Julesssss commented Feb 20, 2024

Tracking issue for all issues related to the audio/sounds feature

Current issues:

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~01ace9e31f7b3ab29b
  • Upwork Job ID: 1759861492753469440
  • Last Price Increase: 2024-02-20
@Julesssss Julesssss added Weekly KSv2 Internal Requires API changes or must be handled by Expensify staff Task labels Feb 20, 2024

This comment was marked as off-topic.

@kirillzyusko
Copy link
Contributor

@Julesssss comment to assign me on this issue 👀

@kirillzyusko
Copy link
Contributor

@Julesssss can you add:

I think some of them are duplicates, but let's add all of them for better transparency?

@Julesssss
Copy link
Contributor Author

Julesssss commented Feb 20, 2024

@hoangzinh I saw you assigned, was this for a specific review?

Nevermind, i see the automation comment now

@Expensify Expensify deleted a comment from melvin-bot bot Feb 20, 2024
@shawnborton
Copy link
Contributor

@Julesssss thanks for creating this issue and keeping us organized here!

@kirillzyusko
Copy link
Contributor

Sound stops music from playing, instead of a temporary pause

I'll pick it up 👍

@kirillzyusko
Copy link
Contributor

@Julesssss let's add this to the list?

#36543

@Julesssss
Copy link
Contributor Author

Thanks, added. Though that one seems a bit vague. We'll need to try to see if anyone can reproduce

@shawnborton
Copy link
Contributor

Adding this issue here: #37098

@shawnborton
Copy link
Contributor

Not overdue, looks like we're making some progress on the issues listed in the original comment above.

@melvin-bot melvin-bot bot removed the Overdue label Mar 4, 2024
@Julesssss
Copy link
Contributor Author

Yeah, thanks Shawn.

I closed one issue today, and I have just asked in Social for an iOS user to check that a 2nd issue is still occurring (if not I will close that as fixed)

@melvin-bot melvin-bot bot added the Overdue label Mar 12, 2024
@Julesssss
Copy link
Contributor Author

When I have a spare moment I'll create the TestRail cases for QA

@melvin-bot melvin-bot bot removed the Overdue label Mar 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 25, 2024
@shawnborton
Copy link
Contributor

Not overdue, looks like just two items left here.

@melvin-bot melvin-bot bot removed the Overdue label Mar 25, 2024
@Julesssss
Copy link
Contributor Author

Yeah, I'll try to finish this up when I have a moment, but I'm working on higher-priority tasks currently 👍

@melvin-bot melvin-bot bot added the Overdue label Apr 5, 2024
@shawnborton
Copy link
Contributor

Same update as before, just one issue to wrap up and then I will send the Project Wrap Up email and call this one done.

@melvin-bot melvin-bot bot removed the Overdue label Apr 8, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 16, 2024
@shawnborton
Copy link
Contributor

Still waiting to send the wrap up email

@melvin-bot melvin-bot bot removed the Overdue label Apr 18, 2024
@shawnborton shawnborton added Monthly KSv2 and removed Weekly KSv2 labels Apr 18, 2024
@Julesssss
Copy link
Contributor Author

Hey, sorry for the delay here. I have a fire and some important issues to squeeze in before the quarterly release

@melvin-bot melvin-bot bot added the Overdue label May 23, 2024
@shawnborton
Copy link
Contributor

Still waiting on the final clean up item.

@melvin-bot melvin-bot bot removed the Overdue label May 27, 2024
@Julesssss
Copy link
Contributor Author

@shawnborton please take a look here and LMK if you have any additional test suggestions. Then I'll create the testrails cases. I think we might need a test case for when the app is open and the user is reading the chat report (notification shouldn't display, ut sound should?)

@shawnborton
Copy link
Contributor

Nice!

I think we might need a test case for when the app is open and the user is reading the chat report (notification shouldn't display, but sound should?)

That sounds correct to me

@Julesssss
Copy link
Contributor Author

Great. I added three more tests. The only thing remaining is whether we have a shareable folder with the labelled sounds. This should make testing easier, but I can't find the folder I used 😞

@shawnborton
Copy link
Contributor

Here's a folder with the sounds, let me know if this works: https://www.dropbox.com/scl/fo/t3j9sstsml5yofsrf26od/ADoDN5J3Ft7k4FYoVbax6x0?rlkey=dpvqt7h5xjzdsafj4ent564ne&dl=0

@Julesssss
Copy link
Contributor Author

Julesssss commented Jun 3, 2024

The final issue has now been closed. Marking the project complete 🥳

@shawnborton
Copy link
Contributor

Amazing, thanks Jules!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Requires API changes or must be handled by Expensify staff Monthly KSv2 Task
Projects
None yet
Development

No branches or pull requests

4 participants