Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preferences - Mute all sounds from Expensify toggle does not update on secondary device #36487

Closed
3 of 6 tasks
lanitochka17 opened this issue Feb 14, 2024 · 9 comments
Closed
3 of 6 tasks
Assignees

Comments

@lanitochka17
Copy link

lanitochka17 commented Feb 14, 2024

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Version Number: 1.4.41-2
Reproducible in staging?: Y
Reproducible in production?: No, new feature
If this was caught during regression testing, add the test name, ID and link from TestRail: https://expensify.testrail.io/index.php?/tests/view/4312305
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

  1. Log in to New Expensify on two devices with the same account
  2. Navigate to Preferences
  3. [Main device] Use both toggles below Notifications to change their state

Expected Result:

Toggles should update on secondary device to reflect changes made in main device

Actual Result:

Contrary to the other toggle, the "Mute all sounds from Expensify" toggle does not update on secondary device.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6379130_1707903552294.2024-02-14_00-03-20.mp4

View all open jobs on GitHub

@lanitochka17 lanitochka17 added the DeployBlockerCash This issue or pull request should block deployment label Feb 14, 2024
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

Copy link

melvin-bot bot commented Feb 14, 2024

Triggered auto assignment to @dangrous (Engineering), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

@jayeshmangwani
Copy link
Contributor

@dangrous Seems like a backend issue, pusher data is not updated when toggle the sound preference

@dangrous
Copy link
Contributor

dangrous commented Feb 14, 2024

Let me see if this is intended or not, I feel like there was some discussion around it that I recall, and it might be expected behavior?

EDIT: expected - #31055 (comment)

@dangrous
Copy link
Contributor

Either way this should definitely not be a deploy blocker, as the syncing never existed in the first place.

Primarily just trying to figure out if we should keep this issue open to have it call the BE or leave it and do nothing.

@dangrous dangrous added Daily KSv2 Hourly KSv2 and removed Hourly KSv2 DeployBlockerCash This issue or pull request should block deployment Daily KSv2 labels Feb 14, 2024
@dangrous
Copy link
Contributor

@Beamanator I see you're assigned to #36455 - I think we only need one of these; which would you prefer to keep open?

@dangrous dangrous added Daily KSv2 and removed Hourly KSv2 labels Feb 14, 2024
@Beamanator
Copy link
Contributor

Haha good point!

I'd say the one I'm assigned to just cuz it's been opened longer? Maybe? Feel free to take over, I don't need an extra issue or anything hahaha

@m-natarajan
Copy link

Reopening as this issue is reproducible as per this https://expensify.slack.com/archives/C049HHMV9SM/p1722620957808589

@m-natarajan m-natarajan reopened this Aug 5, 2024
@dangrous
Copy link
Contributor

dangrous commented Aug 5, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants