-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[$1250] [HOLD for payment 2024-04-03] CRITICAL: [Track Expense] - FE - Add Track Expense Flow #36362
Comments
cc @shubham1206agra While Ishpaul is working on the self-DM support, could you get started on this issue? This is holding on a few things, but there's a few things that can be done in advance like
The API call is almost done, and it would be nice to test with a draft PR to make sure we're not missing anything from the BE |
Hi! What's the ETA for this to be on staging? |
@shubham1206agra Has a draft PR up, we're waiting on the self-DM to be merged first #36361 Hopefully we can get something merged sometime late next week / early week after - does that sound like an accurate timeline once we have the self-DM for you to test with @shubham1206agra? |
Yes sounds reasonable |
Still on track for 3/8? |
Yes, I will open this for review by today. |
3/8 is here! Is it done? If no, what is the next step, who is doing it, and when? |
We've found some issues that need to be handled in the BE - I'm testing and coordinating changes with @shubham1206agra. We'll have a better sense of where things stand on Wednesday |
Ok, so on Wed you'll have an ETA? |
@thienlnam Can you please add my account in track-expense beta and enable selfdm for it? |
All accounts should have a selfDM now - we added everyone to the beta. I'll add you to the Track expense beta though |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Upwork job price has been updated to $1250 |
@thienlnam can you please assign a BZ for payment processing :) |
Triggered auto assignment to @laurenreidexpensify ( |
@shubham1206agra @ishpaul777 please apply in Upwork thanks - |
Applied! here's my profile https://www.upwork.com/freelancers/~01f4fddf5caa8bfc3a |
@shubham1206agra bump to apply in Upwork please |
Payment Summary: $1250 - @shubham1206agra bump to apply in Upwork please |
@laurenreidexpensify Offer accepted |
Payment Summary: $1250 - @shubham1206agra paid in Upwork |
@ishpaul777 can you confirm if there are any regression test steps required here? |
@ishpaul777 can you confirm if there are any regression test steps required here? |
@laurenreidexpensify New feature. No need for regression steps here. |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
@thienlnam ^^ |
@laurenreidexpensify The above is a false alert. |
https://docs.google.com/document/d/1gACVXuJS2ojNV_hwQRBLYFK_dR7vXSNlXfTnMOsdd_w/edit#bookmark=id.jw3ehgyt25yl
First, add a beta for 'trackExpense' so this only shows up for those in the beta
Add the Track Expense Button to the FAB
This will open up the standard money request selector
Instead of choosing a participant, it will automatically select the self-DM
This will optimistically create the reportAction to the self-DM
Held on 36361
Held on #368199
Note: We will have to hide the Distance option on the selector - this is held on P2P distance requests which is being worked on currently (cc @neil-marcellini )
Upwork Automation - Do Not Edit
Issue Owner
Current Issue Owner: @thienlnamThe text was updated successfully, but these errors were encountered: