Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$1250] [HOLD for payment 2024-04-03] CRITICAL: [Track Expense] - FE - Add Track Expense Flow #36362

Closed
thienlnam opened this issue Feb 12, 2024 · 32 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.

Comments

@thienlnam
Copy link
Contributor

thienlnam commented Feb 12, 2024

https://docs.google.com/document/d/1gACVXuJS2ojNV_hwQRBLYFK_dR7vXSNlXfTnMOsdd_w/edit#bookmark=id.jw3ehgyt25yl

First, add a beta for 'trackExpense' so this only shows up for those in the beta
Add the Track Expense Button to the FAB
This will open up the standard money request selector
Instead of choosing a participant, it will automatically select the self-DM
This will optimistically create the reportAction to the self-DM

image

Held on 36361
Held on #368199

Note: We will have to hide the Distance option on the selector - this is held on P2P distance requests which is being worked on currently (cc @neil-marcellini )

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0115a976392ebf591e
  • Upwork Job ID: 1773037718251933696
  • Last Price Increase: 2024-03-27
Issue OwnerCurrent Issue Owner: @thienlnam
@thienlnam
Copy link
Contributor Author

cc @shubham1206agra While Ishpaul is working on the self-DM support, could you get started on this issue?

This is holding on a few things, but there's a few things that can be done in advance like

  1. Adding the beta and Track to the global create
  2. Updating the IOU flow to skip the participant selector

The API call is almost done, and it would be nice to test with a draft PR to make sure we're not missing anything from the BE

@quinthar quinthar moved this to CRITICAL in [#whatsnext] #vip-vsb Feb 25, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 26, 2024
@quinthar quinthar changed the title [Add Track Expense] - FE - Add Track Expense Flow CRITICAL: [Track Expense] - FE - Add Track Expense Flow Feb 27, 2024
@quinthar
Copy link
Contributor

Hi! What's the ETA for this to be on staging?

@thienlnam
Copy link
Contributor Author

@shubham1206agra Has a draft PR up, we're waiting on the self-DM to be merged first #36361

Hopefully we can get something merged sometime late next week / early week after - does that sound like an accurate timeline once we have the self-DM for you to test with @shubham1206agra?

@melvin-bot melvin-bot bot removed the Overdue label Feb 28, 2024
@shubham1206agra
Copy link
Contributor

Yes sounds reasonable

@quinthar
Copy link
Contributor

quinthar commented Mar 5, 2024

Still on track for 3/8?

@shubham1206agra
Copy link
Contributor

Yes, I will open this for review by today.

@quinthar
Copy link
Contributor

quinthar commented Mar 9, 2024

3/8 is here! Is it done? If no, what is the next step, who is doing it, and when?

@thienlnam
Copy link
Contributor Author

We've found some issues that need to be handled in the BE - I'm testing and coordinating changes with @shubham1206agra. We'll have a better sense of where things stand on Wednesday

@quinthar
Copy link
Contributor

Ok, so on Wed you'll have an ETA?

@ishpaul777
Copy link
Contributor

@thienlnam Can you please add my account in track-expense beta and enable selfdm for it?

[email protected]

@thienlnam
Copy link
Contributor Author

All accounts should have a selfDM now - we added everyone to the beta. I'll add you to the Track expense beta though

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Weekly KSv2 labels Mar 20, 2024
Copy link

melvin-bot bot commented Mar 24, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

Copy link

melvin-bot bot commented Mar 27, 2024

Upwork job price has been updated to $1250

@melvin-bot melvin-bot bot added the Overdue label Apr 1, 2024
@ishpaul777
Copy link
Contributor

@thienlnam can you please assign a BZ for payment processing :)

@melvin-bot melvin-bot bot removed the Overdue label Apr 4, 2024
@thienlnam thienlnam added the NewFeature Something to build that is a new item. label Apr 4, 2024
Copy link

melvin-bot bot commented Apr 4, 2024

@laurenreidexpensify
Copy link
Contributor

@shubham1206agra @ishpaul777 please apply in Upwork thanks -
upwork.com/jobs/~017fda999369b97b34

@ishpaul777
Copy link
Contributor

Applied! here's my profile https://www.upwork.com/freelancers/~01f4fddf5caa8bfc3a

@laurenreidexpensify laurenreidexpensify added Daily KSv2 and removed Weekly KSv2 labels Apr 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 15, 2024
@laurenreidexpensify
Copy link
Contributor

@shubham1206agra bump to apply in Upwork please
@ishpaul777 offer sent 👍

@melvin-bot melvin-bot bot removed the Overdue label Apr 15, 2024
@laurenreidexpensify
Copy link
Contributor

Payment Summary:

$1250 - @shubham1206agra bump to apply in Upwork please
$1250 - @ishpaul777 paid in Upwork

@shubham1206agra
Copy link
Contributor

@laurenreidexpensify Offer accepted

@laurenreidexpensify
Copy link
Contributor

Payment Summary:

$1250 - @shubham1206agra paid in Upwork
$1250 - @ishpaul777 paid in Upwork

@laurenreidexpensify
Copy link
Contributor

@ishpaul777 can you confirm if there are any regression test steps required here?

@melvin-bot melvin-bot bot added the Overdue label Apr 22, 2024
@laurenreidexpensify
Copy link
Contributor

@ishpaul777 can you confirm if there are any regression test steps required here?

@melvin-bot melvin-bot bot removed the Overdue label Apr 22, 2024
@shubham1206agra
Copy link
Contributor

@laurenreidexpensify New feature. No need for regression steps here.

Copy link

melvin-bot bot commented Apr 22, 2024

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

@laurenreidexpensify
Copy link
Contributor

@thienlnam ^^

@shubham1206agra
Copy link
Contributor

@laurenreidexpensify The above is a false alert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 External Added to denote the issue can be worked on by a contributor Help Wanted Apply this label when an issue is open to proposals by contributors NewFeature Something to build that is a new item.
Projects
No open projects
Status: CRITICAL
Development

No branches or pull requests

5 participants