[$500] Show keyboard shortcuts page modal wherever you are in the app

[mountiny]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.37-0
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @ishpaul777
Slack conversation:

Action Performed:

Break down in numbered steps

1. Be on some chat
2. Press shortcut to open the shortcuts page CMD + J
3. Verify the page opened above the page you have just been navigated to
4. Go to Workspace settings using the bottom tabs wrench
5. Press the shortcut again
6. Verify the modal opened over whatever page you have just been at

Expected Result:

Describe what you think should've happened

Verify the modal opened over whatever page you have just been at

Actual Result:

Describe what actually happened

The modal open but the app also navigates to settings/about underneath

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0113b8ec542d75dc79
• Upwork Job ID: 1754809645699198976
• Last Price Increase: 2024-02-06
• Automatic offers:
• fedirjh | Reviewer | 28146988
• dukenv0307 | Contributor | 28146989

Issue Owner

Current Issue Owner: @isabelastisser

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0113b8ec542d75dc79

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[dukenv0307]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The modal open but the app also navigates to settings/about underneath

What is the root cause of that problem?

We have the keyboard shortcuts page route in the About route mapping here, so when the keyboard shortcuts page show, the About page will show underneath.

What changes do you think we should make in order to solve the problem?

Remove the keyboard shortcuts page route from the About route mapping here, so that page can be opened independently from the About route.

[SCREENS.SETTINGS.ABOUT]: [SCREENS.SETTINGS.APP_DOWNLOAD_LINKS],

What alternative solutions did you explore? (Optional)

NA

[fedirjh]

@dukenv0307's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @neil-marcellini, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[neil-marcellini]

@dukenv0307's proposal looks good to me.

🎀 👀 🎀 C+ reviewed

Ok, sounds good to me too. Thanks!

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @dukenv0307 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[neil-marcellini]

Not overdue, waiting for the PR

[fedirjh]

Still awaiting a PR, @dukenv0307 do you have an ETA?

[isabelastisser]

Bump @dukenv0307

[isabelastisser]

hey @dukenv0307, please provide an update. Thanks!

[dukenv0307]

I'm on the traditional holiday until February 15th

[dukenv0307]

@fedirjh The PR is ready for review.

[melvin-bot]

This issue has not been updated in over 15 days. @neil-marcellini, @isabelastisser, @fedirjh, @dukenv0307 eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[neil-marcellini]

This was deployed 2 weeks ago, what needs to be done to get it closed out @isabelastisser?

[dukenv0307]

I think we can process payment now @isabelastisser

[fedirjh]

cc @neil-marcellini Could you please add the Awaiting Payment label and bump to Daily as payment is due? Thank you.

[isabelastisser]

I will review this soon.

[fedirjh]

BugZero Checklist:

• Link to the PR: [Wave 8] Ideal nav  #33280
• Link to comment: [Wave 8] Ideal nav  #33280 (comment)
• Link to discussion: N/A
• Determine if we should create a regression test for this bug: Yes

---

Regression Test Proposal

1. Open chat
2. Press the shortcut to open the shortcuts page CMD + J
3. Verify the shortcuts page opened above the page you have just been navigated to
4. Go to Workspace settings using the bottom tabs wrench
5. Press the shortcut CMD + J again
6. Verify the modal is opened over whatever page you have just been at

• Do we agree 👍 or 👎

[isabelastisser]

Sorry for the delay, I'm reviewing this now.

[isabelastisser]

The payments were processed in Upwork.

[isabelastisser]

All set:

https://github.com/Expensify/Expensify/issues/384955