[HOLD for payment 2024-03-06][$500] [Simplified Collect][Members] WorkspaceMembersPage: Members list redesign

[luacmartins]

Implement WorkspaceMembersPage: Members list redesign from the Simplified Collect: Profile, Members, Categories design doc

Issue Owner

Current Issue Owner: @burczu

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f11d2f24fdf84777
• Upwork Job ID: 1755659075046100992
• Last Price Increase: 2024-02-08

[luacmartins]

@burczu can you please comment here so I can assign you to the issue?

[melvin-bot]

Triggered auto assignment to @adelekennedy (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[burczu]

Hi! I'm Bartek from Callstack - expert contributor group. I'll work on this issue so please assign me. Thank you.

[melvin-bot]

@burczu, @luacmartins, @adelekennedy Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f11d2f24fdf84777

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @getusha (External)

[melvin-bot]

@burczu, @luacmartins, @adelekennedy, @getusha Whoops! This issue is 2 days overdue. Let's get this updated quick!

[burczu]

@mountiny The thing is there is no renderItem prop in SelectionList therefore it's not very extensible (also it's hard to change the styles from the outside). But I guess you mean you want a separate PR for refactor, and separate for actual members re-design?

[mountiny]

@burczu Correct, lets make the refactor of the Selection list so you can pass in customized "cells" in a separate PR

[shawnborton]

I don't have strong feelings about whether or not this should be a totally new component or extend an existing one. Part of me thinks its a bit cleaner to keep it as its own component as we've seen what happens when we make design/style changes to the SelectionList and how that cascades into other places. So my OCD brain likes keeping them separate at least. Either way, probably a good discussion to bring to Slack!

[burczu]

@shawnborton I think having separate component that wraps the SelectionList is a secondary problem until it's hard to adjust the SelectionList itself.

[burczu]

Daily update: I've done most of the refactor of the Selection List now, but I need to test everything etc. I expect the PR to be published tomorrow.

[mountiny]

@burczu feel free to share drafts early to get early feedback too

[burczu]

@mountiny sure thing! here's the draft PR: #37000

[burczu]

The PR is now published and ready for review.

[burczu]

The PR with members list is now ready for review: #37074

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

Payment Summary

Upwork Job

• Contributor: @burczu is from an agency-contributor and not due payment
• ROLE: @getusha paid $500 via Upwork (LINK)

BugZero Checklist (@adelekennedy)

• I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants/1755659075046100992/hired)
• I have paid out the Upwork contracts or cancelled the ones that are incorrect
• I have verified the payment summary above is correct

[adelekennedy]

@getusha sent you an offer for the role!

[getusha]

accepted @adelekennedy

[adelekennedy]

ended contract and remitted payment