[PAID] [$500] Expense - "Enter a merchant" is still shown when the expense is paid

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.24-4
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. [Member] Go to workspace chat and create a scan request.
2. [Member] Manually enter the amount of the scanning request, while leaving Merchant empty.
3. [Admin] Pay the request.
4. [Admin] Navigate to request details view.

EXPECTED RESULT

The Merchant row will not show "Enter a merchant" since admin can no longer edit the paid expense.

ACTUAL RESULT

The Merchant row shows "Enter a merchant" with a red dot when there is no way to edit merchant for a paid expense

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

Bug6339900_1705050248772.bandicam_2024-01-12_02-47-53-164.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018efb2cb983d9645c
• Upwork Job ID: 1749775068612321280
• Last Price Increase: 2024-01-23
• Automatic offers:
• c3024 | Reviewer | 28128948
• DylanDylann | Contributor | 28128950

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[DylanDylann]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The Merchant row shows "Enter a merchant" with a red dot when there is no way to edit merchant for a paid expense

What is the root cause of that problem?

App/src/components/ReportActionItem/MoneyRequestView.js

Line 317 in b6a18b1

error={hasErrors && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

In here we don't check if the request money is paid or not

What changes do you think we should make in order to solve the problem?

We shouldn't show error if the request is paid or cancelled

App/src/components/ReportActionItem/MoneyRequestView.js

Line 317 in b6a18b1

error={hasErrors && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

error={!isSettled && !isCancelled && hasErrors && isEmptyMerchant ? translate('common.error.enterMerchant') : ''}

We also update the same thing with brickRoadIndicator

App/src/components/ReportActionItem/MoneyRequestView.js

Line 316 in b6a18b1

brickRoadIndicator={hasViolations('merchant') || (hasErrors && isEmptyMerchant) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

brickRoadIndicator={hasViolations('merchant') || (!isSettled && !isCancelled && hasErrors && isEmptyMerchant) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

Or (depend on the expected)

brickRoadIndicator={!isSettled && !isCancelled && (hasViolations('merchant') || (hasErrors && isEmptyMerchant)) ? CONST.BRICK_ROAD_INDICATOR_STATUS.ERROR : ''}

What alternative solutions did you explore? (Optional)

NA

[strepanier03]

Hmmm, gonna think about this one and likely raise it, then circle back Tuesday next week when I'm back in office.

[melvin-bot]

@strepanier03 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[strepanier03]

Update tomorrow.

[strepanier03]

All right, repro'd and raised in Slack here.

[strepanier03]

All right, tied to Wave 5 and discussion in Slack produced good outcome.

tl;dr: Rather than editing the message, we shouldn't be allowing an expense to be paid without a merchant.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018efb2cb983d9645c

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @c3024 (External)

[Pujan92]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Enter merchant violation displayed even the expense is paid

What is the root cause of that problem?

We don't have any logic to show/hide violation when the expense is paid or cancelled.

What changes do you think we should make in order to solve the problem?

We can ignore showing any violation when the expense gets paid or cancelled(if required) here.
canUseViolations && !isSettled && !isCancelled

App/src/components/ReportActionItem/MoneyRequestView.js

Line 178 in 0bdbfbb

const hasViolations = useCallback((field) => canUseViolations && getViolationsForField(field).length > 0, [canUseViolations, getViolationsForField]);

Also we need to consider the same condition before showing any violation message.

[stitesExpensify]

Hey @c3024! I know you just got assigned as c+ yesterday but it looks like there are a couple of proposals if you wouldn't mind checking them out!

[c3024]

I'll check the proposals and update in a few hours.

[c3024]

@DylanDylann 's proposal here looks good to me. brickRoadIndicator and error fields conditions should include the settled condition and show nothing accordingly.

🎀 👀 🎀 C+ Reviewed

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[DylanDylann]

@c3024 The PR is ready for review #35360

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.37-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix/34415: Hide error if request is paid  #35360

If no regressions arise, payment will be issued on 2024-02-14. 🎊

For reference, here are some details about the assignees on this issue:

• @c3024 requires payment automatic offer (Reviewer)
• @DylanDylann requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024 / @DylanDylann] The PR that introduced the bug has been identified. Link to the PR:
• [@c3024 / @DylanDylann] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@c3024 / @DylanDylann] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@c3024 / @DylanDylann] Determine if we should create a regression test for this bug.
• [@c3024 / @DylanDylann] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[strepanier03]

Looks like we're all set for tomorrow. @c3024, feel free to complete the checklist above and I'll do the reg test.

[c3024]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@c3024] The PR that introduced the bug has been identified. Link to the PR: Display Smartscan errors #26155
• [@c3024] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: 03f6abe#r138623871
• [@c3024] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: This is a specific case of settled request missed. A discussion was not started because it does not appear that this could have been identified earlier.
• [@c3024] Determine if we should create a regression test for this bug. Yes
• [@c3024] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression Test Proposal

1. Login with admin of a workspace on a device and member of the workspace on another device.
2. [Member] Go to workspace chat and create a scan request.
3. [Member] Manually enter the amount of the scanning request, while leaving Merchant empty.
4. [Admin] Pay the request.
5. [Admin] Navigate to the money request details view.
6. Verify that there is no error message nor RBR in merchant field.

👍 or 👎

[strepanier03]

Reg test done and contracts paid and closed. Thanks again @c3024 and @DylanDylann for helping get this one over the finish line!