[HOLD for payment 2023-11-17] Desktop - App redirection - Logged in with different accounts App crashed

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.96-4
Reproducible in staging?: Y
Reproducible in production?: N
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:

Action Performed:

1. Login with account A in the desktop app
2. Login with account B in the web app
3. Navigate to the user profile page in the web app
4. Refresh the browser
5. A prompt should appear asking to 'Open the link in New Expensify'
6. Click on it and wait for the desktop app to open

Expected Result:

Verify the user profile page for account B is displayed in the desktop app

Actual Result:

Logged in with different accounts App crashed
Issue reproduced when try to sign in with Apple Id/ Chrome

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

crash.1.mp4

2023-11-07.2.24.21.PM.1.mov

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @aimane-chnaif

[melvin-bot]

Triggered auto assignment to @bfitzexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @pecanoro (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[pecanoro]

Managed to reproduce:

[pecanoro]

Double checking in the PR to see if that's the cause.

[pecanoro]

Posted here, if I don't get a reply from Margelo tomorrow morning I will probably revert the PR.

[hannojg]

Hey, I am checking! Could you explain why do you think it caused the regression?

[aimane-chnaif]

@hannojg this is deploy blocker happening on staging. RNW PR is not deployed yet.

[hannojg]

Hey, the offending PR is this one:

#28927

It introduced this line without adding proper null checking

App/src/pages/home/report/ReportActionCompose/Suggestions.js

Line 49 in 24184e4

const getSuggestions = useCallback(() => suggestionEmojiRef.current.getSuggestions() || suggestionMentionRef.current.getSuggestions(), []);

Reverting this PR (this change) fixes the crash

[shubham1206agra]

Hey, the offending PR is this one:

#28927

It introduced this line without adding proper null checking

App/src/pages/home/report/ReportActionCompose/Suggestions.js

Line 49 in 24184e4

const getSuggestions = useCallback(() => suggestionEmojiRef.current.getSuggestions() || suggestionMentionRef.current.getSuggestions(), []);

Reverting this PR (this change) fixes the crash

But this PR is in production.

[allroundexperts]

PR #31072

[pecanoro]

Tested, it's working well now!

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.97-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• fix: add null check to emoji suggestions #31072

If no regressions arise, payment will be issued on 2023-11-17. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @allroundexperts does not require payment (Eligible for Manual Requests)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@allroundexperts] The PR that introduced the bug has been identified. Link to the PR:
• [@allroundexperts] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@allroundexperts] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@allroundexperts] Determine if we should create a regression test for this bug.
• [@allroundexperts] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@bfitzexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[pecanoro]

@bfitzexpensify Time to pay this one 😄

[aimane-chnaif]

Please assign me here for C+ review.

[bfitzexpensify]

Missed it as a Weekly, sorry all!

Payment summary:

Contributor: @allroundexperts to be paid $500 via manual request
C+: @aimane-chnaif to be paid $500 via Upwork - offer sent

[bfitzexpensify]

Upwork payment complete, @aimane-chnaif please complete the BZ checklist when you get a chance - thanks!

[aimane-chnaif]

• The PR that introduced the bug has been identified. Link to the PR: fix: show large suggestion menu only if there is space #28927
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: show large suggestion menu only if there is space #28927 (comment)
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Caught by Applause team. No need another regression test

[bfitzexpensify]

Great, thanks! Let's close this out.

[JmillsExpensify]

$500 payment approved for @allroundexperts based on this comment.