[HOLD for payment 2023-10-20] [$125] Split bill - Date and merchant are not saved when splitting bill #29458

lanitochka17 · 2023-10-12T15:20:09Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Version Number: 1.3.83-1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Go to staging.new.expensify.com
Go to + > Request money > Scan > Upload a receipt
Select Split on any user > Next
Enter description, date and merchant
Create the bill split
Click on the bill split preview

Expected Result:

Date and merchant are saved

Actual Result:

Date and merchant are not saved

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6234580_1697121676020.20231012_211537.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~0127c47ff7ea605892
Upwork Job ID: 1712521065352839168
Last Price Increase: 2023-10-12
Automatic offers:

bernhardoj | Contributor | 27165235
akinwale | Contributor | 27165585

melvin-bot · 2023-10-12T15:20:16Z

Triggered auto assignment to @abekkala (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

melvin-bot · 2023-10-12T15:20:18Z

Bug0 Triage Checklist (Main S/O)

This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

abekkala · 2023-10-12T15:47:14Z

@lanitochka17 can you please link the slack conversation and the screen recording of this bug?

lanitochka17 · 2023-10-12T15:52:33Z

@abekkala Hello You can see the video in the Screenshots/Videos tab

melvin-bot · 2023-10-12T17:30:16Z

Job added to Upwork: https://www.upwork.com/jobs/~0127c47ff7ea605892

melvin-bot · 2023-10-12T17:30:22Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik (External)

melvin-bot · 2023-10-12T17:31:16Z

Upwork job price has been updated to $125

mountiny · 2023-10-12T17:35:08Z

Flat $125, this is a simple fix. When se call the StartSplitbill with the receipt, we do not pass the created or date, we only pass the description.

Lets hide those two fields in case of Split with receipt creation

bernhardoj · 2023-10-12T18:01:49Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Setting merchant and date when doing scan money requests is being ignored.

What is the root cause of that problem?

When we do a scan request, we don't pass both merchant and date to the request.

App/src/pages/iou/steps/MoneyRequestConfirmPage.js

Lines 201 to 208 in 814345a

    
           IOU.startSplitBill( 
        
               selectedParticipants, 
        
               props.currentUserPersonalDetails.login, 
        
               props.currentUserPersonalDetails.accountID, 
        
               trimmedComment, 
        
               receipt, 
        
               existingSplitChatReportID, 
        
           );

So, both merchant and date value is not used.

What changes do you think we should make in order to solve the problem?

Based on the @mountiny comment above, we want to hide both the merchant and date fields for split bills with scan requests.

Pass isScanRequest prop from MoneyRequestConfirmPage to MoneyRequestConfirmationList with the value of MoneyRequestUtils.isScanRequest(props.selectedTab)
In MoneyRequestConfirmationList, define a new var called isSplitWithScan.

Add && !isSplitWithScan to both shouldShowDate and shouldShowMerchant

App/src/components/MoneyRequestConfirmationList.js

Lines 214 to 216 in 814345a

    
           // In Send Money flow, we don't allow the Merchant or Date to be edited. For distance requests, don't show the merchant as there's already another "Distance" menu item 
        
           const shouldShowDate = shouldShowAllFields && !isTypeSend; 
        
           const shouldShowMerchant = shouldShowAllFields && !isTypeSend && !props.isDistanceRequest;

melvin-bot · 2023-10-12T18:04:54Z

📣 @bernhardoj 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

melvin-bot · 2023-10-12T18:05:09Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @burczu (External)

mountiny · 2023-10-12T18:05:15Z

@bernhardoj Can you please raise a pr with urgency

melvin-bot · 2023-10-13T22:09:32Z

Reviewing label has been removed, please complete the "BugZero Checklist".

melvin-bot · 2023-10-13T22:09:35Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Hide merchant and date field for split bill with scan #29473

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@akinwale requires payment offer (Contributor)
@bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T22:09:37Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-13T23:00:29Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Hide merchant and date field for split bill with scan #29473

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@akinwale requires payment offer (Contributor)
@bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-13T23:00:31Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:26:16Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Hide merchant and date field for split bill with scan #29473

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@akinwale requires payment offer (Contributor)
@bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:26:18Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

melvin-bot · 2023-10-16T21:51:39Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Hide merchant and date field for split bill with scan #29473

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@akinwale requires payment offer (Contributor)
@bernhardoj requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-16T21:51:40Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@akinwale] The PR that introduced the bug has been identified. Link to the PR:
[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@akinwale] Determine if we should create a regression test for this bug.
[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: https://github.com/Expensify/Expensify/issues/328214

akinwale · 2023-10-18T05:41:50Z

@abekkala Just noting that the PR for this issue was initially deployed to production on 2023-10-13 since it was a deploy blocker, so the payment due date should be 2023-10-20. There were some issues with deploys so Melvin's been a bit confused lately.

I will complete the BZ checklist on Friday, the 20th.

Thanks.

abekkala · 2023-10-19T14:53:20Z

PAYMENTS TO BE MADE OCT 20

Issue reported by: Applause - Internal Team [NO PAYMENT]
@akinwale [$125] offer (Contributor)
@bernhardoj [$125] offer (Contributor)

akinwale · 2023-10-20T11:43:18Z

[@akinwale] The PR that introduced the bug has been identified. Link to the PR:

[@akinwale] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:

[@akinwale] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. Split bills with scan requests are handled differently in the backend, but the logic was not implemented in the app.

[@akinwale] Determine if we should create a regression test for this bug.

[@akinwale] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

Regression test

Launch Expensify
Open the global create menu, and select Request money
Select the Scan tab if it is not already active
Click Upload a receipt
Select Split on any user and click Next
Verify that only the Description field is visible

Do we agree 👍 or 👎?

akinwale · 2023-10-20T11:49:34Z

PAYMENTS TO BE MADE OCT 20

Issue reported by: Applause - Internal Team [NO PAYMENT]

@akinwale [$125] offer (Contributor)

@bernhardoj [$125] offer (Contributor)

I believe the issue is also eligible for the 50% bonus. Thanks.

abekkala · 2023-10-20T14:01:27Z

@akinwale yes, you are correct!

PAYMENTS TO BE MADE OCT 20

Issue reported by: Applause - Internal Team [NO PAYMENT]
@akinwale [$125 + $62.50 bonus] offer (Contributor)
@bernhardoj [$125 + $62.50 bonus] offer (Contributor)

abekkala · 2023-10-20T14:04:11Z

@akinwale [$125 + $62.50 bonus] payment made and contract ended - Thank you! 🎉

@bernhardoj [$125 + $62.50 bonus] payment made and contract ended - Thank you! 🎉

abekkala · 2023-10-20T14:06:07Z

All set!
Closing

lanitochka17 added DeployBlockerCash This issue or pull request should block deployment Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels Oct 12, 2023

melvin-bot bot assigned abekkala Oct 12, 2023

OSBotify mentioned this issue Oct 12, 2023

Deploy Checklist: New Expensify 2023-10-12 #29417

Closed

97 tasks

mountiny added the External Added to denote the issue can be worked on by a contributor label Oct 12, 2023

melvin-bot bot changed the title ~~Split bill - Date and merchant are not saved when splitting bill~~ [$500] Split bill - Date and merchant are not saved when splitting bill Oct 12, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023

melvin-bot bot assigned robertKozik Oct 12, 2023

mountiny assigned mountiny and unassigned robertKozik Oct 12, 2023

mountiny changed the title ~~[$500] Split bill - Date and merchant are not saved when splitting bill~~ [$125] Split bill - Date and merchant are not saved when splitting bill Oct 12, 2023

mountiny assigned bernhardoj Oct 12, 2023

melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Oct 12, 2023

mountiny added Help Wanted Apply this label when an issue is open to proposals by contributors and removed External Added to denote the issue can be worked on by a contributor labels Oct 12, 2023

mountiny added the External Added to denote the issue can be worked on by a contributor label Oct 12, 2023

melvin-bot bot assigned burczu Oct 12, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 13, 2023

melvin-bot bot changed the title ~~[HOLD for payment 2023-10-20] [$125] Split bill - Date and merchant are not saved when splitting bill~~ [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$125] Split bill - Date and merchant are not saved when splitting bill Oct 13, 2023

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 16, 2023

abekkala changed the title ~~[HOLD for payment 2023-10-23] [$125] Split bill - Date and merchant are not saved when splitting bill~~ [HOLD for payment 2023-10-20] [$125] Split bill - Date and merchant are not saved when splitting bill Oct 19, 2023

melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 20, 2023

abekkala closed this as completed Oct 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-20] [$125] Split bill - Date and merchant are not saved when splitting bill #29458

[HOLD for payment 2023-10-20] [$125] Split bill - Date and merchant are not saved when splitting bill #29458

lanitochka17 commented Oct 12, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

abekkala commented Oct 12, 2023 •

edited

Loading

lanitochka17 commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

mountiny commented Oct 12, 2023

bernhardoj commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

mountiny commented Oct 12, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023 •

edited by abekkala

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by abekkala

Loading

akinwale commented Oct 18, 2023 •

edited

Loading

abekkala commented Oct 19, 2023 •

edited

Loading

akinwale commented Oct 20, 2023

akinwale commented Oct 20, 2023

PAYMENTS TO BE MADE OCT 20

abekkala commented Oct 20, 2023

abekkala commented Oct 20, 2023

abekkala commented Oct 20, 2023

[HOLD for payment 2023-10-20] [$125] Split bill - Date and merchant are not saved when splitting bill #29458

[HOLD for payment 2023-10-20] [$125] Split bill - Date and merchant are not saved when splitting bill #29458

Comments

lanitochka17 commented Oct 12, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

Screenshots/Videos

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

Bug0 Triage Checklist (Main S/O)

abekkala commented Oct 12, 2023 • edited Loading

lanitochka17 commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

mountiny commented Oct 12, 2023

bernhardoj commented Oct 12, 2023

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

melvin-bot bot commented Oct 12, 2023

melvin-bot bot commented Oct 12, 2023

mountiny commented Oct 12, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 13, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023

melvin-bot bot commented Oct 16, 2023 • edited by abekkala Loading

melvin-bot bot commented Oct 16, 2023 • edited by abekkala Loading

akinwale commented Oct 18, 2023 • edited Loading

abekkala commented Oct 19, 2023 • edited Loading

PAYMENTS TO BE MADE OCT 20

akinwale commented Oct 20, 2023

akinwale commented Oct 20, 2023

PAYMENTS TO BE MADE OCT 20

abekkala commented Oct 20, 2023

PAYMENTS TO BE MADE OCT 20

abekkala commented Oct 20, 2023

abekkala commented Oct 20, 2023

lanitochka17 commented Oct 12, 2023 •

edited by melvin-bot bot

Loading

abekkala commented Oct 12, 2023 •

edited

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by abekkala

Loading

melvin-bot bot commented Oct 16, 2023 •

edited by abekkala

Loading

akinwale commented Oct 18, 2023 •

edited

Loading

abekkala commented Oct 19, 2023 •

edited

Loading