[$500] LHN - LHN of Workspace Room Only Displays "Invited" After Deleting Tagged Contact

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.83.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @tranvantoan-qn
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1697045478337999

Action Performed:

1. Log in any account >> Create a New workspace.
2. Go to the workspace's #announce room.
3. Tag any user in the compose field >> Send
4. Check the message on the LHN >> it correctly display the tagged user (OK)
5. Delete the message sent at step Add Expensify eslint #3.
6. Check the message on the LHN again.
7. Observer: It only shows "Invited" without any other information, which is confusing.

Expected Result:

It should display "No activity yet" since there is no message left in the room.

Actual Result:

It only shows "Invited" without any other information, which is confusing.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android.-.Native.mov

Android: mWeb Chrome

Android.-.Chrome.mov

iOS: Native

iOS.-.Native.MP4

iOS: mWeb Safari

RPReplay_Final1697120811.MP4

MacOS: Chrome / Safari

MacOS.-.Safari.mov

MacOS.-.Chrome.mp4

MacOS: Desktop

MacOS.-.Desktop.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d63f2bc16749a277
• Upwork Job ID: 1712476986016030720
• Last Price Increase: 2023-10-12

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01d63f2bc16749a277

[melvin-bot]

Triggered auto assignment to @twisterdotcom (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[wlegolas]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN - LHN of Workspace Room Only Displays "Invited" After Deleting Tagged Contact

What is the root cause of that problem?

The information displayed in the LHN menu comes from the lastMessageText from the Report. When deleting the comment the API is called to process the action "DeleteComment":

API.write('DeleteComment', parameters, {optimisticData, successData, failureData});

When deleting the last comment, and the delete process is occurring, we can see the information "No activity yet" when the delete process finishes, the text changed to "invited", because when finishing the "DeleteComment" in the response the Report has in the property lastMessageText the value "invited", and the Report has updated accordingly this response.

Here we can see this response:

What changes do you think we should make in order to solve the problem?

In my analysis, I found two changes.

1 - We should use the method getLastVisibleMessage from the ReportActionsUtils to get the last message text from the Report in the SidebarUtils file.

let {lastMessageText} = ReportActionsUtils.getLastVisibleMessage(report.reportID);

2 - We should modify the condition to update the Report alternateText property a bit:

result.alternateText = lastMessageText.length > 0 ? lastMessageText : Localize.translate(preferredLocale, 'report.noActivityYet');

What alternative solutions did you explore? (Optional)

I tried to understand why the API returns the invited text, but I can't see the API code, also I tried to find if there is a test to validate this scenario but I didn't find one.

Result after applied these changes:
https://github.com/Expensify/App/assets/698363/47864bd4-f323-4c18-bda4-58be04573abe

[melvin-bot]

📣 @wlegolas! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[wlegolas]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01033ea66c846b029a

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[s77rt]

@wlegolas Thanks for the proposal. I don't think your RCA is complete but the issue seems to be backend related.

[s77rt]

@twisterdotcom This should be internal. Once you tag someone in the announce room the last message of the admin channel becomes invited ... but no actual message is added. (same with the announce room, internally the lastMessage seems to be updated as well)

Screen.Recording.2023-10-12.at.7.42.26.PM.mov

[melvin-bot]

Current assignee @s77rt is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to @lakchote (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[wlegolas]

Hello @s77rt thank you for your feedback about my RCA. I agree that this problem is related to the backend because in my RCA I saw that the "invite" text comes from the API response.

I know it wasn't this time that I was able to help Expensify, maybe in the next opportunity.

[lakchote]

Working on it.

[lakchote]

PR in review.

[lakchote]

Waiting for the query to be timed before merging the PR.

[jasperhuangg]

This isn't actually a bug that we need to fix

The PRs that will handle displaying InviteToRoom actions and correctly formatting the last message text for them are in the process of being merged/deployed.

This issue won't exist once they go out.

[twisterdotcom]

Should we HOLD this, or just close @jasperhuangg?

[lakchote]

Waiting for @jasperhuangg answer.

[lakchote]

Jasper will be back on October 26th.

[melvin-bot]

@twisterdotcom @s77rt @lakchote this issue was created 2 weeks ago. Are we close to a solution? Let's make sure we're treating this as a top priority. Don't hesitate to create a thread in #expensify-open-source to align faster in real time. Thanks!

[lakchote]

DMed Jasper on Slack to have his opinion.

[tranvantoan-qn]

I will re-check it to see if the PR mentioned in this #29451 (comment) actually fixed it