[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] DEV : App crash when visiting Task's settings for the first time

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: dev only
Reproducible in staging?: only in dev
Reproducible in production?: only in dev
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696933959561659

Action Performed:

1. Go to any report.
2. Create a new task.
3. Click on task header => Choose Settings.
4. Notice app is crashed.

Expected Result:

App shouldn't be crashed while opening setting of Task

Actual Result:

App crash when visiting Task's settings for the first time

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2023-10-10.at.17.34.03.mov

Screen.Recording.2023-10-10.at.17.32.46.mov

MacOS: Desktop

Screen.Recording.2023-10-10.at.17.33.30.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01dbd96ea5f53ec4b8
• Upwork Job ID: 1712137881041838080
• Last Price Increase: 2023-10-11
• Automatic offers:
• s77rt | Reviewer | 27145434
• hungvu193 | Contributor | 27145438
• hungvu193 | Reporter | 27145441

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01dbd96ea5f53ec4b8

[melvin-bot]

Triggered auto assignment to @strepanier03 (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[hungvu193]

Post the proposal where I'm the reporter

Proposal

Please re-state the problem that we are trying to solve in this issue.

App crash when visiting Task's settings for the first time (after few reloads it will work).

What is the root cause of that problem?

We're now displaying the Settings option for our Task detail, however after creating our Task report object didn't have the property notificationPreference. Later when we accessed it here it will crash because we didn't have value for it:

App/src/pages/settings/Report/ReportSettingsPage.js

Lines 69 to 72 in a63f853

	const notificationPreference =
	report.notificationPreference !== CONST.REPORT.NOTIFICATION_PREFERENCE.HIDDEN
	? translate(`notificationPreferencesPage.notificationPreferences.${report.notificationPreference}`)
	: '';

What changes do you think we should make in order to solve the problem?

We should add the notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS, default value while creating a new task by adding it here:

App/src/libs/ReportUtils.js

Line 2821 in a63f853

parentReportID,

What alternative solutions did you explore? (Optional)

We should disable Settings option for Task report.

[Pujan92]

Seems regression from #28200 where we get rid of shouldDisableSettings which will show the settings for all report types. cc: @techievivek

[techievivek]

however after creating our Task report object didn't have the property notificationPreference. Later when we accessed it here it will crash because we didn't have value for it:

Can we add immediately as the value for the notification preference in the optimistic data for newly created task/group chats or any report?

[techievivek]

I see you have already added that, great.

[hungvu193]

I see you have already added that, great.

Yeah, similar when we created new chat reports

[techievivek]

I will wait for @s77rt to officially review the proposal.

[s77rt]

@hungvu193 Thanks for the proposal! Your RCA is correct and the solution looks good to me as well 👍

🎀 👀 🎀 C+ reviewed
Link to proposal

[melvin-bot]

Current assignee @techievivek is eligible for the choreEngineerContributorManagement assigner, not assigning anyone new.

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @hungvu193 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [CP Staging] Fix crash on task settings #29412

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter - @hungvu193 - $50
• Contributor that fixed the issue @hungvu193 - $500 + $250 = $750
• Contributor+ that helped on the issue and/or PR - @s77rt - $500 + $250 = $750

Urgency bonus assessment: Eligible for bonus after manual review and according to this comment.

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment offer (Reviewer)
• @hungvu193 requires payment offer (Contributor)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@s77rt] The PR that introduced the bug has been identified. Link to the PR: Add notification preference for all the reports and update the design for the group chats #28200
• [@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: Add notification preference for all the reports and update the design for the group chats #28200 (comment)
• [@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: Not needed
• [@s77rt] Determine if we should create a regression test for this bug. = No
• [@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again. = N/A
• [@strepanier03] Link the GH issue for creating/updating the regression test once above steps have been agreed upon: = N/A

[s77rt]

• The PR that introduced the bug has been identified: Add notification preference for all the reports and update the design for the group chats #28200
• The offending PR has been commented on: Add notification preference for all the reports and update the design for the group chats #28200 (comment)
• A discussion in #expensify-bugs has been started: Not needed
• Determine if we should create a regression test for this bug: No

[melvin-bot]

@strepanier03, @s77rt, @hungvu193, @techievivek Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[strepanier03]

Thank you, @s77rt for the checklist items.

I was offline yesterday but I'm working on this and any needed payment steps now. Appreciate the patience everyone!

[strepanier03]

All right, everyone's been paid, contracts closed, and feedback left.

Thanks again for working with the community and being such supportive and helpful members!