[HOLD for payment 2023-10-25] [$250] Workspace - Display name for #announce room members in details page is cut off

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.81-4

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Action Performed:

Precondition: User A and B do not have display name (display name is email).

1. Go to staging.new.expensify.com
2. [User A] Create a workspace and invite User B.
3. [User B] Go to #announce room and click on the room header

Expected Result:

The display name for User A and B is not cut off

Actual Result:

The display name for User A and B is cut off

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Bug6232988_1697027645425.20231011_195527.mp4

MacOS: Desktop

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013b93f9ecc21f556d
• Upwork Job ID: 1712142512040468480
• Last Price Increase: 2023-10-11
• Automatic offers:
• situchan | Contributor | 27149144
• ginsuma | Contributor | 27217842

Issue Owner

Current Issue Owner: @alexpensify

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[akinwale]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Individual long display names are cut off for the #announce room members when viewing the details.

What is the root cause of that problem?

In ReportDetailsPage, we are using the DisplayNames component to show display names, which renders the DisplayNamesWithToolTip component.

The DisplayNamesWithToolTip component renders each display name in a DisplayNamesTooltipItem. The Text component used to show the display name text has a styles.pre definition set for the style, which prevents long text from wrapping.

However, it turns out that the reportName which should be #announce is meant to be displayed here (as seen in production).

What changes do you think we should make in order to solve the problem?

Set shouldUseFullTitle to also be true if the report is not a group chat. This will ensure #announce is displayed as the title. This should also probably be done for admin rooms.

-const shouldUseFullTitle = ReportUtils.isTaskReport(props.report);
+const shouldUseFullTitle = ReportUtils.isTaskReport(props.report) || ReportUtils.isAnnounceRoom(props.report);

There is a pending PR for determining if a report is a group chat.

Since the first 2 or 3 display names will be shown for group chats, long names will also need to be properly wrapped.

Either
Add a prop to the DisplayNames component which will be forwarded to the DisplayNamesWithToolTip and DisplayNamesTooltipItem components in order to conditionally add the styles.pre style. We can call this shouldWrapLongDisplayNames.

Or
Remove the styles.pre style from the Text in the DisplayNamesTooltipItem component.

What alternative solutions did you explore? (Optional)

None.

[ginsuma]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Workspace - Display name for #announce room members in details page is cut off

What is the root cause of that problem?

In this PR #28200, we removed shouldDisableSettings and changed the condition to use the full title.
From:

App/src/pages/ReportDetailsPage.js

Line 64 in d122a0d

const shouldUseFullTitle = !shouldDisableSettings || ReportUtils.isTaskReport(props.report);

To:

App/src/pages/ReportDetailsPage.js

Line 64 in c313a62

const shouldUseFullTitle = ReportUtils.isTaskReport(props.report);

What changes do you think we should make in order to solve the problem?

Take it back to the old condition.

[techievivek]

@ginsuma

In this PR #28200, we changed the condition to use the full title.
Take it back to the old condition.

We don't want to take it back to the old condition because we want the setting option to be visible there.

[akinwale]

@ginsuma

In this PR #28200, we changed the condition to use the full title.
Take it back to the old condition.

We don't want to take it back to the old condition because we want the setting option to be visible there.

What's the expected behaviour here? Should it show the display names only if it's a group chat?

[ginsuma]

We don't want to take it back to the old condition because we want the setting option to be visible there.

I mean reuse the logic in shouldDisableSettings for the condition to use the full title. We can create a function in ReportUtils .

function shouldUseFullTitle(report) {
    return isMoneyRequestReport(report) || isPolicyExpenseChat(report) || isChatRoom(report) || isChatThread(report) || isTaskReport(report); ;
}

[techievivek]

We want to display the full title.

Should it show the display names only if it's a group chat?

For group chats let's truncate to show only first 2-3 members.

[techievivek]

Also, going to remove the deploy blocker label since it's not worth holding the deploy for it.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013b93f9ecc21f556d

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Santhosh-Sellavel (External)

[situchan]

Let's assign @ginsuma as the proposed solution meets the expected result

[melvin-bot]

📣 @ginsuma 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[ginsuma]

The PR #29669 is ready.
cc: @situchan @techievivek

[melvin-bot]

🎯 ⚡️ Woah @situchan / @ginsuma, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @ginsuma got assigned: 2023-10-16 10:49:34 Z
• when the PR got merged: 2023-10-17 03:01:32 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.86-5 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix shouldUseFullTitle in ReportDetailsPage #29669

If no regressions arise, payment will be issued on 2023-10-25. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @ginsuma requires payment offer (Contributor)
• @situchan requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@situchan] The PR that introduced the bug has been identified. Link to the PR:
• [@situchan] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@situchan] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@situchan] Determine if we should create a regression test for this bug.
• [@situchan] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[alexpensify]

Here is the payment summary:

• External issue reporter N/A
• Contributor that fixed the issue @ginsuma $375
• Contributor+ that helped on the issue and/or PR @situchan $375

Upwork Job:

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: There is an urgency bonus here #29321 (comment)

[alexpensify]

@techievivek - can you please clarify if there was a discussion to edit the price here to $250? I was going to pay here but realized that this amount is not a normal one. I want to double-check if the urgency bonus applies here too. Thanks!

[situchan]

Bonus might apply for low price issues as well.
ref: #29639 (comment)

[techievivek]

@situchan I updated the pricing to $250 because it was a straightforward change without much of to-and-fro, so I don't think we will include a bonus payment here since it's very likely that it will get merged in a single day. But I will bring this to team so they can also share their thoughts, I will update you once we reached a consensus, thanks.

[alexpensify]

Thanks, I'm going to share $375 which includes the urgency bonus and the decreased amount agreed to here.

[alexpensify]

Everyone has been paid in Upwork.

@situchan can you please complete the checklist and we can close this GH? Thanks!

[situchan]

• The PR that introduced the bug has been identified. Link to the PR: Add notification preference for all the reports and update the design for the group chats #28200
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: https://github.com/Expensify/App/pull/28200/files#r1355755359
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug.
• If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

This was caught by QA team, which means regression test already exists.

[alexpensify]

Thank you, it's closing time here. Great work!

[ginsuma]

@alexpensify I only received $250. Could you check it?

[alexpensify]

@ginsuma - I think we are all set here. I checked and Upwork is showing the two transactions - $250 and $125.