[HOLD for payment 2023-10-30] [$250] No tooltip on 3 dots for long workspace report name in settings->name

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.3.79-3
Reproducible in staging?: Yes
Reproducible in production?: Yes
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: @dhanashree-sawant
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1696842196883869

Action Performed:

1. Open the app
2. Open any long name workspace request money report or raise one and open
3. Click on header to open details page
4. Hover on 3 dots and observe that it displays complete workspace report name in tooltip
5. Click on settings
6. Hover on 3 dots in Name and observe that now no tooltip is displayed

Expected Result:

App should display tooltip on hover on 3 dots of long name workspace request money report in settings->name as it does on hover on 3 dots of name on details page

Actual Result:

App does not display tooltip on hover on 3 dots of long name workspace request money report in settings->name

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

windows.chrome.no.tooltip.3.dots.workspace.settings.name.mp4

tool.tip.mp4

MacOS: Desktop

mac.chrome.desktop.no.tooltip.on.3.dots.in.settings.name.mov

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01232e8f9165a258c0
• Upwork Job ID: 1711502579169665024
• Last Price Increase: 2023-10-17
• Automatic offers:
• hoangzinh | Reviewer | 27262796
• abzokhattab | Contributor | 27262797
• dhanashree-sawant | Reporter | 27262801

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01232e8f9165a258c0

[saranshbalyan-1234]

Proposal

Please re-state the problem that we are trying to solve in this issue.

No tooltip on 3 dots for long workspace report name in settings->name

What is the root cause of that problem?

We have not wrapped the text with Tooltip here

App/src/pages/settings/Report/ReportSettingsPage.js

Lines 165 to 170 in b2cbd26

	<Text
	numberOfLines={1}
	style={[styles.optionAlternateText, styles.pre]}
	>
	{linkedWorkspace.name}
	</Text>

What changes do you think we should make in order to solve the problem?

Change the code with Tooltip wrapping the text component like this

       <Tooltip text={linkedWorkspace.name }>
            <Text
                 numberOfLines={1}
                 style={[styles.optionAlternateText, styles.pre]}
                 >
                  {linkedWorkspace.name}
               </Text>
      </Tooltip>

What alternative solutions did you explore? (Optional)

N/A

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @hoangzinh (External)

[abzokhattab]

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

in the following code we use the Text which doesn't place a tooltip whenever we have ellipsis

https://github.com/Expensify/App/blob/main/src/pages/settings/Report/ReportSettingsPage.js#L115-L120

https://github.com/Expensify/App/blob/main/src/pages/settings/Report/ReportSettingsPage.js#L165-L170

What changes do you think we should make in order to solve the problem?

As we do in the details page we should use the DisplayNames which has a property to set the tooltip on ellipsis:

the name:

<DisplayNames
  fullTitle={reportName}
  tooltipEnabled
  numberOfLines={1}
  textStyles={[styles.optionAlternateText, styles.pre]}
  shouldUseFullTitle
/>

the workspace field:

<DisplayNames
  fullTitle={linkedWorkspace.name}
  tooltipEnabled
  numberOfLines={1}
  textStyles={[styles.optionAlternateText, styles.pre]}
  shouldUseFullTitle
/>

POC

[abzokhattab]

Forgot to mention that by making those changes, the full name will be shown only on hovering over the 3 dots

[melvin-bot]

Upwork job price has been updated to $250

[cead22]

This looks like a simple bug, and I imagine the solution will be simple as well, so I decreased the bounty

[melvin-bot]

Triggered auto assignment to @kadiealexander (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[hoangzinh]

@saranshbalyan-1234 Thanks for your proposal #29130 (comment). You provided a correct RCA but I don't think your solution matches our expectation here. Your solution will always show a tooltip when we hover on the workspace name. But according to expectation, we should only display a tooltip when we hover on the ellipsis (like the report details page)

[hoangzinh]

@abzokhattab Thanks for your proposal #29130 (comment). You provided a correct RCA and also a solution that matches our expectations here.

Therefore, I think we should go with @abzokhattab's proposal.

🎀👀🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @roryabraham, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[kadiealexander]

@roryabraham bump!

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[melvin-bot]

📣 @hoangzinh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @abzokhattab 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[melvin-bot]

📣 @dhanashree-sawant 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[roryabraham]

Sorry for the delay, was mostly OOO

[abzokhattab]

PR is ready!

[melvin-bot]

🎯 ⚡️ Woah @hoangzinh / @abzokhattab, great job pushing this forwards! ⚡️

The pull request got merged within 3 working days of assignment, so this job is eligible for a 50% #urgency bonus 🎉

• when @abzokhattab got assigned: 2023-10-18 16:50:37 Z
• when the PR got merged: 2023-10-19 20:51:41 UTC

On to the next one 🚀

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.88-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Add tooltip for long names in the settings page of workspace chat #29894

If no regressions arise, payment will be issued on 2023-10-30. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @hoangzinh requires payment offer (Reviewer)
• @abzokhattab requires payment offer (Contributor)
• @dhanashree-sawant requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@hoangzinh] The PR that introduced the bug has been identified. Link to the PR:
• [@hoangzinh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@hoangzinh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@hoangzinh] Determine if we should create a regression test for this bug.
• [@hoangzinh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@kadiealexander] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[kadiealexander]

Payouts due:

• Issue Reporter: $50 @dhanashree-sawant
• Contributor: $250 + $125 bonus @abzokhattab
• Contributor+: $250 + $125 bonus @hoangzinh

Eligible for 50% #urgency bonus? Yes

Upwork job is here.

[kadiealexander]

@hoangzinh please don't forget about the checklist!

[hoangzinh]

BugZero Checklist:

• The PR that introduced the bug has been identified. Link to the PR: Style and remove "Save" button for Default Room Settings #8164
• The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: ⛔ I think it's an enhancement, not a regression fix.
• A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: N/A
• Determine if we should create a regression test for this bug. ⛔ I think it's a small enhancement, we don't really need to create a regression test for this bug.