[$500] iOS - Chat - LHN page displayed instead Address page if using deeplink

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Issue found when executing PR #28845

Action Performed:

1. Launch app
2. Go to Settings -> Profile -> Personal Details -> Home address
3. Fill all the details
4. Log out
5. Open https://staging.new.expensify.com/settings/profile/personal-details/address

Expected Result:

Login and verify city fields are populated

Actual Result:

LHN page displayed instead of Address page if using deeplink.

Link opens Address page when user login.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.79-3

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6229076_1696707285262.RPReplay_Final1696706994.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause-Intrnal Team

Slack conversation: @

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019fb8ae8d717b70d3
• Upwork Job ID: 1710949802581405696
• Last Price Increase: 2023-10-29

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019fb8ae8d717b70d3

[melvin-bot]

Triggered auto assignment to @JmillsExpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @abdulrahuman5196 (External)

[tienifr]

Proposal

Please re-state the problem that we are trying to solve in this issue.

LHN page displayed instead of Address page if using deeplink.

What is the root cause of that problem?

In here, we will navigate to the deep link route right after user is signed in. The problem is that at that time the the authenticated status has changed but the AuthScreens did not finish rendering, so there's no RightModalNavigator screen to navigate to.

What changes do you think we should make in order to solve the problem?

We need to use another indicator to navigate (not the authenticated) we can reuse the isSidebarLoadedReady here, it will only resolve once the LHN sidebar (and the AuthScreens) is already rendered.

That can be done by replacing this line with:

SidebarUtils.isSidebarLoadedReady().then(() => {

Or we can create a new similar isAuthScreensReady method to listen for AuthScreens ready, and resolve it in componentDidMount of AuthScreens.

Then the waitForUserSignIn can be cleaned up since it's unused now.

What alternative solutions did you explore? (Optional)

We can use timeout to wait for the screen to render, but that's not desirable.

[abdulrahuman5196]

Will review the proposals tomorrow.

[abdulrahuman5196]

Missed to review this. Will close over the weekends.

[abdulrahuman5196]

@izarutskaya I tested in latest production(app store) build unable to reproduce the same if I input the magic otp directly.
Then I checked the video where the magic link is pressed directly, the issue is reproducible if only I press the magic link.

@JmillsExpensify Do we expect the deeplinks to work even if the user presses the magic link in email?
Currently none of the deeplinks work that way, as far as i tested.

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[tienifr]

@izarutskaya I tested in latest production(app store) build unable to reproduce the same if I input the magic otp directly.

@abdulrahuman5196 if the app is terminated (not backgrounded) before clicking the magic link, the issue will happen (even if you input the magic code directly)

[abdulrahuman5196]

@tienifr

if the app is terminated (not backgrounded) before clicking the magic link, the issue will happen (even if you input the magic code directly)

I don't understand this. Could you share a video of this?

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[tienifr]

I don't understand this. Could you share a video of this?

@abdulrahuman5196 sorry I meant the app is not terminated. Here's the video:

Screen.Recording.2023-10-17.at.23.58.02.mp4

Basically just need to keep app not terminated, then open the address page via deep link, then login, you'll see it's not navigating to the Address page and shows a console error.

[melvin-bot]

Current assignee @abdulrahuman5196 is eligible for the Internal assigner, not assigning anyone new.

[melvin-bot]

@JmillsExpensify, @abdulrahuman5196 Eep! 4 days overdue now. Issues have feelings too...

[abdulrahuman5196]

Reviewing now.

[abdulrahuman5196]

@tienifr 's proposal here #29060 (comment) looks good and works well

@tienifr At PR phase do test this changes with different pages and new user login to be sure.

🎀 👀 🎀
C+ Reviewed

[melvin-bot]

Triggered auto assignment to @grgia, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[grgia]

All yours @tienifr

[tienifr]

PR ready for review #31174.

[situchan]

There's regression from #31174:

[JmillsExpensify]

Have we resolved the regression yet?

[JmillsExpensify]

Then additionally, it's a little unclear where we're at with this issue as the automation looks to have failed.

[abdulrahuman5196]

@tienifr could you kindly check on this? If we have a regression? #29060 (comment)

I don't see any GH issues though.

[JmillsExpensify]

Waiting for a response

[tienifr]

Let me take a look. Completely missed this.

[tienifr]

The dev warning was already resolved in #26073. So no worry about it.

During implementation, there were already several dependency cycles on main so I thought that was not mine. As this was a minor bug and did not cause any observable issues, I hope that we won't get penalty. Thanks.

[abdulrahuman5196]

The PR that introduced the bug has been identified. Link to the PR:
The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:

Not a regression. Seems to be the case from beginning.

Determine if we should create a regression test for this bug.

Yes.

If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.

1. Log out of app
2. Navigate to /settings/profile/personal-details/address by deeplink
3. Verify Address page displays

@JmillsExpensify The melvin automation has failed. This issue for payment due today - #31174 (comment)

[JmillsExpensify]

Payment summary:

• Issue reporter: QA
• Contributor: @tienifr $500
• Contributor: @abdulrahuman5196 $500

[JmillsExpensify]

Sent both contributors an offer via Upwork

[tienifr]

Sent both contributors an offer via Upwork

@JmillsExpensify I accepted, thanks!

[abdulrahuman5196]

@JmillsExpensify Accepted the offer.

[JmillsExpensify]

All contributors paid out and regression test created. Closing this issue.