[$500] Delete request confirmation modal has Delete comment as the title

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Create a request
2. Navigate to the expense/iouReport
3. Hover over the request > click the trash icon on the comment action menu
4. Observe the title of the modal reads Delete comment

Expected Result:

The delete confirmation modal should read Delete request

Actual Result:

The delete confirmation modal reads Delete comment

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.77-5
Reproducible in staging?: Y
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

3o5sNkB2p9.mp4

Expensify/Expensify Issue URL:
Issue reported by: @trjExpensify
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01677c1677ad8e585b
• Upwork Job ID: 1709667849059155968
• Last Price Increase: 2023-10-04
• Automatic offers:
• aimane-chnaif | Reviewer | 27107636

[melvin-bot]

Current assignee @trjExpensify is eligible for the Bug assigner, not assigning anyone new.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01677c1677ad8e585b

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[neonbhai]

The title in video says Delete request (as expected?) 🤔

[ikevin127]

Proposal

Please re-state the problem that we are trying to solve in this issue

The delete confirmation modal reads Delete comment.

What is the root cause of that problem?

The problem is that within the PopoverReportActionContextMenu.js component:

https://github.com/Expensify/App/blob/ef3073066be6855bed47088b29e99a405e1d0feb/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js#L318C1-L333C7

The ConfirmModal title passes empty object reportAction to the reportActionContextMenu.deleteAction translate function which causes the function to render 'comment' because action value is false:

https://github.com/Expensify/App/blob/ef3073066be6855bed47088b29e99a405e1d0feb/src/languages/en.ts#L403C1-L403C141

What changes do you think we should make in order to solve the problem?

Within the PopoverReportActionContextMenu.js component pass the correct title by passing {action: reportAction} like it is passed below for the prompt:

            <ConfirmModal
-               title={translate('reportActionContextMenu.deleteAction', {reportAction})}
+               title={translate('reportActionContextMenu.deleteAction', {action: reportAction})}
                isVisible={isDeleteCommentConfirmModalVisible}
                shouldSetModalVisibility={shouldSetModalVisibilityForDeleteConfirmation}
                onConfirm={confirmDeleteAndHideModal}
                onCancel={hideDeleteModal}
                onModalHide={() => {
                    callbackWhenDeleteModalHide.current();
                }}
                prompt={translate('reportActionContextMenu.deleteConfirmation', {action: reportAction})}
                confirmText={translate('common.delete')}
                cancelText={translate('common.cancel')}
                danger
            />

What alternative solutions did you explore? (Optional)

N/A

Videos

web.mp4

[trjExpensify]

The title in video says Delete request (as expected?) 🤔

Ah, you're looking at the second place in the video you can see this same modal where it is indeed correct. Look at the first one shown at 0.10s where it's incorrect.

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Delete request confirmation modal has Delete comment as the title

What is the root cause of that problem?

"action" key is missing in title prop of ConfirmModal, here

App/src/pages/home/report/ContextMenu/PopoverReportActionContextMenu.js

Line 319 in 5e4550b

title={translate('reportActionContextMenu.deleteAction', {reportAction})}

What changes do you think we should make in order to solve the problem?

We need to add action key here,

title={translate('reportActionContextMenu.deleteAction', {action: reportAction})} as we have specified in prompt prop

<ConfirmModal
    title={translate('reportActionContextMenu.deleteAction', {action: reportAction})}
    isVisible={isDeleteCommentConfirmModalVisible}
    shouldSetModalVisibility={shouldSetModalVisibilityForDeleteConfirmation}
    onConfirm={confirmDeleteAndHideModal}
    onCancel={hideDeleteModal}
    onModalHide={() => {
        callbackWhenDeleteModalHide.current();
    }}
    prompt={translate('reportActionContextMenu.deleteConfirmation', {action: reportAction})}
    confirmText={translate('common.delete')}
    cancelText={translate('common.cancel')}
    danger
/>

What alternative solutions did you explore? (Optional)

NA

Result:

Screen.Recording.2023-10-05.at.11.37.39.AM.mov

[DylanDylann]

This is regression from #27221

[trjExpensify]

@DylanDylann is that to say it's being fixed elsewhere as well? CC: @OlimpiaZurek

[ikevin127]

This issue is still reproductible on current staging / local (latest main branch).

Hopefully this will be treated soon as a regression from this PR.
Otherwise my proposal is ready for review and the PR can't wait to come into existence!

[OlimpiaZurek]

I just opened the PR with the fix.

[melvin-bot]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

@trjExpensify, @OlimpiaZurek, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[aimane-chnaif]

Not overdue

[trjExpensify]

Let's make sure we add the reviewing label if it's missing.

[melvin-bot]

@trjExpensify, @OlimpiaZurek, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

Is something wrong with the PR here. It went to staging two weeks ago apparently, but no melvin notice for prod? 🤔

[melvin-bot]

@trjExpensify, @OlimpiaZurek, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[trjExpensify]

Bump on the Q above. :)

[melvin-bot]

@trjExpensify, @OlimpiaZurek, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[trjExpensify]

@OlimpiaZurek @aimane-chnaif this is on prod, so I'm really not sure what happened there. @aimane-chnaif confirming you require payment of $500 for the PR review correct?

[aimane-chnaif]

Correct. Not sure what's happening too. There was similar case at that moment. I believe this is on prod as well.

[trjExpensify]

Okay offer has been sent. 👍

[trjExpensify]

Settled up!