[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Chat - Error appears on click of notification and does not redirect to page #28328

kbecciv · 2023-09-27T16:30:30Z

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Action Performed:

From userA, send message to userB
From userB, click on the notification

Expected Result:

It should redirect to userA chat

Actual Result:

Nothing happens on click of notification and console error appears (ROUTES__WEBPACK_IMPORTED_MODULE_13_.default.getReportRoute is not a function)

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

Version Number: Dev 1.3.74-2
Reproducible in staging?: n
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-26.at.11.58.34.AM.1.mov

Screen.Recording.2023-09-28.at.11.06.03.AM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695709767898199

View all open jobs on GitHub

Upwork Automation - Do Not Edit

Upwork Job URL: https://www.upwork.com/jobs/~01d1b259b2d9260fc0
Upwork Job ID: 1707070231351926784
Last Price Increase: 2023-09-27
Automatic offers:

s77rt | Reviewer | 26983371
gadhiyamanan | Reporter | 26983373

melvin-bot · 2023-09-27T16:30:36Z

Job added to Upwork: https://www.upwork.com/jobs/~01d1b259b2d9260fc0

melvin-bot · 2023-09-27T16:30:41Z

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

redpanda-bit · 2023-09-27T17:15:38Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

Error shows in console after tapping notification and does not navigate as expected.

What is the root cause of that problem?

The notification is using a function that is no longer there.

What changes do you think we should make in order to solve the problem?

The function was moved from ROUTES.getReportRoute(reportID) to ROUTES.REPORT_WITH_ID.getRoute(reportID)

App/src/libs/actions/Report.js

Lines 1652 to 1656 in 13b2291

    
           const notificationParams = { 
        
               report, 
        
               reportAction, 
        
               onClick: () => Navigation.navigate(ROUTES.getReportRoute(reportID)), 
        
           };

What alternative solutions did you explore? (Optional)

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

Charan-hs · 2023-09-28T14:39:02Z

Proposal

Please re-state the problem that we are trying to solve in this issue.

DEV: Chat - Error appears on click of notification and does not redirect to page

What is the root cause of that problem?

This is a regression from this PR #28050
In this PR refactored ROUTES.ts here and failed to update here

App/src/libs/actions/Report.js

Line 1686 in bfda42d

onClick: () => Navigation.navigate(ROUTES.getReportRoute(reportID)),

What changes do you think we should make in order to solve the problem?

just we have to update here

App/src/libs/actions/Report.js

Line 1686 in bfda42d

onClick: () => Navigation.navigate(ROUTES.getReportRoute(reportID)),

like this

- onClick: () => Navigation.navigate(ROUTES.getReportRoute(reportID))
+ onClick: () => Navigation.navigate(ROUTES.REPORT_WITH_ID.getRoute(reportID))

What alternative solutions did you explore? (Optional)

cubuspl42 · 2023-09-29T10:07:37Z

@redpanda-bit

The function was moved from ROUTES.REPORT_WITH_ID.getRoute(reportID) toROUTES.getReportRoute(reportID)

I'm having trouble understanding what's the proposed solution. Could you try rephrasing it?

redpanda-bit · 2023-09-29T13:34:25Z

TL;DR: The function ROUTES.getReportRoute(reportID) no longer exists and the function calls to this function need to be updated to ROUTES.REPORT_WITH_ID.getRoute(reportID)

Thanks for asking for clarification!

It's pretty much the same as @Charan-hs 's proposal. I just had the changes (from -> to) backwards because of rushing to be the first proposal. I think both proposals achieve the exact same result.

redpanda-bit · 2023-09-29T13:35:47Z

Proposal

Updated

kbecciv · 2023-09-29T16:37:27Z

Issue in staging now, changing status of report to Deploy Blocker

OSBotify · 2023-09-29T16:38:09Z

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

Identify the pull request that introduced this issue and revert it.
Find someone who can quickly fix the issue.
Fix the issue yourself.

melvin-bot · 2023-09-29T16:38:13Z

Triggered auto assignment to @johnmlee101 (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

s77rt · 2023-09-29T16:44:58Z

@redpanda-bit's proposal looks good to me. Please raise a PR asap

redpanda-bit · 2023-09-29T16:46:14Z

On it @s77rt.

Expensify#28328

situchan · 2023-09-29T18:14:52Z

This is regression from #27299, not from #28050.
Especially this change:
https://github.com/Expensify/App/pull/27299/files#diff-8afe5b71ee0436c21364148c86dadd640f2bff3e3d916addbb1f1f6f7e5b6a43R1654

redpanda-bit · 2023-09-29T18:49:58Z

Going through PR checklist still.

redpanda-bit · 2023-09-29T19:01:35Z

Is anyone available to help me test the platforms I am missing?

Or is it ok this time since the change is only a one liner?

melvin-bot · 2023-10-02T17:22:52Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix notification navigation to report #28525

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@s77rt requires payment offer (Reviewer)
@redpanda-bit requires payment
@gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-02T17:22:53Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

s77rt · 2023-10-02T22:05:51Z

The PR that introduced the bug has been identified: Notifications for editing money requests #27299
The offending PR has been commented on: Notifications for editing money requests #27299 (comment)
A discussion in #expensify-bugs has been started: Not needed
Determine if we should create a regression test for this bug: No

s77rt · 2023-10-02T22:19:29Z

@cubuspl42 Sorry I didn't mean to take the C+ role. Just wanted to push this since it was a deploy blocker. Please apply in the Upwork job instead.

cubuspl42 · 2023-10-03T09:31:49Z

@s77rt No need; you did the actual job. If it was a deploy blocker, that was the right way to proceed.

melvin-bot · 2023-10-03T15:37:16Z

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.76-6 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

[CP Staging] Fix notification navigation to report #28525

If no regressions arise, payment will be issued on 2023-10-10. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

External issue reporter
Contributor that fixed the issue
Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

@s77rt requires payment offer (Reviewer)
@redpanda-bit requires payment
@gadhiyamanan requires payment offer (Reporter)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

Merged PR within 3 business days of assignment - 50% bonus
Merged PR more than 9 business days after assignment - 50% penalty

melvin-bot · 2023-10-03T15:37:18Z

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

[@s77rt] The PR that introduced the bug has been identified. Link to the PR:
[@s77rt] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
[@s77rt] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
[@s77rt] Determine if we should create a regression test for this bug.
[@s77rt] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
[@flaviadefaria] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

s77rt · 2023-10-03T15:54:36Z

Checklist filled already in #28328 (comment)

flaviadefaria · 2023-10-09T10:20:27Z

Switching this to daily so that I can issue payment this week.

flaviadefaria · 2023-10-11T09:54:13Z

Payment Summary:

For reference, here are some details about the assignees on this issue:
@s77rt requires payment offer (Reviewer)
@redpanda-bit requires payment
@gadhiyamanan requires payment offer (Reporter)

@s77rt requires - $500 - 50%(regression) = $250
@redpanda-bit - $500 - 50%(regression) = $250
@gadhiyamana - $50 (reporter)

s77rt · 2023-10-11T15:56:27Z

@flaviadefaria This did not cause a regression (it was a regression from another PR). No penalties here.

flaviadefaria · 2023-10-12T10:59:52Z

Thanks @s77rt, here's the updated Payment Summary:

For reference, here are some details about the assignees on this issue:
@s77rt requires payment offer (Reviewer)
@redpanda-bit requires payment
@gadhiyamanan requires payment offer (Reporter)

@s77rt requires - $500
@redpanda-bit - $500
@gadhiyamana - $50 (reporter)

Issuing payment now.

flaviadefaria · 2023-10-12T11:04:58Z

@s77rt requires - offer sent
@redpanda-bit - please share your UW profile link since I can't find you to send an offer
@gadhiyamana - $50 (reporter) - paid

redpanda-bit · 2023-10-12T12:28:15Z

@flaviadefaria here it is https://www.upwork.com/freelancers/~010e9950f7b5f0f0eb.

flaviadefaria · 2023-10-12T13:41:08Z

@redpanda-bit offer sent!

flaviadefaria · 2023-10-12T13:53:57Z

@s77rt requires - offer sent
@redpanda-bit - paid
@gadhiyamana - paid

@s77rt please accept the offer so that I can pay you and close this GH.

s77rt · 2023-10-12T17:28:53Z

@flaviadefaria No payment is due for me here. Just wanted to resolve the deploy blocker. This can be closed.

flaviadefaria · 2023-10-12T17:52:30Z

Ah, thanks for clarifying - closing!

kbecciv added the External Added to denote the issue can be worked on by a contributor label Sep 27, 2023

melvin-bot bot changed the title ~~DEV: Chat - Error appears on click of notification and does not redirect to page~~ [$500] DEV: Chat - Error appears on click of notification and does not redirect to page Sep 27, 2023

melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 27, 2023

melvin-bot bot assigned cubuspl42 Sep 27, 2023

melvin-bot bot added the Daily KSv2 label Sep 27, 2023

kbecciv added DeployBlockerCash This issue or pull request should block deployment and removed External Added to denote the issue can be worked on by a contributor Daily KSv2 Help Wanted Apply this label when an issue is open to proposals by contributors labels Sep 29, 2023

kbecciv changed the title ~~[$500] DEV: Chat - Error appears on click of notification and does not redirect to page~~ [$500] Chat - Error appears on click of notification and does not redirect to page Sep 29, 2023

github-actions bot added Engineering Hourly KSv2 labels Sep 29, 2023

OSBotify mentioned this issue Sep 29, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

melvin-bot bot assigned johnmlee101 Sep 29, 2023

redpanda-bit added a commit to redpanda-bit/Expensify-App that referenced this issue Sep 29, 2023

fix: notification navigation to report

0c7f552

Expensify#28328

melvin-bot bot removed the Reviewing Has a PR in review label Oct 2, 2023

s77rt mentioned this issue Oct 2, 2023

Notifications for editing money requests #27299

Merged

59 tasks

melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Oct 3, 2023

flaviadefaria added Daily KSv2 and removed Weekly KSv2 labels Oct 9, 2023

melvin-bot bot added Daily KSv2 and removed Daily KSv2 labels Oct 9, 2023

flaviadefaria closed this as completed Oct 12, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Chat - Error appears on click of notification and does not redirect to page #28328

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Chat - Error appears on click of notification and does not redirect to page #28328

kbecciv commented Sep 27, 2023 •

edited by melvin-bot bot

Loading

melvin-bot bot commented Sep 27, 2023

melvin-bot bot commented Sep 27, 2023

redpanda-bit commented Sep 27, 2023 •

edited

Loading

Charan-hs commented Sep 28, 2023 •

edited

Loading

cubuspl42 commented Sep 29, 2023

redpanda-bit commented Sep 29, 2023

redpanda-bit commented Sep 29, 2023

kbecciv commented Sep 29, 2023

OSBotify commented Sep 29, 2023

melvin-bot bot commented Sep 29, 2023

s77rt commented Sep 29, 2023

redpanda-bit commented Sep 29, 2023

situchan commented Sep 29, 2023

redpanda-bit commented Sep 29, 2023

redpanda-bit commented Sep 29, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023 •

edited by flaviadefaria

Loading

s77rt commented Oct 2, 2023

s77rt commented Oct 2, 2023

cubuspl42 commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023 •

edited by flaviadefaria

Loading

s77rt commented Oct 3, 2023

flaviadefaria commented Oct 9, 2023

flaviadefaria commented Oct 11, 2023

s77rt commented Oct 11, 2023

flaviadefaria commented Oct 12, 2023

flaviadefaria commented Oct 12, 2023

redpanda-bit commented Oct 12, 2023

flaviadefaria commented Oct 12, 2023

flaviadefaria commented Oct 12, 2023

s77rt commented Oct 12, 2023

flaviadefaria commented Oct 12, 2023

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Chat - Error appears on click of notification and does not redirect to page #28328

[HOLD for payment 2023-10-10] [HOLD for payment 2023-10-09] [$500] Chat - Error appears on click of notification and does not redirect to page #28328

Comments

kbecciv commented Sep 27, 2023 • edited by melvin-bot bot Loading

Action Performed:

Expected Result:

Actual Result:

Workaround:

Platforms:

melvin-bot bot commented Sep 27, 2023

melvin-bot bot commented Sep 27, 2023

redpanda-bit commented Sep 27, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

Charan-hs commented Sep 28, 2023 • edited Loading

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

What changes do you think we should make in order to solve the problem?

What alternative solutions did you explore? (Optional)

cubuspl42 commented Sep 29, 2023

redpanda-bit commented Sep 29, 2023

redpanda-bit commented Sep 29, 2023

Proposal

kbecciv commented Sep 29, 2023

OSBotify commented Sep 29, 2023

melvin-bot bot commented Sep 29, 2023

s77rt commented Sep 29, 2023

redpanda-bit commented Sep 29, 2023

situchan commented Sep 29, 2023

redpanda-bit commented Sep 29, 2023

redpanda-bit commented Sep 29, 2023

melvin-bot bot commented Oct 2, 2023

melvin-bot bot commented Oct 2, 2023 • edited by flaviadefaria Loading

s77rt commented Oct 2, 2023

s77rt commented Oct 2, 2023

cubuspl42 commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023

melvin-bot bot commented Oct 3, 2023 • edited by flaviadefaria Loading

s77rt commented Oct 3, 2023

flaviadefaria commented Oct 9, 2023

flaviadefaria commented Oct 11, 2023

s77rt commented Oct 11, 2023

flaviadefaria commented Oct 12, 2023

flaviadefaria commented Oct 12, 2023

redpanda-bit commented Oct 12, 2023

flaviadefaria commented Oct 12, 2023

flaviadefaria commented Oct 12, 2023

s77rt commented Oct 12, 2023

flaviadefaria commented Oct 12, 2023

kbecciv commented Sep 27, 2023 •

edited by melvin-bot bot

Loading

redpanda-bit commented Sep 27, 2023 •

edited

Loading

Charan-hs commented Sep 28, 2023 •

edited

Loading

melvin-bot bot commented Oct 2, 2023 •

edited by flaviadefaria

Loading

melvin-bot bot commented Oct 3, 2023 •

edited by flaviadefaria

Loading